From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 587F55A8C
 for <dev@dpdk.org>; Fri, 13 May 2016 18:34:56 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1b1G5E-0001YH-HL; Fri, 13 May 2016 18:37:00 +0200
To: David Marchand <david.marchand@6wind.com>
References: <1463143859-3105-1-git-send-email-olivier.matz@6wind.com>
 <1463143859-3105-7-git-send-email-olivier.matz@6wind.com>
 <CALwxeUsh6eh96r3ZLWpHcxkBXu_e3RhhEdZb_XS40cxxeuDbyQ@mail.gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Chao Zhu <chaozhu@linux.vnet.ibm.com>
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <57360229.6000803@6wind.com>
Date: Fri, 13 May 2016 18:34:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <CALwxeUsh6eh96r3ZLWpHcxkBXu_e3RhhEdZb_XS40cxxeuDbyQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 6/7] virtio: fix pci accesses for ppc64 in
	legacy mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 May 2016 16:34:56 -0000

Hi David,

On 05/13/2016 04:28 PM, David Marchand wrote:
>> +#ifdef RTE_ARCH_PPC_64
>> +       switch (length) {
>> +       case 4:
>> +               *(uint32_t *)dst = rte_be_to_cpu_32(*(uint32_t *)dst);
>> +               break;
>> +       case 2:
>> +               *(uint16_t *)dst = rte_be_to_cpu_16(*(uint16_t *)dst);
>> +               break;
>> +       default:
>> +               break;
>> +       }
>> +#endif
>>  }
> 
> I think that, in the original patch, I was handling lengths different
> than 1, 2 and 4 ;-)
> Idem for write.

Oh oh, spotted :)
I'll fix that in the v2.