From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 579E78D3D for ; Wed, 18 May 2016 12:38:52 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 18 May 2016 03:38:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,328,1459839600"; d="scan'208";a="106065685" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.123]) ([10.237.220.123]) by fmsmga004.fm.intel.com with ESMTP; 18 May 2016 03:38:50 -0700 To: Alex Wang , dev@dpdk.org References: <1463250175-3024-1-git-send-email-ee07b291@gmail.com> <1463250175-3024-2-git-send-email-ee07b291@gmail.com> Cc: Alex Wang From: Ferruh Yigit Message-ID: <573C4639.4000104@intel.com> Date: Wed, 18 May 2016 11:38:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1463250175-3024-2-git-send-email-ee07b291@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] rte_kni: Add documentation for the mempool capacity. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2016 10:38:52 -0000 On 5/14/2016 7:22 PM, Alex Wang wrote: > From: Alex Wang > > Function like 'rte_kni_rx_burst()' keeps allocating > 'MAX_MBUF_BURST_NUM' mbufs to kni fifo queue unless the > queue's capacity ('KNI_FIFO_COUNT_MAX') is reached. So, > if the mempool is under-provisioned, user may run into > "Out of Memory" logs from KNI code. This commit documents > the need to provision mempool capacity of couple thousand > elements for each KNI interface. > > Signed-off-by: Alex Wang > --- > lib/librte_kni/rte_kni.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h > index 25fa45e..05d2d39 100644 > --- a/lib/librte_kni/rte_kni.h > +++ b/lib/librte_kni/rte_kni.h > @@ -113,6 +113,9 @@ extern void rte_kni_init(unsigned int max_kni_ifaces); > * The rte_kni_alloc shall not be called before rte_kni_init() has been > * called. rte_kni_alloc is thread safe. > * > + * The mempool should have capacity of couple thousand elements for each > + * KNI interface allocated. > + * > * @param pktmbuf_pool > * The mempool for allocting mbufs for packets. > * @param conf > Hi Alex, Same comments are valid for patch subject. How about saying "more than 2xKNI_FIFO_COUNT_MAX" instead of saying "couple thousand elements"? Thanks, ferruh