Re: [dpdk-dev] [PATCH v2 5/7] eal/linux: mmap ioports on ppc64

[Olivier Matz <olivier.matz@6wind.com>]

Hi David,

On 05/17/2016 05:54 PM, David Marchand wrote:
> On Tue, May 17, 2016 at 11:59 AM, Olivier Matz <olivier.matz@6wind.com> wrote:
>> +       /* mmap the pci resource */
>> +       fd = open(filename, O_RDWR);
>> +       if (fd < 0) {
>> +               RTE_LOG(ERR, EAL, "Cannot open %s: %s\n", filename,
>> +                       strerror(errno));
>> +               goto error;
>> +       }
>> +       addr = mmap(NULL, end_addr + 1, PROT_READ | PROT_WRITE,
>> +               MAP_SHARED, fd, 0);
> 
> Sorry, did not catch it in v1, but a close(fd) is missing here.
> With this, I think the patchset looks good.

Good catch, I'm fixing it.

Thanks,
Olivier