From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A77439603 for ; Thu, 19 May 2016 17:21:18 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 19 May 2016 08:21:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,334,1459839600"; d="scan'208";a="705767641" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.220.72]) ([10.237.220.72]) by FMSMGA003.fm.intel.com with ESMTP; 19 May 2016 08:21:16 -0700 To: Stephen Hemminger References: <1462472982-49782-1-git-send-email-david.hunt@intel.com> <1462472982-49782-2-git-send-email-david.hunt@intel.com> <20160505142835.7df35079@xeon-e3> Cc: olivier.matz@6wind.com, dev@dpdk.org From: "Hunt, David" Message-ID: <573DD9EC.1020502@intel.com> Date: Thu, 19 May 2016 16:21:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160505142835.7df35079@xeon-e3> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] mempool: add stack (fifo) mempool handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 15:21:19 -0000 On 5/5/2016 10:28 PM, Stephen Hemminger wrote: > Overall, this is ok, but why can't it be the default? Backward compatibility would probably be the main reason, to have the least impact when recompiling. > Lots of little things should be cleaned up I've submitted a v2, and addressed all your issues. Thanks for the review. Regards, Dave. --snip---