From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.kagstrom@netinsight.net>
Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21])
 by dpdk.org (Postfix) with SMTP id 7F0A79AF2
 for <dev@dpdk.org>; Fri, 20 May 2016 08:30:00 +0200 (CEST)
Received: from [10.100.1.152] (unverified [10.100.1.152]) by
 ernst.netinsight.se
 (EMWAC SMTPRS 0.83) with SMTP id <B0033538087@ernst.netinsight.se>;
 Fri, 20 May 2016 08:30:16 +0200
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
References: <20160516113349.7d2a992f@miho>
 <3AEA2BF9852C6F48A459DA490692831F0102622D@IRSMSX109.ger.corp.intel.com>
 <5739A1D4.6010003@netinsight.net>
 <3AEA2BF9852C6F48A459DA490692831F010262FA@IRSMSX109.ger.corp.intel.com>
 <5739C83F.6010107@netinsight.net>
From: =?UTF-8?Q?Simon_K=c3=a5gstr=c3=b6m?= <simon.kagstrom@netinsight.net>
Message-ID: <573EAEE0.4020802@netinsight.net>
Date: Fri, 20 May 2016 08:29:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <5739C83F.6010107@netinsight.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure
 with zero RX/TX queues
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 May 2016 06:30:00 -0000

Ping? Any more comments on this?

// Simon

On 2016-05-16 15:16, Simon Kågström wrote:
> On 2016-05-16 14:43, Pattan, Reshma wrote:
>>>> This was added to allow devices,  at least with one direction (RX/TX)
>>> supported. As, devices with both directions disabled doesn't make  sense right?
>>>
>>> Well, not for running them, no. But this is a part of the shutdown procedure
>>> between tests (I should have been more clear I guess).
>>
>> Yes I understood this. But I am not sure if you can use rte_eth_dev_configure(port, 0, 0) to free the resources.
>> Can you check if you can use rte_eth_dev_rx_queue_stop/ rte_eth_dev_tx_queue_stop to achieve the same, because they do take care of
>> releasing mbufs, but doesn't free the queue's sw-ring and queue.
> 
> But isn't that very strange behavior. Aren't the descriptor rings
> allocated in rx_queue_setup()? If so, the sequence
> 
>   rx_queue_stop(); // Release buffers
>   rx_queue_start();
> 
> would leave the descriptor ring empty after start, i.e., not able to
> receive data.
> 
> // Simon
>