From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 1AC545AB3
 for <dev@dpdk.org>; Mon, 23 May 2016 11:38:27 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1b4mLf-0005KT-8m; Mon, 23 May 2016 11:40:31 +0200
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
References: <1462897493-6567-1-git-send-email-olivier.matz@6wind.com>
 <1463993205-5623-1-git-send-email-olivier.matz@6wind.com>
 <2601191342CEEE43887BDE71AB97725836B5CA88@irsmsx105.ger.corp.intel.com>
 <5742C991.7090808@6wind.com>
 <2601191342CEEE43887BDE71AB97725836B5CACB@irsmsx105.ger.corp.intel.com>
Cc: "johndale@cisco.com" <johndale@cisco.com>,
 "Zhang, Helin" <helin.zhang@intel.com>,
 "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
 "rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>,
 "alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>,
 "sony.chacko@qlogic.com" <sony.chacko@qlogic.com>
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <5742CF87.4000507@6wind.com>
Date: Mon, 23 May 2016 11:38:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B5CACB@irsmsx105.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mbuf: new flag when Vlan is stripped
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 May 2016 09:38:27 -0000

Hi,

>>> I don't see ixgbe/i4oe_rxtx_vec.c updated.
>>> Would it be another patch for them?
>>
>> The ixgbe vector and i40e vector do not support vlan stripping, 
> 
> As I remember, they do.

You are right, I misinterpreted this code in condition_check():

#ifndef RTE_IXGBE_RX_OLFLAGS_ENABLE
	/* whithout rx ol_flags, no VP flag report */
	if (rxmode->hw_vlan_strip != 0 ||
	    rxmode->hw_vlan_extend != 0)
		return -1;
#endif

I'll update the patch accordingly, thanks for reviewing.

Olivier