From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 9A6112C8 for ; Sat, 10 Sep 2016 09:57:21 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id 1so67337413wmz.1 for ; Sat, 10 Sep 2016 00:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=ISbIAaYUjV08ABeXg0HlYEfv4di2VwMUVrk0fR/Sh48=; b=J2AMKKgRV2F+4jWn0PKeurGA5xrReEnPuxSPOEdhn649SmOrhD7wB/08pZC6LbaY3J p0KiYm7CmKoFN/zpbpU4Ma37E4JoOromx9yzYSJl0yXO1tJ2noz3RiZZCHp1KbQeV/CX ogCvwg0ktfHYlFUCZbPDTXPPfsD3kmLC0T829d3491WpnbetI0Jji6uRagz2eQHirXhi /C9vZy1g/qsHYXzJMP3TSaopIP72mWLgTXFW1GB0RmpTc5lVDSSDhbrWwaaJNGlg2P5K hJArPmrtDbLKq+jdV5COo6KqCzCWZ8Fmw6MdzPJZtvHOHbqe61Spmp8um+asVQft3Xw2 1sVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ISbIAaYUjV08ABeXg0HlYEfv4di2VwMUVrk0fR/Sh48=; b=G7LKHeedlhwpVjdjG17NumWx9w8dUQM8iWDEwDizwV1WL/sNONKVtMfKaFgosdbcdW tWk+lx6/jouMeUjLiwCjwmBzkj1f8qr9ZXrmY0pMN30XjaZ7eDNLuQgtz2+ta62Jfbwj fJz+E7ZBt9tAFo/b26vmZngg5MVjbd/B4739BQL87N4AVeQA8bcZAhdTI2B6ItKqYS93 awAkwEbsVxoMNqdJlEXpY2+PxREEB1KszXkbp5NQ6tLGKTpP1lCmxIa/cU91EC8J/fGC aQoyLl44wGNPqVDEUUvtUBygnJdxOjICWWv0jpaWVJKLMlllxTu38avO2sOjS7IvMzdo zXeQ== X-Gm-Message-State: AE9vXwMW6sjVZ5FQPfWg3bKIctQMOZ+X7AQtjlcrGb9WJDLxcbzVu6G+b6NrXYgejRFkDTnL X-Received: by 10.28.151.72 with SMTP id z69mr1962665wmd.61.1473494241398; Sat, 10 Sep 2016 00:57:21 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id vh6sm7150429wjb.0.2016.09.10.00.57.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Sep 2016 00:57:20 -0700 (PDT) From: Thomas Monjalon To: "Mcnamara, John" Cc: "Yigit, Ferruh" , Stephen Hemminger , zhouyangchao , dev@dpdk.org Date: Sat, 10 Sep 2016 09:57:20 +0200 Message-ID: <5748392.LeAesWsqIn@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1473389167-2758-1-git-send-email-zhouyates@gmail.com> <2019611.627KgLZ47A@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2016 07:57:21 -0000 2016-09-09 14:33, Mcnamara, John: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > 2016-09-08 18:15, Ferruh Yigit: > > > On 9/8/2016 5:44 PM, Stephen Hemminger wrote: > > > > > > ... > > > > > > > But then again the whole KNI driver fails completely when running > > > > kernel style check. > > > > > > > > > > Yes, it generates lots of warnings. > > > I can fix them (excluding ethtool/*), that wouldn't take much time but > > > how syntax only patches welcomed? Another concern is it trashes git > > blame. > > > > You ask a question and give the answer ;) I think it depends just on the > > balance of the pros/cons - to be evaluated. > > Hi, > > I think in general we would prefer to avoid any large scale code beautification since, as pointed out, it breaks the option to git blame. > > However, in the case of the KNI code the main author in git is "Intel" so git blame doesn't tell you a lot. Also, Ferruh is the maintainer, has made most of the recent changes, and is actively maintaining/improving it. So I think if the syntax fix came from him it would be okay. At least it would allow us to apply the checkpatch checks. Yes seems reasonnable