From: Zyta Szpak <zr@semihalf.com>
To: Remy Horton <remy.horton@intel.com>
Cc: thomas.monjalon@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes
Date: Mon, 30 May 2016 11:00:27 +0200 [thread overview]
Message-ID: <574C012B.60302@semihalf.com> (raw)
In-Reply-To: <5745A544.8050505@intel.com>
Hi,
It is the standard DPDK return value -ENOTSUP when the function is not
supported by Ethernet device. I think it is safer to keep it this way
rather than default implicitly to sizeof(uint32_t) and more generic.
Regards,
Zyta
On 25.05.2016 15:14, Remy Horton wrote:
> 'noon,
>
> Was expecting rte_eth_dev_get_reg_width() itself to default to
> sizeof(uint32_t) rather than -ENOTSUP, but that is purely personal
> taste which others might disagree with. You'll also need a
> documentation update & Fixes: line.
>
>
> On 25/05/2016 07:36, zr@semihalf.com wrote:
>> From: Zyta Szpak <zr@semihalf.com>
> [..]
>> Signed-off-by: Zyta Szpak <zr@semihalf.com>
>
> Acked-by: Remy Horton <remy.horton@intel.com>
next prev parent reply other threads:[~2016-05-30 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 10:48 [dpdk-dev] [PATCH] examples/ethtool: include case for 64-bit registers zr
2016-05-20 8:25 ` Remy Horton
2016-05-23 5:11 ` Zyta Szpak
2016-05-25 6:36 ` [dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes zr
2016-05-25 6:36 ` [dpdk-dev] [PATCH 2/2] examples/ethtool: get reg width to allocate memory zr
2016-05-25 13:14 ` Remy Horton
2016-05-25 13:14 ` [dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes Remy Horton
2016-05-30 9:00 ` Zyta Szpak [this message]
2016-05-27 10:28 ` Panu Matilainen
2016-05-27 14:43 ` Thomas Monjalon
2016-05-30 9:32 ` Zyta Szpak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574C012B.60302@semihalf.com \
--to=zr@semihalf.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).