From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id B75C83777 for ; Thu, 2 Jun 2016 09:04:07 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id z87so57011276wmh.0 for ; Thu, 02 Jun 2016 00:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=E8gW5onCMGg7xPKDdwdC6xLUyV8DMs0nIdPa60bq1qY=; b=LZTVKgzCdGrru9a9tc7hhQQcAI/FyCwolmIPxRKeRKdqiC7JBgAKu3KFoeAcir5TEB Wym93xprzA/fbVlwHfqk3Lg5gXqoMvU/WqGbLyiqW8eLVocWgeDU3hdBPdt7O/rdlmd5 +ryLai4qnaEB2leQ0m26DEQEtHVgmgf35YrcrDUs6s48G+7MEceHjeZBCb4nQ6jX7DBK xFtMDiQKpLF/fRYcb8aGVNH67BUgU2o7w63FjrMYK7mO7XC2FPUF9dPKeW+MigEOvfU/ FKsGgUtBfU8JdO/5jM+9ZcPqaB7Rsx6JySnTiN62gud02k2t4blaIL/mtumpCsTr7UyQ WoEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=E8gW5onCMGg7xPKDdwdC6xLUyV8DMs0nIdPa60bq1qY=; b=MBSc/Aj4RyRwmdelsnrEDprjkw/g+hAo/P9N/OolRgUASFVFXn9qEmOO2VrqP0dXTd W8ZJ83l4/A/CY2rcZkQ9iVhtRI9GKtqgxyQnhmEYr9/9IpMWYwWQ+G7/EHjbXL5DX3uT VxqkkOmnnC5/pXX3tt5Td/U1KNpKhk2EbH1aQUXB2duBFzNOXPuZyjp9cNqNvsOhOgF7 qJpzigHEdnnJKI8l/HtoeLz8pVVzW2ZjCyFTIuI3W3KF9rbV/yk4W1p9Wo/hVByhsfoE D2gUN7PeU6tCMfB2bwMdb7/OWowLvSXTfX1HtEzMExGY/hlRy7cyvJkVCunshU9GAyPk SQ5g== X-Gm-Message-State: ALyK8tKbW9SfJsKYAUXSR+vPPgW5u6hSKUHpXIYczQwNLCiqvkEUT5Sr8Wg5qodbOuN96eNF X-Received: by 10.194.228.102 with SMTP id sh6mr7585023wjc.173.1464851047493; Thu, 02 Jun 2016 00:04:07 -0700 (PDT) Received: from [137.194.56.56] (eduroam-0-56.enst.fr. [137.194.56.56]) by smtp.gmail.com with ESMTPSA id y6sm38847053wmy.8.2016.06.02.00.04.06 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Jun 2016 00:04:06 -0700 (PDT) To: Ferruh Yigit , dev@dpdk.org References: <1464787086-29555-1-git-send-email-ferruh.yigit@intel.com> Cc: Anatoly Burakov From: Olivier MATZ Message-ID: <574FDA66.90909@6wind.com> Date: Thu, 2 Jun 2016 09:04:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1464787086-29555-1-git-send-email-ferruh.yigit@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ivshmem: add all memzones of mempool to metada X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2016 07:04:07 -0000 Hi Ferruh, Thank you for fixing this issue. On 06/01/2016 03:18 PM, Ferruh Yigit wrote: > [PATCH] ivshmem: add all memzones of mempool to metada Minor comment: it seems the title is truncated > +static int > +add_mempool_to_metadata(const struct rte_mempool *mp, > + struct ivshmem_config *config) > +{ > + struct rte_mempool_memhdr *memhdr; > + int ret; > + > + ret = add_mempool_memzone_to_metadata(mp, config); > if (ret < 0) > return -1; > > + STAILQ_FOREACH(memhdr, &mp->mem_list, next) { > + ret = add_mempool_memzone_to_metadata(memhdr->addr, config); > + if (ret < 0) > + return -1; > + } > + > + /* mempool consists of memzone and ring */ > return add_ring_to_metadata(mp->ring, config); > } > In case you missed it: there is a function rte_mempool_mem_iter() that can be used to browse the memory chunks of a mempool. It's probably less convenient to use compared to directly browsing the list, but it may be more resistant to api changes. Apart from that: Acked-by: Olivier Matz Thanks