From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26FC043A4E; Fri, 2 Feb 2024 10:18:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC2AD42E32; Fri, 2 Feb 2024 10:18:39 +0100 (CET) Received: from wfout2-smtp.messagingengine.com (wfout2-smtp.messagingengine.com [64.147.123.145]) by mails.dpdk.org (Postfix) with ESMTP id 2F99A4021D; Fri, 2 Feb 2024 10:18:38 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.west.internal (Postfix) with ESMTP id 729EC1C0007D; Fri, 2 Feb 2024 04:18:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 02 Feb 2024 04:18:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1706865512; x=1706951912; bh=pSvE5p0vSb0AdkatAVs8gP+ynIbIJE/G9Vh8s6k9EJI=; b= LMD69b+QHdGN3jGbQ9fWnQ42yYWYadOfY0vpRNsbIUl884oKupWWZ3xn4OPp4Cm4 chJMbv/1yoW1vagbSvZvVKrXVgG1RVAncJAhZqAtTLyzRrMkhf0UC/uf3JXr0lmA Nf5r/CDDzno9PzJg5vCRMCSbc+0eqSA3S6gzj3w5obvCuV2RjK8wYMSqIp54nGuD QQ+/w4vKlwbGC3WyaIZlq38XnM46Qy+mSLAjQtLdiOAwXnmZkh55FQh+AvJyHOEC IqvWfCCHIyfjQJTNYzHNEAvh5kfodie0pGcJYXJXK3sN9otUPpXFiiDU/r6Ugi3y 72RsndK/+tiok7fKza/4NQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1706865512; x= 1706951912; bh=pSvE5p0vSb0AdkatAVs8gP+ynIbIJE/G9Vh8s6k9EJI=; b=j lQZPth9xTmh95uzytBS+RSNj3bJRC03cWFQaJ7ASIgXsDp82dqt0NUvUD6FcYqFB dD8VXdnhjpAAiaVR8uhv0xXrwSIWlc5HbQu2V2f/X+XWQIf0CGItiV+FmBkZhHzc QZM23YqdhMaSlDirKs+E7oDXkuQIVcOiYp2DGzT4+wif8ZcZ/GTMnSDQba9DqkhD DDIaBzpxuLR0+il727KU+Jp43OjB8UBBB9ZqyYpii/o6gIxi3JBFjwRJ/GGBsUsa i4wsRwRdHpLIbhznnPMSmD/Fxaainy1raA2a9TRa8uwbCEjM2bkTTvc+vyEzm445 VYoS4t4MwpzCMeyRtfOwA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedugedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Feb 2024 04:18:29 -0500 (EST) From: Thomas Monjalon To: Ashish Sadanandan Cc: dev@dpdk.org, nelio.laranjeiro@6wind.com, stable@dpdk.org, bruce.richardson@intel.com, honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru, david.marchand@redhat.com, ruifeng.wang@arm.com Subject: Re: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h Date: Fri, 02 Feb 2024 10:18:23 +0100 Message-ID: <5751086.DvuYhMxLoT@thomas> In-Reply-To: <20240202051335.776290-1-ashish.sadanandan@gmail.com> References: <20240202051335.776290-1-ashish.sadanandan@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/02/2024 06:13, Ashish Sadanandan: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Fixes: 86c743cf9140 ("eal: define generic vector types") > Cc: nelio.laranjeiro@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Ashish Sadanandan Thank you for improving C++ compatibility. I'm not sure what is best to fix it. You are adding extern "C" in a file which is not directly included by the user app. The same was done for rte_rwlock.h. The other way is to make sure this include is in an extern "C" block in lib/eal/*/include/rte_vect.h (instead of being before the block). I would like we use the same approach for all files. Opinions?