From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: remove make target for examples
Date: Tue, 22 Nov 2016 11:49:39 +0000 [thread overview]
Message-ID: <5759d5d2-9ece-abbe-587f-b19443046b87@intel.com> (raw)
In-Reply-To: <5520615.NhohP7H5Lc@xps13>
On 11/22/2016 9:38 AM, Thomas Monjalon wrote:
> 2016-11-22 00:34, Ferruh Yigit:
>> On 11/21/2016 11:47 PM, Thomas Monjalon wrote:
>>> The command
>>> make examples
>>> works only if target directories have the exact name of configs.
>>>
>>> It is more flexible to use
>>> make -C examples RTE_SDK=$(pwd) RTE_TARGET=build
>>>
>>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>>
>> Instead of removing examples & examples_clean targets, what do you think
>> keeping them as wrapper to suggested usage, for backward compatibility.
>>
>> Something like:
>> "
>> BUILDING_RTE_SDK :=
>> export BUILDING_RTE_SDK
>>
>> # Build directory is given with O=
>> O ?= $(RTE_SDK)/examples
>>
>> # Target for which examples should be built.
>> T ?= build
>>
>> .PHONY: examples
>> examples:
>> @echo ================== Build examples for $(T)
>> $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T);
>>
>> .PHONY: examples_clean
>> examples_clean:
>> @echo ================== Clean examples for $(T)
>> $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T) clean;
>> "
>
> What is the benefit of this makefile? Just remove -C ?
To keep existing targets, in case somebody use them.
> It is not compatible with the old behaviour, so I'm afraid it would be
> confusing for no real benefit.
Right, not fully compatible, but still can do:
make examples / make examples_clean
make examples T=x86_64-native-linuxapp-gcc
Overall, if you believe keeping them is confusing, I am OK with it, just
may need to update doc/build-sdk-quick.txt to fix "make help" output.
Thanks,
ferruh
next prev parent reply other threads:[~2016-11-22 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 23:47 Thomas Monjalon
2016-11-22 0:34 ` Ferruh Yigit
2016-11-22 9:38 ` Thomas Monjalon
2016-11-22 11:49 ` Ferruh Yigit [this message]
2019-01-11 22:01 ` Ferruh Yigit
2019-01-11 22:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5759d5d2-9ece-abbe-587f-b19443046b87@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).