From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 85D352946
 for <dev@dpdk.org>; Mon, 13 Jun 2016 14:49:52 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1bCRLb-0007uu-EE; Mon, 13 Jun 2016 14:52:09 +0200
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
References: <57344C06.1030007@6wind.com>
 <1463990171-10295-1-git-send-email-olivier.matz@6wind.com>
 <2601191342CEEE43887BDE71AB97725836B6FDB0@irsmsx105.ger.corp.intel.com>
Cc: "johndale@cisco.com" <johndale@cisco.com>,
 "Zhang, Helin" <helin.zhang@intel.com>, "arnon@qwilt.com" <arnon@qwilt.com>,
 "rolette@infinite.io" <rolette@infinite.io>,
 "Chen, Jing D" <jing.d.chen@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <575EABE5.6010807@6wind.com>
Date: Mon, 13 Jun 2016 14:49:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B6FDB0@irsmsx105.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mbuf: remove unused Rx error flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2016 12:49:52 -0000

Hi Konstantin,

On 06/13/2016 02:42 PM, Ananyev, Konstantin wrote:
> 
> Hi Olivier,
> 
>>> -----Original Message-----
>>> From: Olivier Matz [mailto:olivier.matz@6wind.com]
>>> Sent: Monday, May 23, 2016 8:56 AM
>>> To: dev@dpdk.org
>>> Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon@qwilt.com; rolette@infinite.io; Chen, Jing D; Wu, Jingjing
>>> Subject: [PATCH] mbuf: remove unused Rx error flags
>>>
>>> Following the discussions from:
>>> http://dpdk.org/ml/archives/dev/2015-July/021721.html
>>> http://dpdk.org/ml/archives/dev/2016-April/038143.html
>>>
>>> The value of these flags is 0, making them useless. Today, no example
>>> application checks them on Rx, and only few drivers sets them and
>>> silently give wrong packets to the application, which should not happen.
>>>
>>> This patch removes the unused flags from rte_mbuf and their use in the
>>> drivers. The i40e and fm10k are kept as they are today and should be
>>> fixed to drop bad packets. The enic driver is managed by its maintainer
>>> in another patch.
>>>
>>> Fixes: c22265f6 ("mbuf: add new packet flags for i40e")
>>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>>> ---
>>
>> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> 
> Just a note, I think you'll need to rebase your patch with latest code.
> enic PMD fails to compile.

Indeed, this patch should be applied after John's enic series. Latest
one is there:
http://dpdk.org/ml/archives/dev/2016-June/040183.html

Please Bruce/Thomas, check this dependency before applying.

> Please feel free to keep my ack on it.

Thank you for reviewing.

Regards,
Olivier