From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] Duplicate config symbols
Date: Mon, 13 Jun 2016 14:07:18 +0100 [thread overview]
Message-ID: <575EB006.60900@intel.com> (raw)
In-Reply-To: <CAATJJ0JdFrvgEhOWhPc4T-bTY49a+Ln_ZtJJy4w_Ja=aVBzjmA@mail.gmail.com>
On 6/13/2016 12:50 PM, Christian Ehrhardt wrote:
> Hi,
> I wondered multiple times now when changing a config symbol that some of
> them are in the .config file multiple times.
> I totally feel like I'm overlooking something, but still it might be worth
> to ask.
>
> In particular:
> awk -F "=" '/=/ {print $1}' debian/build/static-root/.config | sort | uniq
> -c | sort -n | grep -v 1
> 2 CONFIG_RTE_ARCH
> 2 CONFIG_RTE_EAL_IGB_UIO
> 2 CONFIG_RTE_EAL_VFIO
> 2 CONFIG_RTE_EXEC_ENV
> 2 CONFIG_RTE_KNI_KMOD
> 2 CONFIG_RTE_LIBRTE_KNI
> 2 CONFIG_RTE_LIBRTE_PMD_AF_PACKET
> 2 CONFIG_RTE_LIBRTE_PMD_VHOST
> 2 CONFIG_RTE_LIBRTE_POWER
> 2 CONFIG_RTE_LIBRTE_VHOST
> 2 CONFIG_RTE_MACHINE
> 2 CONFIG_RTE_TOOLCHAIN
>
> Is there any reason to do so or is this an issue in make config?
>
> Christian Ehrhardt
> Software Engineer, Ubuntu Server
> Canonical Ltd
>
This happened with commit:
43f4364 config: remove duplicate information
I commented something similar, and send a patch to fix this:
http://dpdk.org/ml/archives/dev/2016-March/034718.html
With current implementation, the last occurrence of config item overwrites.
Regards,
ferruh
next prev parent reply other threads:[~2016-06-13 13:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 11:50 Christian Ehrhardt
2016-06-13 13:07 ` Ferruh Yigit [this message]
2016-06-13 13:47 ` Thomas Monjalon
2016-06-13 15:09 ` Christian Ehrhardt
2016-06-13 15:10 ` [dpdk-dev] [RFC] mk: filter duplicate configuration entries Christian Ehrhardt
2016-06-28 16:11 ` Ferruh Yigit
2016-06-28 16:38 ` Christian Ehrhardt
2016-06-28 16:48 ` Ferruh Yigit
2016-06-30 11:57 ` Christian Ehrhardt
2016-06-30 12:00 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2016-07-05 16:47 ` Ferruh Yigit
2016-07-05 19:47 ` Thomas Monjalon
2016-07-06 5:37 ` Christian Ehrhardt
2016-07-06 5:37 ` [dpdk-dev] [PATCH v3] " Christian Ehrhardt
2016-07-06 8:06 ` Ferruh Yigit
2016-07-06 8:12 ` Bruce Richardson
2016-07-06 8:57 ` Ferruh Yigit
2016-07-06 9:08 ` Christian Ehrhardt
2016-07-06 9:13 ` [dpdk-dev] [PATCH v4] " Christian Ehrhardt
2016-07-11 12:47 ` Thomas Monjalon
2016-07-06 9:30 ` [dpdk-dev] [PATCH v3] " Bruce Richardson
2016-06-13 16:55 ` [dpdk-dev] Duplicate config symbols Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575EB006.60900@intel.com \
--to=ferruh.yigit@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).