From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 756C26C9F for ; Tue, 14 Jun 2016 11:34:32 +0200 (CEST) Received: from [10.16.0.195] (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id 2AFDD25EDE; Tue, 14 Jun 2016 11:34:32 +0200 (CEST) To: "Ananyev, Konstantin" , "dev@dpdk.org" References: <1463993205-5623-1-git-send-email-olivier.matz@6wind.com> <1464359593-3534-1-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725836B70190@irsmsx105.ger.corp.intel.com> <575EDA24.3020405@6wind.com> <2601191342CEEE43887BDE71AB97725836B703CC@irsmsx105.ger.corp.intel.com> <575FC133.3090205@6wind.com> <2601191342CEEE43887BDE71AB97725836B707E8@irsmsx105.ger.corp.intel.com> Cc: "johndale@cisco.com" , "Zhang, Helin" , "adrien.mazarguil@6wind.com" , "rahul.lakkireddy@chelsio.com" , "alejandro.lucero@netronome.com" , "sony.chacko@qlogic.com" From: Olivier MATZ Message-ID: <575FCFA8.7030704@6wind.com> Date: Tue, 14 Jun 2016 11:34:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB97725836B707E8@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] mbuf: new flag when Vlan is stripped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 09:34:32 -0000 On 06/14/2016 11:15 AM, Ananyev, Konstantin wrote: >>>> If we decide to generalize the ixgbe behavior for all PMDs for this >>>> flag, it will break the applications relying on this flag but with >>>> other PMDs. So for the same reason we added a new PKT_RX_VLAN_STRIPPED >>>> we cannot change the behavior of an existing flag. >>> >>> Ok, then let's make PKT_RX_VLAN_STRIPPED == PKT_RX_VLAN, >>> and assign new value to the PKT_RX_VLAN. >>> Or have PKT_RX_VLAN_STRIPPED == PKT_RX_VLAN and create a new one: >>> PKT_RX_VLAN_PRESENT or so. >>> ? >>> >> >> I think adding this new flag/packet_type is a new feature, >> because only ixgbe was behaving like this, and this was not >> documented. To me, marking the old flag as deprecated is >> a good compromise to keep the application relying on this >> working. If you feel the term "deprecated" is not adapted, >> we could reword it to something weaker. > > Yes, that would do I think. > Basically my only concern that we will mark it as deprecated, > and then will remove it (as it is deprecated), without providing > anything new to replace it. > >> >> We should try to not stay in that state too long, > > Agree. > >> and anybody willing to implement this feature would be welcome. For my >> part, this is not something I plan to do yet. >> > > Ok, we'll see what we can do for 16.11. > But no hard promises right now either :) Great, thanks :) I'll send an update of the patch taking your comments in account. Olivier