From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] mlx: fix icc compilation error
Date: Tue, 14 Jun 2016 17:02:36 +0100 [thread overview]
Message-ID: <57602A9C.2040002@intel.com> (raw)
In-Reply-To: <2912717.PxuBxaxfu4@xps13>
On 6/14/2016 4:39 PM, Thomas Monjalon wrote:
> 2016-06-14 16:22, Ferruh Yigit:
>> Compilation errors:
>> mlx4:
>> CC mlx4.o
>> .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type
>> mixed with another type
>> priv->intr_handle.type = 0;
>> ^
>>
>> mlx5:
>> CC em_rxtx.o
>> .../dpdk/drivers/net/mlx5/mlx5_rxq.c(282):
>> error #188: enumerated type mixed with another type
>> enum hash_rxq_type type = 0;
>> ^
>>
>> .../dpdk/drivers/net/mlx5/mlx5_rxq.c(622):
>> error #188: enumerated type mixed with another type
>> if (!priv_allow_flow_type(priv, i)) {
>> ^
>> more same type of error
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Please add a Fixes line.
> We need to think about the stable branch maintainer's task ;)
>
I wasn't sure to add Fixes line for this patch, because it is not so
useful reference since patch doesn't really fixes the code, just
compilation error and touches a few different location that is scope of
different commits:
Fixes: c4da6caa426d ("mlx4: handle link status interrupts")
Fixes: 198a3c339a8f ("mlx5: handle link status interrupts")
Fixes: 0d2186743d62 ("mlx5: manage all special flow types at once")
Fixes: 612ad38209f7 ("mlx5: fix hash Rx queue type in RSS mode")
Fixes: 083c2dd31776 ("mlx5: refactor special flows handling")
next prev parent reply other threads:[~2016-06-14 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 9:51 [dpdk-dev] [PATCH] " Ferruh Yigit
2016-06-14 10:03 ` Bruce Richardson
2016-06-14 15:22 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-06-14 15:31 ` Adrien Mazarguil
2016-06-14 15:39 ` Thomas Monjalon
2016-06-14 16:02 ` Ferruh Yigit [this message]
2016-06-14 16:18 ` Thomas Monjalon
2016-06-14 16:17 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2016-06-16 7:58 ` Adrien Mazarguil
2016-06-28 10:08 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57602A9C.2040002@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).