From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 6D1859A97
 for <dev@dpdk.org>; Tue, 14 Jun 2016 18:03:15 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga103.jf.intel.com with ESMTP; 14 Jun 2016 09:02:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,471,1459839600"; d="scan'208";a="987295568"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.41])
 ([10.237.220.41])
 by fmsmga001.fm.intel.com with ESMTP; 14 Jun 2016 09:02:37 -0700
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <20160614100352.GA14888@bricha3-MOBL3>
 <1465917730-10713-1-git-send-email-ferruh.yigit@intel.com>
 <2912717.PxuBxaxfu4@xps13>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <57602A9C.2040002@intel.com>
Date: Tue, 14 Jun 2016 17:02:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <2912717.PxuBxaxfu4@xps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] mlx: fix icc compilation error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jun 2016 16:03:15 -0000

On 6/14/2016 4:39 PM, Thomas Monjalon wrote:
> 2016-06-14 16:22, Ferruh Yigit:
>> Compilation errors:
>> mlx4:
>>   CC mlx4.o
>>   .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type
>>   mixed with another type
>>           priv->intr_handle.type = 0;
>>                                  ^
>>
>> mlx5:
>>   CC em_rxtx.o
>> .../dpdk/drivers/net/mlx5/mlx5_rxq.c(282):
>> error #188: enumerated type mixed with another type
>>         enum hash_rxq_type type = 0;
>>                                   ^
>>
>> .../dpdk/drivers/net/mlx5/mlx5_rxq.c(622):
>> error #188: enumerated type mixed with another type
>>                 if (!priv_allow_flow_type(priv, i)) {
>>                                                 ^
>> more same type of error
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Please add a Fixes line.
> We need to think about the stable branch maintainer's task ;)
> 
I wasn't sure to add Fixes line for this patch, because it is not so
useful reference since patch doesn't really fixes the code, just
compilation error and touches a few different location that is scope of
different commits:

Fixes: c4da6caa426d ("mlx4: handle link status interrupts")
Fixes: 198a3c339a8f ("mlx5: handle link status interrupts")
Fixes: 0d2186743d62 ("mlx5: manage all special flow types at once")
Fixes: 612ad38209f7 ("mlx5: fix hash Rx queue type in RSS mode")
Fixes: 083c2dd31776 ("mlx5: refactor special flows handling")