From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id C677D5930 for ; Thu, 24 Jul 2014 10:18:28 +0200 (CEST) Received: by mail-wi0-f180.google.com with SMTP id n3so3532391wiv.13 for ; Thu, 24 Jul 2014 01:19:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=e1FPLfabNoBW3aU56+8n5NMacOKaE0LUAd3Wav22ip8=; b=CnarluNGqbDoJZmpeh3FNDS6orPvzBnX4CO1I0sHfBy6B6f+0gPdx+LPyCGgOEc7D7 smEt5UBWadXwktj99Hf3JVtlcK2yUkKf6EpKP6Wh+8d8IP7n7RyhPj/lHZdInTo0AlDg tCcDvJutWJwD7fmoieYMd/kzXRq0tQqBC8tZCkcqbdZtBUOzYH4Wqd2JER4BEgfSvUby cQVibu6WVKaM/8kxS+roZfeOB3/PnL8qUmaK16P39Irl4lJqu3a7WcMThMbJRrdNMEfX IxK4oBfCCVA4OWk3dBAOVQFn+zJvJktxCD8cI0u+lTf8ywd7KrJXc7jaLrcZMjrg8HRC 6c5A== X-Gm-Message-State: ALoCoQlBsiiDS8tsuk2rYBZ2YzIXruyr3MBhn36vLby8MBxerLrIzLUwTSitx2FbQ7UU627/Ba5u X-Received: by 10.180.80.70 with SMTP id p6mr32902508wix.22.1406189995376; Thu, 24 Jul 2014 01:19:55 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ey16sm20054568wid.14.2014.07.24.01.19.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jul 2014 01:19:54 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Thu, 24 Jul 2014 10:19:45 +0200 Message-ID: <5763244.xFk97hyylc@xps13> Organization: 6WIND User-Agent: KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; ) In-Reply-To: References: <1406184149-11531-1-git-send-email-helin.zhang@intel.com> <2490690.EmSZ5vBN3i@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: Rename macros of packet classification type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2014 08:18:28 -0000 2014-07-24 08:14, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-07-24 14:42, Helin Zhang: > > > For better understanding, 'PCTYPE' was added to the name of i40e RSS > > > shift macros. > > > > > > Signed-off-by: Helin Zhang > > > > > -#define ETH_RSS_NONF_IPV4_UDP_SHIFT 31 > > > +#define ETH_PCTYPE_NONF_IPV4_UDP 31 > > > > Why is it clearer? I don't understand what means PCTYPE. > > It is 'packet classification type' defined in data sheet, and widely used. Widely used? No it seems to be an i40e naming. Which datasheet are you pointing? > It is not just for RSS only, it can be used for flow director possibly. > That's why I think it would be better to rename it with PCTYPE names. At least, you should add a comment in the code to explain the meaning. Thank you -- Thomas