From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id EB33BCC3E for ; Fri, 17 Jun 2016 11:24:55 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 17 Jun 2016 02:24:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,482,1459839600"; d="scan'208";a="123675293" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by fmsmga004.fm.intel.com with ESMTP; 17 Jun 2016 02:24:50 -0700 To: Thomas Monjalon References: <1465976824-83823-1-git-send-email-david.hunt@intel.com> <5763B018.5090602@6wind.com> <5763B7FC.80608@intel.com> <2502441.EqJFgDIT6e@xps13> Cc: dev@dpdk.org, Olivier Matz , viktorin@rehivetech.com, jerin.jacob@caviumnetworks.com, shreyansh.jain@nxp.com From: "Hunt, David" Message-ID: <5763C1E1.4050708@intel.com> Date: Fri, 17 Jun 2016 10:24:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <2502441.EqJFgDIT6e@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 09:24:56 -0000 On 17/6/2016 10:09 AM, Thomas Monjalon wrote: > 2016-06-17 09:42, Hunt, David: >> On 17/6/2016 9:08 AM, Olivier Matz wrote: >>> Hi David, >>> >>> On 06/17/2016 08:58 AM, Hunt, David wrote: >>>> A comment below: >>>> >>>> On 16/6/2016 1:30 PM, David Hunt wrote: >>>>> +/** >>>>> + * Set the ops of a mempool. >>>>> + * >>>>> + * This can only be done on a mempool that is not populated, i.e. >>>>> just after >>>>> + * a call to rte_mempool_create_empty(). >>>>> + * >>>>> + * @param mp >>>>> + * Pointer to the memory pool. >>>>> + * @param name >>>>> + * Name of the ops structure to use for this mempool. >>>> + * @param pool_config >>>> + * Opaque data that can be used by the ops functions. >>>>> + * @return >>>>> + * - 0: Success; the mempool is now using the requested ops functions. >>>>> + * - -EINVAL - Invalid ops struct name provided. >>>>> + * - -EEXIST - mempool already has an ops struct assigned. >>>>> + */ >>>>> +int >>>>> +rte_mempool_set_ops_byname(struct rte_mempool *mp, const char *name, >>>>> + void *pool_config); >>>>> + >>> The changes related to the pool_config look good to me. >>> >>> If you plan to do a v14 for this API comment, I'm wondering if the >>> documentation could be slightly modified too. I think "external mempool >>> manager" was the legacy name for the feature, but maybe it could be >>> changed in "alternative mempool handlers" or "changing the mempool >>> handler". I mean the word "external" is probably not appropriate now, >>> especially if we add other handlers in the mempool lib. >>> >>> My 2 cents, >>> Olivier >> I had not planned on doing another revision. And I think the term "External >> Mempool Manager" accurately describes the functionality, so I'd really >> prefer to leave it as it is. > I think there is no manager, just a default handler which can be changed. > I agree the documentation must be fixed. OK, I have two suggestions to add into the mix. 1. mempool handler framework or simply 2. mempool handlers. (the alternative is implied). "The mempool handler feature", etc. Thoughts? David.