Re: [dpdk-dev] [PATCH] ena: Update PMD to cooperate with latest ENA firmware

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 6/16/2016 6:54 PM, Jan Medala wrote:
> This patch includes:
> * Update of ENA communication layer
> 
> * Fixed memory management issue
> 	After allocating memzone it's required to zeroize it
> 	as well as freeing memzone with dedicated function.
> 
> * Added debug area and host information
> 
> * Disabling readless communication regarding to HW revision
> 
> * Allocating coherent memory in node-aware way
> 
> Signed-off-by: Alexander Matushevsky <matua@amazon.com>
> Signed-off-by: Jakub Palider <jpa@semihalf.com>
> Signed-off-by: Jan Medala <jan@semihalf.com>
> ---

Hi Jan,

This is a big patch and hard to review, is it possible to split patch
into more logical pieces? List in the commit log is potential for
splinting into.

Also there are small checkpatch [1] and check-git-log [2] warnings.


[1]
### [dpdk-dev] ena: Update PMD to cooperate with latest ENA firmware

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional
statements (16, 16)
#568: FILE: drivers/net/ena/base/ena_com.c:2549:
                if (unlikely(!host_attr->debug_area_virt_addr)) {
+               host_attr->debug_area_size = 0;

WARNING:LONG_LINE: line over 80 characters
#1026: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1806:
+               (val <<
ENA_ADMIN_FEATURE_RSS_FLOW_HASH_INPUT_ENABLE_L3_SORT_SHIFT)

WARNING:LONG_LINE: line over 80 characters
#2229: FILE: drivers/net/ena/ena_ethdev.c:357:
 +               (DRV_MODULE_VER_SUBMINOR <<
ENA_ADMIN_HOST_INFO_SUB_MINOR_SHIFT);

 total: 0 errors, 3 warnings, 0 checks, 2291 lines checked

0/1 valid patch


[2]
Wrong headline uppercase:
        ena: Update PMD to cooperate with latest ENA firmware

Thanks,
ferruh