From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 838156904 for ; Wed, 10 Apr 2019 13:50:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 1494E14311; Wed, 10 Apr 2019 07:50:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 10 Apr 2019 07:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Rkaor7FSpWzm+EMLeiQ69nUQ5EX63eEM8JIr5gICoA4=; b=VR+nS2uyqQZ9 MdThrz5b0AedSh22gw0xxsYJsSPNvNWI77cljqGzYDigrVu1lAgBH13uI1/PrfI0 PONAG3DGsXiRkuUiKoHj8WdkyyYOcKr6jppUPZBymxh4+xjM/3761aJD1twnosXE EWezC9FnMFFcNowtarBJ6xLDNUOX+YE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Rkaor7FSpWzm+EMLeiQ69nUQ5EX63eEM8JIr5gICo A4=; b=LVk2cyu656gFS5/0FpZVaiffoWTpP8cFQEz5yF66wBtKe0op0mDA8ZVkH QSy0I9P4LhCT3/Dq/7iFuWgt6Mjf2macMxNoq17kwsYgxnAMlFKthpxdddy0+EA3 MU/0i83hlsU6OYt8PjukIzJ8l3Q6mCaxG6HvOZ+t30mJg9/V59kwpcOQOY9lkaJZ OV/YRUqC07VFuetR0JV8vq/OKqnFT2IpIrvfYhQHMmBM426lqtEhAyQz1d1JKG0h HBQZYoreNessvAK2IWnA1wacbD0HINy+cqgKWq6J41ClpC+9CgDRBcEi8ahhWM6r ZBzem+crJLTeF1HgJXz+lh6sGMruA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudejgdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E3C6E40FF; Wed, 10 Apr 2019 07:50:17 -0400 (EDT) From: Thomas Monjalon To: Igor Russkikh Cc: "dev@dpdk.org" , Pavel Belous , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Konstantin Ananyev , Ferruh Yigit , Andrew Rybchenko Date: Wed, 10 Apr 2019 13:50:15 +0200 Message-ID: <5768922.YkK6cjzkmx@xps> In-Reply-To: <123a93a371be657e3e8481379db6f151350d4f90.1554894242.git.igor.russkikh@aquantia.com> References: <123a93a371be657e3e8481379db6f151350d4f90.1554894242.git.igor.russkikh@aquantia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 02/10] app/testpmd: use generic MACSEC API calls X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 11:50:19 -0000 10/04/2019 13:18, Igor Russkikh: > Here we do repace testpmd direct usage of IXGBE driver calls > with generic ethdev macsec API calls The generic API is implemented in ixgbe in next patch. You should reverse them, or completely move this patch at the end. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 73504A0096 for ; Wed, 10 Apr 2019 13:50:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD27B695D; Wed, 10 Apr 2019 13:50:20 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 838156904 for ; Wed, 10 Apr 2019 13:50:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 1494E14311; Wed, 10 Apr 2019 07:50:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 10 Apr 2019 07:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Rkaor7FSpWzm+EMLeiQ69nUQ5EX63eEM8JIr5gICoA4=; b=VR+nS2uyqQZ9 MdThrz5b0AedSh22gw0xxsYJsSPNvNWI77cljqGzYDigrVu1lAgBH13uI1/PrfI0 PONAG3DGsXiRkuUiKoHj8WdkyyYOcKr6jppUPZBymxh4+xjM/3761aJD1twnosXE EWezC9FnMFFcNowtarBJ6xLDNUOX+YE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Rkaor7FSpWzm+EMLeiQ69nUQ5EX63eEM8JIr5gICo A4=; b=LVk2cyu656gFS5/0FpZVaiffoWTpP8cFQEz5yF66wBtKe0op0mDA8ZVkH QSy0I9P4LhCT3/Dq/7iFuWgt6Mjf2macMxNoq17kwsYgxnAMlFKthpxdddy0+EA3 MU/0i83hlsU6OYt8PjukIzJ8l3Q6mCaxG6HvOZ+t30mJg9/V59kwpcOQOY9lkaJZ OV/YRUqC07VFuetR0JV8vq/OKqnFT2IpIrvfYhQHMmBM426lqtEhAyQz1d1JKG0h HBQZYoreNessvAK2IWnA1wacbD0HINy+cqgKWq6J41ClpC+9CgDRBcEi8ahhWM6r ZBzem+crJLTeF1HgJXz+lh6sGMruA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudejgdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E3C6E40FF; Wed, 10 Apr 2019 07:50:17 -0400 (EDT) From: Thomas Monjalon To: Igor Russkikh Cc: "dev@dpdk.org" , Pavel Belous , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Konstantin Ananyev , Ferruh Yigit , Andrew Rybchenko Date: Wed, 10 Apr 2019 13:50:15 +0200 Message-ID: <5768922.YkK6cjzkmx@xps> In-Reply-To: <123a93a371be657e3e8481379db6f151350d4f90.1554894242.git.igor.russkikh@aquantia.com> References: <123a93a371be657e3e8481379db6f151350d4f90.1554894242.git.igor.russkikh@aquantia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 02/10] app/testpmd: use generic MACSEC API calls X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410115015.cBTfQD5Q25G1V2srcrN-LSSLj9-jLejtIVa_y-qsW40@z> 10/04/2019 13:18, Igor Russkikh: > Here we do repace testpmd direct usage of IXGBE driver calls > with generic ethdev macsec API calls The generic API is implemented in ixgbe in next patch. You should reverse them, or completely move this patch at the end.