From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0065.outbound.protection.outlook.com [207.46.100.65]) by dpdk.org (Postfix) with ESMTP id 773ECC3F6 for ; Wed, 22 Jun 2016 15:43:35 +0200 (CEST) Received: from DM2PR03CA0050.namprd03.prod.outlook.com (10.141.96.49) by SN2PR03MB2384.namprd03.prod.outlook.com (10.166.210.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12; Wed, 22 Jun 2016 13:43:33 +0000 Received: from BN1AFFO11FD037.protection.gbl (2a01:111:f400:7c10::134) by DM2PR03CA0050.outlook.office365.com (2a01:111:e400:2428::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12 via Frontend Transport; Wed, 22 Jun 2016 13:43:34 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; tuxdriver.com; dkim=none (message not signed) header.d=none;tuxdriver.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD037.mail.protection.outlook.com (10.58.52.241) with Microsoft SMTP Server (TLS) id 15.1.517.7 via Frontend Transport; Wed, 22 Jun 2016 13:43:32 +0000 Received: from [10.232.14.199] (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5MDhTTg020855; Wed, 22 Jun 2016 06:43:30 -0700 To: Neil Horman References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1466586396-22618-1-git-send-email-shreyansh.jain@nxp.com> <1466586396-22618-11-git-send-email-shreyansh.jain@nxp.com> <20160622132814.GB6785@hmsreliant.think-freely.org> CC: , , From: Shreyansh jain Message-ID: <576A9628.1090305@nxp.com> Date: Wed, 22 Jun 2016 19:14:08 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160622132814.GB6785@hmsreliant.think-freely.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131110766131618810; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(24454002)(199003)(377454003)(586003)(77096005)(230700001)(65806001)(93886004)(4326007)(33656002)(65816999)(7846002)(81156014)(104016004)(8676002)(6806005)(81166006)(2950100001)(76176999)(50986999)(23746002)(2906002)(8936002)(87266999)(356003)(54356999)(68736007)(19580405001)(64126003)(50466002)(86362001)(47776003)(19580395003)(59896002)(87936001)(83506001)(36756003)(92566002)(97736004)(4001350100001)(106466001)(189998001)(69596002)(105606002)(65956001)(110136002)(85426001)(80316001)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2384; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD037; 1:tK2eG7nGVKUmbGks34wlC8pty46qcKVblZZaKFVG/2KyoIoeX+/+eylCxYxP3mXwx4xJV8kgmTbEtugwg9wsJ81xBdihX3+RgZ/wgiSHFgAi2pM4oZXTbEjeeQhNj0tXj4P9uSBnXODV/DrqhfJIQUTXzbJH+LM8SBNXXMTWqbgmaXgnlsyKeDCf1Gr7R6EMJrIDrWugfGnhQC/xx++jox9nW4n5Zs13nDEersHzHsUKnYemcjgZ838w43NLFdsEux/raTkQfXkz7r/7wa0Gr0GLr7MtzLMY5CZYrRebFCxw3vbp2rr8L5xnBPAr7jmBAKQqcTuYH7ZF4isoqkp+3zIrY/gYwS/g095y4LgYKy/42cAuuS0FBruM2D5Iuf1Js7pu/7hr36g+Yy+gSr1T/v4OnnvtZacu4kqp4r6wxTG7xwJy932Y3YP0NK8AEdjYUY/MQJZt2I566lV8f/xgciTlxFY9kwNlzh3qtzINGI2R7dZiGBIQQeJy17IMwMWqqJ2l+hM1VHEIvuGS4LKnlDwOCbGvMBt3n4T/7T4BXXNRn+DqgU4Q/gAG2aikS5/H X-MS-Office365-Filtering-Correlation-Id: ff92ea53-3594-41af-c298-08d39aa333f5 X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2384; 2:Ndb8GDmEIhSHMbQLn2WdXPHZivzhtpUS601kmZzOMzOAGrmqYrXscdAna+pWIl4/7VRvLPzkBPfVEE2HTqq2wJNke7B6YTfFP6VS0rCsENHq3ZSTio5MvfxVlDX5fGJWOMaxytgz9C1IKclgzswSh5uur7Zlgu/dhkrQJCpnPYSN9RIu00MFXtSXXvwIMDJj; 3:xuDhMnwz/uXowexl+2QmgdcMHmwyynJX51FLS0eN4qWfW1FRJst8icIYFJkmSjtJAEkpXIRIjYIr92WavQVqxHEWNF73G8a3B+sx+x37z723GRsUx2N1/XO2uIpIpXE8gRXArbdVwTYv/eFczhhSMC9wKFtu/6AfKVoJ2/2QgWlH5V4PTppJgK01EAhan3YP/t9S+2Hwzc9L/Wy89V5LdmjsQcrvI6G3iA5GAmq4Gmc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR03MB2384; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2384; 25:Xi7MQVb09TpNQaL6PQrftp4aH6KlRbZUUhHiwLaBFsWsHG5s0C5FlcA7F8UBemqJSd4huJbvm1+Qhj+e6R+mKUheCt4m9m1bQHKyPH7a/dI84N+RA0YvAzW9q37HpbPZ19VQQdnCB+xrBfUZ9vGLYD1IzAKrjcK5MXOkSAKDSeNAdl64BKuRE4SFhkHXNQ3ZvD03Ves+PIgC3mBw+nFRiX1z/ZG4J0T6ShFtCVW0Cufmr6gYldXj7LivIuxE23G9sDbVwPTMr0H0Du6qlFbhJTb6Ly1aspZsZ7oHbU1uUAJjXRq+QpHDlp4Kv1TH9F3XMe70Qjxp7TITFoeNRwh6/Luo4x8VExDEsnf6d8QbKRjpxvCgl0ZJ6aokWN8I0YSg50dvt1RtxC/K6gVUeSrsKMp8qphylbEsmyuwH3OY+QwA/eQkWp8qQmVtu285M+7ROWQ2wnc5U9nfApvy4WCEqerH81Ra13Bp73duM8eeggOWPfVFuF4vG7Nh15CyqxB/rJOlNJTokDf7QpOPvcoD9fyTa05z36M+GHoaz+94+3wfOydhAv/bef5lYbZRpXiueRwmE0rTTFdM966njfdOy9J09sKvUHeQsrypOGO10m7b+ZxZTMnrEr8DJkSBMKu4rADSg2bFBkFGql+1cITTxFpjbOjVd8FFQbgoqPHZo2X83NM57haAiq9NHu+6bZXDqr3GGYY9WK9KkwYfJCkMKoERo8cQd716ptHgSWI88TA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13017025)(13023025)(5005006)(13015025)(13024025)(13018025)(8121501046)(3002001)(10201501046)(6055026); SRVR:SN2PR03MB2384; BCL:0; PCL:0; RULEID:(400006); SRVR:SN2PR03MB2384; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2384; 4:aLrothQ1i4/HJyuapzT2C0PbZfpnV8XAM043XAqvNGhxCaSSofPfDNdMAmq1YJT12oTbebD+JzBmBG2rPlN2X2//ztHmTBz9gXF7ZFjaVwdGiCImMOfjqXR66XQJvL74cbax9zLVm/Q9syfJ9BCEX4YKr0FQiNdxyot+Qmi8Cp3tLL1nB20oxUnux+US5L9/CHCJDJvCh3e3cBMpyzGS3jqWr4iLKAxgZtONsZpdimlvIYe9BaFgjJPJVj8On7JDAK9tlISAXhbyCx9cy6Re8XdlK7j3Xx9POUtEne+wpexP59imEtJHugpnEFkE9kOjtZKzvPj80mrvpVLQWmkuXMl1185kuzuV3dR8ws380XWZJxQVutOvs/hGdNzWpnSNgXhu1D1GdIenbIZ+eEZRnplXTveP430k/P+sT9/FXefMnOZcVSSlpADUBxfak/66WjF9QRtmOvR6Sskauo8R9aBxMma7jIIDyxVskzC0+Q25Gp57cdStzHAbWT8JkCJkcyy0HEFRgsIKa0VbLqWPNQ== X-Forefront-PRVS: 0981815F2F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; SN2PR03MB2384; 23:47VgMWQiefpEWh/CriChwNY0yJ7L7K7C0rtv+?= =?Windows-1252?Q?sKZqb1Fovq7vAzZ0FRobCNMPusxrvU1M7XOyUMpJMuDVCRbFeD81OCc+?= =?Windows-1252?Q?Ab2cz68Mgu3go4HrW8H6CM5Pg9fhLM/nfRuTe2Hwb6S8rTPPI9MD7Qjv?= =?Windows-1252?Q?e7bLzctrlQsy7yBcr+joiDesDj8mIXOBysFEQNt2cpeQB70vsd9WJaG3?= =?Windows-1252?Q?LqxsqT0c9Q+8bUw5UN6LPmp9kGqLjQoRMUuxFfbHYPFqgH91owUADo23?= =?Windows-1252?Q?Pnk613WZ/cwWwEp8e4AK8+ulAUpZZbI5gqg7ZIohwIpPkut1YQHvRGDS?= =?Windows-1252?Q?Yp6nEqu4/r9scH3bCkgo5lI4hGtgRBIzcybOplhpMBSCgP/2jTwoLUZh?= =?Windows-1252?Q?MYRRaFWWhDMSu9JTy9VwD5upTsqYrnTIWDUVD/xucMO1B8EWMpVE9Owb?= =?Windows-1252?Q?V+PgADFTvk+/BS5FOMPAaaZ0Dh917IjBtLA1tahYWwXfUpHPBNu7g3bv?= =?Windows-1252?Q?qyLHtBRnRegMEYPCgNVd8+X34BrxV8zeUE//ixvnROLV/LSBJTyQle0u?= =?Windows-1252?Q?2cDgNuN1mgQG8mDCa5BV57ug0+7J17X358I/IHY9faRilppwD/wv2Qh7?= =?Windows-1252?Q?3+jNH9eeUfV0poLu23sVK27d0enqiOFhBB98tQn5OI6x1nYCGP4DHP7u?= =?Windows-1252?Q?h54pY1sGYGrlncl7qG64m2POrS3wasWPP+0GEHgfmZ6jQobOiR9kyzoL?= =?Windows-1252?Q?W48InW2yghpPm4c6x0O5ftOdX8BEATD0QFWl+8gJncSKao+A3TJQcYmG?= =?Windows-1252?Q?t0xwUCCnPObpVUdupRjl17Rtblh6JSWgYI8ecoe8HnVcaLGpdC/FuAEO?= =?Windows-1252?Q?Q2ssr8osaR1Ko1fuvtKDISBVYPwEsHXgbgoV/Cis9A+2o87tJoRs/Btw?= =?Windows-1252?Q?0ditH4sWsx4kaJitT/6Mapj9gta2ca80cWYj//cD/AuQz1rBAH2o8Ehp?= =?Windows-1252?Q?r8wvAWSnsfcO+/cMk/h2OgQzHx4DTs6vLJQ/l3ij9Zqzr9f8rjuYe34Q?= =?Windows-1252?Q?uDSZA0ziJ81YozYIW26RWdRyOG/wjuoR+9S64BeRaQlu4wbclqt3gMDY?= =?Windows-1252?Q?dI/jI4MXfB29mOPWT6QqCGoakGe5H6lAHLm3WBrVFqcjLKiXihxx/D7t?= =?Windows-1252?Q?Q0cZqa2erLSzPla6mOj0K0XqVsLUO+diOyan+fICn5F9Vcu8YEPGhMYq?= =?Windows-1252?Q?XSVAqUMLDOH2z41VWy1hkMA7OgnB7kg+XykIi2mp/IRBHMZ2l+PX5mOf?= =?Windows-1252?Q?RO4F6taACFOrbpawha72IPPQ+/I33+KKvF/VJmlw0GHlUfv3aLpemBc/?= =?Windows-1252?Q?Uk06IjtHlTgnnODXYmrZaHFl3U1pFAQcokSPkhYypx0tqteasJeejKQ/?= =?Windows-1252?Q?1U1piO0aYRA3Aw/zX3E?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2384; 6:LFN3yNJ1uZewnIoXTJG7VOirpW9MLvtiSUJlYRCAwlR1SbleDqA6ZJESiHySmQYSo7gBZVX5SMongLDRtKw3pPZbqWyGtHVxgJDzGP4x4mEYpwdqCJY7qaZ4mYjSansKW8n1GzetI4UaMvdC7eYop7kt20iVMBxEVjNROtK2Ol3NSQQ0T3smSuJjIo8T+902i4Ilmm50QLpUwewl5Hgf03QUASqWL6yFQEdshxnifmyIEIpD7jLKqRua8dlF0sSFrGifQZFq4mDWnwtLNONHPC06JzmGXpt+LHaShLuK9a7hHc5WWlH5tZDtlw4ILPlW; 5:Pz5WsFcsQcpY6nQQwUv0vRWnequHjYFDhnm1bLcM6pBMrNa6pnBXOMYYPouxaXdLwh47mLKf4D5uidj2HdLu8A25aAQtOd6WKbxDufANg2EjKWqHpPLNwLiA4IjrNGlM1LqJzagwVkKA/SuySMBMGp8lv+/K8IXWTVFjS6uGj3M=; 24:brIs+4btlTaoqwn5ioZ/hCL70/Yu1gxUXc6GfZ9DsBDRPT3L54PWHIbpo/biOTqmPUOjsM+E0zk/8C/aB9bkZIjXOrWhCfay/bg90x/8IwA=; 7:y7HgDdQqC+WYJ1B6xYkW8G+JYzpBmuN1CJS1DQN0A2MN3SqQgVn/dn5Rpj7sur7XIHN3kR/cJ++/EjGd2n0UoHMddTcWibYuG4s6uoR2kvoD556vnYBrBxGM363IYw/LRZEqdmVQFplWYT0+YHjMAlMT01Rs0fAy4y9Hv8MwyHFTptd5rvwfBu8dFJ7cGUtZqIIObiJYfbii99dtUDLvTlvWYmX89ldVB8ZUQxQPlQWXjTktvsTdVOPTd8lzROt6UVISNL/qK4Mh9IapqEITPQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 13:43:32.9278 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2384 Subject: Re: [dpdk-dev] [PATCH v5 10/17] ethdev: get rid of eth driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 13:43:36 -0000 On Wednesday 22 June 2016 06:58 PM, Neil Horman wrote: > On Wed, Jun 22, 2016 at 02:36:29PM +0530, Shreyansh Jain wrote: >> Now that all pdev are pci drivers, we don't need to register ethdev drivers >> through a dedicated channel. >> >> Signed-off-by: David Marchand >> Signed-off-by: Shreyansh Jain >> --- >> lib/librte_ether/rte_ethdev.c | 22 ---------------------- >> lib/librte_ether/rte_ethdev.h | 12 ------------ >> lib/librte_ether/rte_ether_version.map | 1 - >> 3 files changed, 35 deletions(-) >> >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >> index 312c42c..06065fe 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++ b/lib/librte_ether/rte_ethdev.c >> @@ -340,28 +340,6 @@ rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev) >> return 0; >> } >> >> -/** >> - * Register an Ethernet [Poll Mode] driver. >> - * >> - * Function invoked by the initialization function of an Ethernet driver >> - * to simultaneously register itself as a PCI driver and as an Ethernet >> - * Poll Mode Driver. >> - * Invokes the rte_eal_pci_register() function to register the *pci_drv* >> - * structure embedded in the *eth_drv* structure, after having stored the >> - * address of the rte_eth_dev_init() function in the *devinit* field of >> - * the *pci_drv* structure. >> - * During the PCI probing phase, the rte_eth_dev_init() function is >> - * invoked for each PCI [Ethernet device] matching the embedded PCI >> - * identifiers provided by the driver. >> - */ >> -void >> -rte_eth_driver_register(struct eth_driver *eth_drv) >> -{ >> - eth_drv->pci_drv.devinit = rte_eth_dev_pci_probe; >> - eth_drv->pci_drv.devuninit = rte_eth_dev_pci_remove; >> - rte_eal_pci_register(ð_drv->pci_drv); >> -} >> - >> int >> rte_eth_dev_is_valid_port(uint8_t port_id) >> { >> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >> index 2249466..ffd24e4 100644 >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -1862,18 +1862,6 @@ struct eth_driver { >> }; >> >> /** >> - * @internal >> - * A function invoked by the initialization function of an Ethernet driver >> - * to simultaneously register itself as a PCI driver and as an Ethernet >> - * Poll Mode Driver (PMD). >> - * >> - * @param eth_drv >> - * The pointer to the *eth_driver* structure associated with >> - * the Ethernet driver. >> - */ >> -void rte_eth_driver_register(struct eth_driver *eth_drv); >> - >> -/** >> * Convert a numerical speed in Mbps to a bitmap flag that can be used in >> * the bitmap link_speeds of the struct rte_eth_conf >> * >> diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map >> index cf4581c..8151007 100644 >> --- a/lib/librte_ether/rte_ether_version.map >> +++ b/lib/librte_ether/rte_ether_version.map >> @@ -80,7 +80,6 @@ DPDK_2.2 { >> rte_eth_dev_vlan_filter; >> rte_eth_dev_wd_timeout_store; >> rte_eth_dma_zone_reserve; >> - rte_eth_driver_register; >> rte_eth_led_off; >> rte_eth_led_on; >> rte_eth_link; > Nak, Same issue as the crypto registration Yes, I agree. I will fix this in next version. > >> -- >> 2.7.4 >> >> >