From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/2] net/thunderx: fix unused function nicvf_mbox_msg_str error
Date: Tue, 28 Jun 2016 09:56:02 +0100 [thread overview]
Message-ID: <57723BA2.6000002@intel.com> (raw)
In-Reply-To: <1467044166-31912-2-git-send-email-jerin.jacob@caviumnetworks.com>
On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> Fix the following error with clang
> error: unused function 'nicvf_mbox_msg_str'
>
> The nicvf_mbox_msg_str() maybe unused, based on DEBUG
> compilation option selected. Mark __attribute__((unused)) on
> this function, to inform compiler that this function may be unused
>
> Fixes: e93592f1 ("net/thunderx/base: add mbox APIs for PF/VF communication")
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
...
> -static inline const char *
> +static inline const char * __attribute__((unused))
it is possible to use __rte_unused macro here, although not required,
and moving it before return type can prevent checkpatch error
> nicvf_mbox_msg_str(int msg)
> {
> assert(msg >= 0 && msg < NIC_MBOX_MSG_MAX);
>
Checkpatch gives following error:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#39: FILE: drivers/net/thunderx/base/nicvf_mbox.c:67:
+static inline const char * __attribute__((unused))
check-git-log gives following errors:
Wrong headline format:
net/thunderx: fix unused function nicvf_mbox_msg_str error
next prev parent reply other threads:[~2016-06-28 8:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 16:16 [dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc Jerin Jacob
2016-06-27 16:16 ` [dpdk-dev] [PATCH 2/2] net/thunderx: fix unused function nicvf_mbox_msg_str error Jerin Jacob
2016-06-28 8:56 ` Ferruh Yigit [this message]
2016-06-29 10:39 ` Bruce Richardson
2016-06-29 10:43 ` Bruce Richardson
2016-06-28 8:55 ` [dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc Ferruh Yigit
2016-06-29 10:39 ` Bruce Richardson
2016-06-29 10:43 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57723BA2.6000002@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).