From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 095E72C14
 for <dev@dpdk.org>; Tue, 28 Jun 2016 18:12:30 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga104.fm.intel.com with ESMTP; 28 Jun 2016 09:11:49 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,541,1459839600"; d="scan'208";a="1006808597"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.47])
 ([10.237.221.47])
 by orsmga002.jf.intel.com with ESMTP; 28 Jun 2016 09:11:48 -0700
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
 thomas.monjalon@6wind.com, dev@dpdk.org
References: <CAATJJ0KgKO3nOYxVWs4-tHdFOJ7=Co-FWpdfNppXYCTOOrp=aA@mail.gmail.com>
 <1465830632-25156-1-git-send-email-christian.ehrhardt@canonical.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <5772A1C4.3030700@intel.com>
Date: Tue, 28 Jun 2016 17:11:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1465830632-25156-1-git-send-email-christian.ehrhardt@canonical.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [RFC] mk: filter duplicate configuration entries
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jun 2016 16:12:31 -0000

On 6/13/2016 4:10 PM, Christian Ehrhardt wrote:
> Due to the hierarchy and the demand to keep the base config shoing all
> options some options end up multiple times in the .config file.
> 
> A suggested solution was to filter for duplicates at the end of the
> actual config step which is implemented here.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  mk/rte.sdkconfig.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
> index a3acfe6..734aa06 100644
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
> @@ -70,6 +70,11 @@ config: notemplate
>  else
>  config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
Not sure if this should go under this rule, or "$(RTE_OUTPUT)/.config:"
and should work with ".config_tmp".

>  	$(Q)$(MAKE) depdirs
> +	tac $(RTE_OUTPUT)/.config | awk --field-separator '=' '!/^#/ {print $$1}' | while read config; do \
Why reversing file since already checking all lines one by one in
original file?

And instead of checking each line, it is possible to get list of
duplicates via "sort | uniq -d".

Although less important, file comments also tripled in final .config.

> +		if [ $$(grep "^$${config}=" $(RTE_OUTPUT)/.config | wc -l) -gt 1 ]; then \
"grep -c" can be used instead of "grep | wc -l"

> +			sed -i "0,/$${config}/{//d}" $(RTE_OUTPUT)/.config; \
> +		fi; \
> +	done
>  	@echo "Configuration done"
>  endif
>  
>