From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 3E01F5AB7
 for <dev@dpdk.org>; Wed,  6 Jul 2016 10:07:03 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP; 06 Jul 2016 01:06:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,318,1464678000"; d="scan'208";a="730254583"
Received: from syueh-mobl12.gar.corp.intel.com (HELO [10.255.149.163])
 ([10.255.149.163])
 by FMSMGA003.fm.intel.com with ESMTP; 06 Jul 2016 01:06:48 -0700
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
 thomas.monjalon@6wind.com, dev@dpdk.org
References: <CAATJJ0+1MWVE6C1MAr=etkSAErmNOg3mVm2k6b6yxL=VVB1e0w@mail.gmail.com>
 <1467783465-14533-1-git-send-email-christian.ehrhardt@canonical.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <577CBC16.7020301@intel.com>
Date: Wed, 6 Jul 2016 09:06:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1467783465-14533-1-git-send-email-christian.ehrhardt@canonical.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3] mk: filter duplicate configuration entries
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jul 2016 08:07:03 -0000

On 7/6/2016 6:37 AM, Christian Ehrhardt wrote:
> *updates in v3*
> - replace tac with sed '1!G;h;$!d' to avoid build time dependency
> 
> *updates in v2*
> - move to .config target
> - fix usage order of tac
> - simplify inner section by only using awk (instead of awk+loop+bash+sed)
> 
> Due to the hierarchy and the demand to keep the base config showing all
> options, some config keys end up multiple times in the .config file.
> 
> Due to the way the actual config is sourced only the last entry is
> important. That can confuse people changing values in .config which
> are then ignored.
> 
> A suggested solution was to filter for duplicates at the end of the
> actual config step which is implemented here.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>