From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id D2D9628F3 for ; Tue, 27 Feb 2018 19:01:44 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1B0CE4040073; Tue, 27 Feb 2018 18:01:44 +0000 (UTC) Received: from [10.36.112.12] (unknown [10.36.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95725AFD60; Tue, 27 Feb 2018 18:01:42 +0000 (UTC) To: Zhiyong Yang , dev@dpdk.org, yliu@fridaylinux.org, jianfeng.tan@intel.com, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dong1.wang@intel.com References: <20180214145330.4679-1-zhiyong.yang@intel.com> <20180214145330.4679-4-zhiyong.yang@intel.com> From: Maxime Coquelin Message-ID: <5780f87d-96bc-2c51-eaf8-d38ac4af7d11@redhat.com> Date: Tue, 27 Feb 2018 19:01:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180214145330.4679-4-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 27 Feb 2018 18:01:44 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 27 Feb 2018 18:01:44 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH 3/4] net/virtio-user: support server mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 18:01:45 -0000 On 02/14/2018 03:53 PM, Zhiyong Yang wrote: > virtio user adds to support for server mode. > > Virtio user with server mode creates socket file and then starts to wait > for first connection from vhost user with client mode in blocking mode. > > Server mode virtio user supports many times' vhost reconnections with > same configurations. > > Support only one connection at the same time in server mode. > > Signed-off-by: Zhiyong Yang > --- > drivers/net/virtio/virtio_ethdev.c | 9 ++- > drivers/net/virtio/virtio_user/vhost_user.c | 77 ++++++++++++++++++++-- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 44 +++++++++---- > drivers/net/virtio/virtio_user_ethdev.c | 81 ++++++++++++++++++++++-- > 4 files changed, 186 insertions(+), 25 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 884f74ad0..44d037d6b 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1273,9 +1273,13 @@ static void > virtio_notify_peers(struct rte_eth_dev *dev) > { > struct virtio_hw *hw = dev->data->dev_private; > - struct virtnet_rx *rxvq = dev->data->rx_queues[0]; > + struct virtnet_rx *rxvq = NULL; I don't think it is needed to assign to NULL here. > struct rte_mbuf *rarp_mbuf; > > + if (!dev->data->rx_queues) > + return; > + > + rxvq = dev->data->rx_queues[0]; The above change is valid, but I think it should be in a dedicated patch, as it might be backported to -stable. > rarp_mbuf = rte_net_make_rarp_packet(rxvq->mpool, > (struct ether_addr *)hw->mac_addr); > if (rarp_mbuf == NULL) { > @@ -1333,7 +1337,8 @@ virtio_interrupt_handler(void *param) > > if (isr & VIRTIO_NET_S_ANNOUNCE) { > virtio_notify_peers(dev); > - virtio_ack_link_announce(dev); > + if (hw->cvq) > + virtio_ack_link_announce(dev); Is this change also related to server mode? It may deserve a dedicated patch too. > } > } Thanks, Maxime