From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id 5F2C0FE5 for ; Thu, 14 Jul 2016 06:38:44 +0200 (CEST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OAA00IAKFKIYW80@mailout4.w1.samsung.com> for dev@dpdk.org; Thu, 14 Jul 2016 05:38:42 +0100 (BST) X-AuditID: cbfec7f4-f796c6d000001486-0d-57871752f92d Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id A3.DF.05254.25717875; Thu, 14 Jul 2016 05:38:42 +0100 (BST) Received: from [106.109.129.180] by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OAA00CXLFKH6320@eusync1.samsung.com>; Thu, 14 Jul 2016 05:38:42 +0100 (BST) To: Yuanhan Liu , Rich Lane References: <20160710131731.GS26521@yliu-dev.sh.intel.com> <20160711083825.GY26521@yliu-dev.sh.intel.com> <57836BE0.2070401@samsung.com> <20160711110503.GZ26521@yliu-dev.sh.intel.com> <5783876C.1050103@samsung.com> <20160712024305.GB26521@yliu-dev.sh.intel.com> <578485CC.8070809@samsung.com> <5785EEEF.3080400@samsung.com> <20160713084732.GH26521@yliu-dev.sh.intel.com> <20160714014245.GB5146@yliu-dev.sh.intel.com> Cc: "dev@dpdk.org" , Huawei Xie , Dyasly Sergey , Heetae Ahn , Jianfeng Tan , Stephen Hemminger , Thomas Monjalon From: Ilya Maximets Message-id: <57871750.10708@samsung.com> Date: Thu, 14 Jul 2016 07:38:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160714014245.GB5146@yliu-dev.sh.intel.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xy7pB4u3hBu2beCzefdrOZDHt8212 i/aZZ5ksrrT/ZLfonv2FzWLTu0msFpNnS1ksviNn8WXTdDaL6xMusDpweVzsv8Po8eDyTSaP XwuWsnos3vOSyWPeyUCPnpPzmDz6tqxiDGCP4rJJSc3JLEst0rdL4Mp4/66ZtWAdR8X31rss DYy72boYOTkkBEwkZq3YxQhhi0lcuLceKM7FISSwlFGia8piRgjnBaPEtIafLCBVwgJ+Ems3 TALrEBEIkZjT28sOUfSRWWL9g/XMIA6zwFwmiZdTD4J1sAnoSJxafQSsg1dAQ2LfnBNAOzg4 WARUJc68qwAJiwpESMza/oMJokRQ4sfke2CtnAJWEl8XTWcGKWcW0JO4f1ELJMwsIC+xec1b 5gmMArOQdMxCqJqFpGoBI/MqRtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJCY+LKDcfExq0OM AhyMSjy8D/LawoVYE8uKK3MPMUpwMCuJ8G4Tbg8X4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjt3 1/sQIYH0xJLU7NTUgtQimCwTB6dUAyPrz9Mnlr1m7XX7Wbsm7+hFds+K8P3hPoWh9n/8RJU/ bE2xmW1ax7S2cuVuIY33vuUtDZ85jOVWy4mySV2u2JneorZqVtnfdZePN2y1m9+xUmra46R3 HEePtj/T1g6+6jTPiE82WSlbIjjAb55NuW6goNi3nZXKK3OenrnMskHeZp6J+iIleyWW4oxE Qy3mouJEAAExnTuFAgAA Subject: Re: [dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2016 04:38:44 -0000 On 14.07.2016 04:42, Yuanhan Liu wrote: > On Wed, Jul 13, 2016 at 08:54:08AM -0700, Rich Lane wrote: >> On Wednesday, July 13, 2016, Yuanhan Liu wrote: >> >> On Wed, Jul 13, 2016 at 10:34:07AM +0300, Ilya Maximets wrote: >> > This scenario fixed somehow, I agree. But this patch still needed to >> protect >> > vhost from untrusted VM, from malicious or buggy virtio application. >> > Maybe we could change the commit-message and resend this patch as a >> > security enhancement? What do you think? >> >> Indeed, but I'm a bit concerned about the performance regression found >> by Rich, yet I am not quite sure why it happens, though Rich claimed >> that it seems to be a problem related to compiler. >> >> >> The workaround I suggested solves the performance regression. But even if it >> hadn't, this is a security fix that should be merged regardless of the >> performance impact. > > Good point. Ilya, would you reword the commit log and resend based on > latest code? OK.