From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE072A04E7; Mon, 2 Nov 2020 13:57:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CF19C840; Mon, 2 Nov 2020 13:57:39 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 94EE5C82A for ; Mon, 2 Nov 2020 13:57:37 +0100 (CET) IronPort-SDR: SMkvhYSdSAUprLkbk01ta8B6UHvOzpolgsA5HArxKVA1Pc3DBj1uX6HuIx/j6fJSuJTbjJDnpF 0wAoBhfKBwyw== X-IronPort-AV: E=McAfee;i="6000,8403,9792"; a="165373467" X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="165373467" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 04:57:34 -0800 IronPort-SDR: ZPbc4yChlmKi4DLR4ru3kWC+y33DNplFM+rZnkYTp05NOVXLxQs8pKuimDSsWtbnEwukhn+xAh aVG4ncekZupA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,444,1596524400"; d="scan'208";a="320052811" Received: from silpixa00399498.ir.intel.com (HELO silpixa00399498.ger.corp.intel.com) ([10.237.222.52]) by orsmga003.jf.intel.com with ESMTP; 02 Nov 2020 04:57:32 -0800 From: Anatoly Burakov To: dev@dpdk.org Cc: thomas@monjalon.net, liang.j.ma@intel.com, david.hunt@intel.com Date: Mon, 2 Nov 2020 12:57:36 +0000 Message-Id: <57898fa9cf20b6b4a5c101a20874b7098a13edba.1604321851.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] eal: fix incorrect API doc for power intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently, the intrinsics documentation refers to `rte_cpu_get_features` as a check for whether these intrinsics are supported at runtime. This is incorrect, because actually the user should use the `rte_cpu_get_intrinsics_support` API to do said check. Fix the typo. Fixes: 128021421256 ("eal: add intrinsics support check infrastructure") Cc: liang.j.ma@intel.com Signed-off-by: Anatoly Burakov --- lib/librte_eal/include/generic/rte_power_intrinsics.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/include/generic/rte_power_intrinsics.h b/lib/librte_eal/include/generic/rte_power_intrinsics.h index 9622c7f9ce..dd520d90fa 100644 --- a/lib/librte_eal/include/generic/rte_power_intrinsics.h +++ b/lib/librte_eal/include/generic/rte_power_intrinsics.h @@ -33,7 +33,7 @@ * optimized power state may be aborted. * * @warning It is responsibility of the user to check if this function is - * supported at runtime using `rte_cpu_get_features()` API call. + * supported at runtime using `rte_cpu_get_intrinsics_support()` API call. * Failing to do so may result in an illegal CPU instruction error. * * @param p @@ -74,7 +74,7 @@ static inline void rte_power_monitor(const volatile void *p, * waking up the CPU. * * @warning It is responsibility of the user to check if this function is - * supported at runtime using `rte_cpu_get_features()` API call. + * supported at runtime using `rte_cpu_get_intrinsics_support()` API call. * Failing to do so may result in an illegal CPU instruction error. * * @param p @@ -110,7 +110,7 @@ static inline void rte_power_monitor_sync(const volatile void *p, * timestamp is reached. * * @warning It is responsibility of the user to check if this function is - * supported at runtime using `rte_cpu_get_features()` API call. + * supported at runtime using `rte_cpu_get_intrinsics_support()` API call. * Failing to do so may result in an illegal CPU instruction error. * * @param tsc_timestamp -- 2.17.1