From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id 188FC952 for ; Mon, 18 Jul 2016 15:47:40 +0200 (CEST) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6IDiRIx027470 for ; Mon, 18 Jul 2016 09:47:40 -0400 Received: from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146]) by mx0b-001b2d01.pphosted.com with ESMTP id 2482ge05pd-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 18 Jul 2016 09:47:40 -0400 Received: from localhost by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 18 Jul 2016 23:47:37 +1000 Received: from d23dlp01.au.ibm.com (202.81.31.203) by e23smtp04.au.ibm.com (202.81.31.210) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 18 Jul 2016 23:47:35 +1000 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: gowrishankar.m@linux.vnet.ibm.com X-IBM-RcptTo: dev@dpdk.org Received: from d23relay10.au.ibm.com (d23relay10.au.ibm.com [9.190.26.77]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 92F152CE8046 for ; Mon, 18 Jul 2016 23:47:34 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6IDlYQ120971570 for ; Mon, 18 Jul 2016 23:47:34 +1000 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u6IDlYjB003698 for ; Mon, 18 Jul 2016 23:47:34 +1000 Received: from [9.84.229.154] ([9.84.229.154]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u6IDlUQ4003683; Mon, 18 Jul 2016 23:47:32 +1000 From: gowrishankar muthukrishnan To: Chao Zhu , dev@dpdk.org References: <1468137084-5983-1-git-send-email-gowrishankar.m@linux.vnet.ibm.com> <000001d1de47$3440a0b0$9cc1e210$@linux.vnet.ibm.com> <5789E94A.6000603@linux.vnet.ibm.com> <000101d1e0d1$f7ffacd0$e7ff0670$@linux.vnet.ibm.com> Cc: "'Bruce Richardson'" , "'Konstantin Ananyev'" , "'Thomas Monjalon'" , "'Cristian Dumitrescu'" , "'Pradeep'" Date: Mon, 18 Jul 2016 19:17:30 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <000101d1e0d1$f7ffacd0$e7ff0670$@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16071813-0012-0000-0000-000001AC8E26 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16071813-0013-0000-0000-000005995118 Message-Id: <578CDDF2.1000806@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-07-18_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607180155 Subject: Re: [dpdk-dev] [PATCH v2 0/6] enable lpm, acl and other missing libraries in ppc64le X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 13:47:41 -0000 Hi Chao, I just tried building dpdk master with these patches in ubuntu 16.04 le guest and I could able to. test@ubuntu:~/DPDK$ make install T=ppc_64-power8-linuxapp-gcc -j16 .... ..... INSTALL-MAP test.map INSTALL-APP test Build complete [ppc_64-power8-linuxapp-gcc] Installation cannot run with T defined and DESTDIR undefined test@ubuntu:~/DPDK$ uname -a Linux ubuntu 4.4.0-21-generic #37-Ubuntu SMP Mon Apr 18 18:30:22 UTC 2016 ppc64le ppc64le ppc64le GNU/Linux test@ubuntu:~/DPDK$ gcc --version gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.1) 5.4.0 20160609 May be you need to check gcc again. Thanks, Gowrishankar On Monday 18 July 2016 02:24 PM, Chao Zhu wrote: > Gowrishankar, > > I still get this error with the v3 patches. My OS is Ubuntu 16.04 LTS > ppc64le. GCC version: Ubuntu/IBM 5.3.1-14ubuntu2 > Can you help to check again? > > In file included from > /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0: > /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function > 'transition4': > /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > *indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], > ^ > /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error: > dereferencing type-punned pointer will break strict-aliasing rules > [-Werror=strict-aliasing] > *indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], > ^ > > > > -----Original Message----- > From: gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com] > Sent: 2016年7月16日 15:59 > To: Chao Zhu;dev@dpdk.org > Cc: 'Bruce Richardson'; 'Konstantin Ananyev' > ; 'Thomas Monjalon' > ; 'Cristian Dumitrescu' > ; 'Pradeep' > Subject: Re: [PATCH v2 0/6] enable lpm, acl and other missing libraries in > ppc64le > > Hi Chao, > I did not face this error. Even I verified today with tip of master > 6596554... . > However I had patch conflict for examples/l3fwd/l3fwd_em.c which is fixed > now and v3 patch set sent recently. Could you please check. > > Thanks, > Gowrishankar > On Friday 15 July 2016 08:45 AM, Chao Zhu wrote: >> Gowrishankar, >> >> When I tried the patches, I got some compilation error: >> >> In file included from >> /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.c:34:0: >> /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h: In function >> 'transition4': >> /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:198:2: error: >> dereferencing type-punned pointer will break strict-aliasing rules >> [-Werror=strict-aliasing] >> *indices1 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], >> ^ >> /root/test/sub/dpdk/lib/librte_acl/acl_run_altivec.h:202:2: error: >> dereferencing type-punned pointer will break strict-aliasing rules >> [-Werror=strict-aliasing] >> *indices2 = (xmm_t){((uint32_t *)&v)[0], ((uint32_t *)&v)[1], >> >> Can you help to take a look? >> >> >> -----Original Message----- >> From: Gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com] >> Sent: 2016年7月10日 15:51 >> To:dev@dpdk.org >> Cc: Chao Zhu; Bruce Richardson >> ; Konstantin Ananyev >> ; Thomas Monjalon >> ; Cristian Dumitrescu >> ; Pradeep; >> gowrishankar >> Subject: [PATCH v2 0/6] enable lpm, acl and other missing libraries in >> ppc64le >> >> From: gowrishankar >> >> This patchset enables LPM, ACL and other few missing libs in ppc64le >> and also address few patches in related examples (ip_pipeline and l3fwd). >> >> Test report: >> LPM and ACL unit tests verified as in patch set v1. >> Same results as before observed. >> >> v2 changes: >> - enabling libs in config included as part of lib changes itself. >> >> gowrishankar (6): >> lpm: add altivec intrinsics for dpdk lpm on ppc_64 >> acl: add altivec intrinsics for dpdk acl on ppc_64 >> ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64 >> table: cache align rte_bucket_4_8 >> sched: enable sched library for ppc64le >> l3fwd: add altivec support for em_hash_key >> >> app/test-acl/main.c | 4 + >> app/test/test_xmmt_ops.h | 16 + >> config/defconfig_ppc_64-power8-linuxapp-gcc | 7 - >> examples/ip_pipeline/cpu_core_map.c | 12 +- >> examples/ip_pipeline/init.c | 4 + >> examples/l3fwd/l3fwd_em.c | 8 + >> lib/librte_acl/Makefile | 2 + >> lib/librte_acl/acl.h | 4 + >> lib/librte_acl/acl_run.h | 2 + >> lib/librte_acl/acl_run_altivec.c | 47 +++ >> lib/librte_acl/acl_run_altivec.h | 328 >> +++++++++++++++++++++ >> lib/librte_acl/rte_acl.c | 13 + >> lib/librte_acl/rte_acl.h | 1 + >> .../common/include/arch/ppc_64/rte_vect.h | 60 ++++ >> lib/librte_lpm/Makefile | 2 + >> lib/librte_lpm/rte_lpm.h | 2 + >> lib/librte_lpm/rte_lpm_altivec.h | 154 ++++++++++ >> lib/librte_table/rte_table_hash_key8.c | 2 +- >> 18 files changed, 649 insertions(+), 19 deletions(-) create mode >> 100644 lib/librte_acl/acl_run_altivec.c create mode 100644 >> lib/librte_acl/acl_run_altivec.h create mode 100644 >> lib/librte_eal/common/include/arch/ppc_64/rte_vect.h >> create mode 100644 lib/librte_lpm/rte_lpm_altivec.h >> >> -- >> 1.9.1 >> >> >> > >