From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8FD975583 for ; Fri, 22 Jul 2016 15:18:41 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 22 Jul 2016 06:18:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,405,1464678000"; d="scan'208";a="851265983" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.159]) ([10.237.220.159]) by orsmga003.jf.intel.com with ESMTP; 22 Jul 2016 06:18:40 -0700 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" , "Mcnamara, John" References: <1468083394-94907-1-git-send-email-pablo.de.lara.guarch@intel.com> <20160722125410.GE9044@6wind.com> From: Ferruh Yigit Message-ID: <57921D2E.20604@intel.com> Date: Fri, 22 Jul 2016 14:18:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160722125410.GE9044@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: announce driver name changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 13:18:42 -0000 On 7/22/2016 1:54 PM, Adrien Mazarguil wrote: > Hi Pablo, > > On Fri, Jul 22, 2016 at 12:37:22PM +0000, De Lara Guarch, Pablo wrote: >> Hi, >> >>> -----Original Message----- >>> From: De Lara Guarch, Pablo >>> Sent: Saturday, July 09, 2016 5:57 PM >>> To: dev@dpdk.org >>> Cc: Mcnamara, John; De Lara Guarch, Pablo >>> Subject: [PATCH] doc: announce driver name changes >>> >>> Driver names for all the supported devices in DPDK do not have >>> a naming convention. Some are using a prefix, some are not >>> and some have long names. Driver names are used when creating >>> virtual devices, so it is useful to have consistency in the names. >>> >>> Signed-off-by: Pablo de Lara >>> --- >>> doc/guides/rel_notes/deprecation.rst | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/doc/guides/rel_notes/deprecation.rst >>> b/doc/guides/rel_notes/deprecation.rst >>> index f502f86..37d65c8 100644 >>> --- a/doc/guides/rel_notes/deprecation.rst >>> +++ b/doc/guides/rel_notes/deprecation.rst >>> @@ -41,3 +41,8 @@ Deprecation Notices >>> * The mempool functions for single/multi producer/consumer are >>> deprecated and >>> will be removed in 16.11. >>> It is replaced by rte_mempool_generic_get/put functions. >>> + >>> +* Driver names are quite inconsistent among each others and they will be >>> + renamed to something more consistent (net_ prefix for net drivers and >>> + crypto_ for crypto drivers) in 16.11. Some of these driver names are used >>> + publicly, to create virtual devices, so a deprecation notice is necessary. >>> -- >>> 2.7.4 >> >> Any more comments on this (apart from Christian Ehrhardt's)? > > Yes, since you're suggesting to prefix driver names, shall "librte_pmd_mlx5" > really become "net_librte_pmd_mlx5" or shortened to "net_mlx5" instead? > > What about using a '/' separator instead of '_'? > > Will this impact directories as well ("net/mlx5" -> "net/net_mlx5")? > For physical net devices, driver name is same as folder name (mlnx5, ixgbe ...) For virtual net devices, driver name is folder name with "eth_" prefix (eth_pcap, eth_ring) Driver names for net devices looks consistent already, I don't know about crypto devices but if crypto driver names are inconsistent what do you think renaming crypto drivers only? Thanks, ferruh