From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 06E471041 for ; Fri, 12 Jan 2018 19:34:07 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 10:34:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,350,1511856000"; d="scan'208";a="18751524" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2018 10:34:05 -0800 To: maciej.czekaj@caviumnetworks.com, dev@dpdk.org Cc: shahafs@mellanox.com, thomas@monjalon.net References: <1514985137-2653-1-git-send-email-maciej.czekaj@caviumnetworks.com> From: Ferruh Yigit Message-ID: <5795a502-77cf-2b33-a723-bb7b43ec6d82@intel.com> Date: Fri, 12 Jan 2018 18:34:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1514985137-2653-1-git-send-email-maciej.czekaj@caviumnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/thunderx: Convert ThunderX VNIC PMD to new offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 18:34:08 -0000 On 1/3/2018 1:12 PM, maciej.czekaj@caviumnetworks.com wrote: > From: Maciej Czekaj > > This patch removes all references to old-style offload API > replacing them with new offload flags. > > Signed-off-by: Maciej Czekaj <...> > > dev_info->default_txconf = (struct rte_eth_txconf) { > .tx_free_thresh = NICVF_DEFAULT_TX_FREE_THRESH, > - .txq_flags = > - ETH_TXQ_FLAGS_NOMULTSEGS | > - ETH_TXQ_FLAGS_NOREFCOUNT | > - ETH_TXQ_FLAGS_NOMULTMEMP | > - ETH_TXQ_FLAGS_NOVLANOFFL | > - ETH_TXQ_FLAGS_NOXSUMSCTP, > + .txq_flags = ETH_TXQ_FLAGS_IGNORE, I am not sure about this, Shahafs may comment better, shouldn't application decide to set "ETH_TXQ_FLAGS_IGNORE" or not, instead of having this in default configuration? <...> > + if ((conf_tx_offloads & tx_offload_capa) != conf_tx_offloads) { > + PMD_INIT_LOG(ERR, "Some Tx offloads are not supported " > + "requested 0x%lx supported 0x%lx\n", > + conf_tx_offloads, tx_offload_capa); This is broken for 32bits, using PRIx64 instead of "lx" makes your code more portable.