From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A41BAA09E4; Thu, 28 Jan 2021 12:07:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CCF04067D; Thu, 28 Jan 2021 12:07:15 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id EA2A640395 for ; Thu, 28 Jan 2021 12:07:14 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 86FCE580778; Thu, 28 Jan 2021 06:07:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 28 Jan 2021 06:07:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= r+tLU8E9/4aHy630Iwqnsh+VBKCbfRe9vgEN2brtpOM=; b=c1wKNwxfyMBj7Cui EIllwqXfUFpf8x85jpc8WQ39hxa1Z5m/QjHfdnhUAvKK0iYoljatAPdzQBUKzwQv 05TqZKv40JtO0cLcsq5hftfTW1uWJOnFD0LJFGJBDbhkgRP0GH5z+XbcktkdBYPJ lq7P7mt1BS6peYwx7PVAc5xfeYXJ+0090wQ790D2Ssfau7V1GkRVAwRpqsNBv6Ax TkVMhQanh6Cv8MKTd8rhduqETscjiDt2+k7RLzek29HWs++/Zx8+Dn9+l3bXH2Qy d8S1OxW3iZjTo8ExMq/VnC4jyp62JE8NK4MDdZZeeQ8pKJkhvR3jZBaulpfTwXlI 6ydPGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=r+tLU8E9/4aHy630Iwqnsh+VBKCbfRe9vgEN2brtp OM=; b=VG8CpFDeKJbHPvXj1JQFixJeisJEeqkk2F1LcZyu1rcwOMNjLz2kvvbTr HPHmSri7/k21t8FhdRAoYzMxQySRawyHyNq0XKbLDjtOgWLulqmfakGVpV2iYMez waC7gY9MwjZk0FhnorYBtyLzLClRwbbd0WWHd7Oz0LwRe07ls3zmGXYgDaA9oeVL ilgRdid62hHkEbqmHP79loHaHtYRpx9lsb5oT1loA5arqfMd1mwKiXMRfZekRmCK PYkCDOV10RqYPjsOj5Ml9OVI5ll4ww/Un5DoZ0zIWAye/YEWU+PO5xVNxfs8+eUo zopyK/KA/yPAAAl4dsHY/LnHPUZtA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D3E81080059; Thu, 28 Jan 2021 06:07:12 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, Bruce Richardson , Konstantin Ananyev , Ferruh Yigit , Andrew Rybchenko , Yipeng Wang , Sameh Gobriel , Bernard Iremonger , Vladimir Medvedkin , Ori Kam , Honnappa Nagarahalli , Olivier Matz , Cristian Dumitrescu Date: Thu, 28 Jan 2021 12:07:11 +0100 Message-ID: <5799103.kSYvdEDt4n@thomas> In-Reply-To: <20210127173330.1671341-6-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210127173330.1671341-1-bruce.richardson@intel.com> <20210127173330.1671341-6-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 5/8] build: separate out headers for include checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/01/2021 18:33, Bruce Richardson: > For some libraries, there may be some header files which are not for direct > inclusion, but rather are to be included via other header files. To allow > later checking of these files for missing includes, we separate out the > indirect include files from the direct ones. > > Signed-off-by: Bruce Richardson [...] > + When ``check_includes`` build option is set to ``true``, each header file > + has additional checks performed on it, for example to ensure that it is > + not missing any include statements for dependent headers. > + For header files which are public, but only included indirectly in > + applications, these checks can be skipped by using the ``headers_no_chkincs`` > + variable rather than ``headers``. > + > +headers_no_chkincs > + **Default Value = []**. > + As with ``headers`` option above, except that the files are not checked > + for all needed include files as part of a DPDK build when > + ``check_includes`` is set to ``true``. If all such headers are included directly, I would prefer naming this group "indirect_headers" because maybe we will want to do other kind of processing on indirect headers. [...] > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -1,5 +1,7 @@ > # Please keep these options sorted alphabetically. > > +option('check_includes', type: 'boolean', value: false, > + description: 'build "chkincs" to verify each header file can compile alone') This should in the patch introducing the check?