From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BC33A0C52; Thu, 21 Oct 2021 17:33:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19124411FE; Thu, 21 Oct 2021 17:33:45 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 21EFF4118E for ; Thu, 21 Oct 2021 17:33:42 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="226523409" X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; d="scan'208";a="226523409" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2021 08:33:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; d="scan'208";a="568355730" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 21 Oct 2021 08:33:37 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 21 Oct 2021 08:33:37 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 21 Oct 2021 08:33:36 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 21 Oct 2021 08:33:36 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 21 Oct 2021 08:33:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X+ZwP+qNjpI3DyiRgVbaEIRMRdMv7+6JXlQsL8Djp+BGUivdctJCNistjqVyZJao40sYe2IKs7yZ5skMoVjh2CgBnhTzZCxFwSfv3I9XqKlQo9MFgpw8+qdDKm/L3uQZeWj2evHemPrN9KSgQXkpyTrsLasIKlsJPyTey8BlVlnCfrky4aD240G8ZtN0X68VHOeSfcmZZHWpuNlox6O0vThiGGWQSACCqqlSqRAToQDI1CBWBd+j//YWXCFQFBr99v2eWULQgW6lozGvFCjLlpiPo2IhkyrMfhz60uhBsnlo/EXIv+k0JW2EJ2CX1KSlRAw7P4MXgsoe6pmoydneTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GJ8/OEWyrTciKwzD59ek1EETNmHhI+VN28v6G1X/C6I=; b=oF431qt3iiNU3vKe8oAL4+btPrHjYbgYWeyJbMmGtH32d+9znlGlhZaGKfenXR+UK0C2YzjOeOjavP8+Tt7dyS2brthUZRs+V1nO0COpWq6O9PddjZxS4KbU3YDqbb8jnuQ5o4xZiZpbeijwMmN2i4lqe3ut5Jf73wG+g96FmPEbtu31TzEs+wXKOgRP38C4jJukfz+MT35k9Qn2wAdmzRL2cWXIZN5if0D6PsnWrQVn7FU6R5AxbhYta/tRc1gcyEYopaPxS3UO8mi5yVmpJDyjsYmr4mmztcOWq4dQMxB31tPqnnQ1CFryi4xMcYxbjTuIeD+kXZXqUEbH/QsqBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJ8/OEWyrTciKwzD59ek1EETNmHhI+VN28v6G1X/C6I=; b=oT45F1V1fNRzWh5u0Izwe0v5Wn0nBl9v0FnPeYFBzpnliZJOVnqcQJz/Ae2OWQUskOIfsjI1NCAWjqkOHnWDRu8zfx8Ze2rGgzCrPISjNCvomdglDgSY3CqvI/tfOHba3bdBYAcJBBPV+Ex4CY3dt4F6kxDDBitHkcXc5Y3QEbU= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5016.namprd11.prod.outlook.com (2603:10b6:510:32::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Thu, 21 Oct 2021 15:33:33 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Thu, 21 Oct 2021 15:33:33 +0000 Message-ID: <579fa9cd-07cd-fade-d4ec-6e742806c7ca@intel.com> Date: Thu, 21 Oct 2021 16:33:27 +0100 Content-Language: en-US To: Tudor Cornea , CC: , , References: <1634306769-20123-1-git-send-email-tudor.cornea@gmail.com> <1634753626-84056-1-git-send-email-tudor.cornea@gmail.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <1634753626-84056-1-git-send-email-tudor.cornea@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0202CA0011.eurprd02.prod.outlook.com (2603:10a6:4:29::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0202CA0011.eurprd02.prod.outlook.com (2603:10a6:4:29::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Thu, 21 Oct 2021 15:33:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af8989d8-740f-4d5b-87cb-08d994a82460 X-MS-TrafficTypeDiagnostic: PH0PR11MB5016: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:332; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vjYuOtWgETkPm9EoW8dYDUNpvS+7agg3MFcBEfN1s22AkySV+CS0VvTSyocwE/cJcH9mvEFLNOqEIOk+JVpca6RosfDyUkTpAqzuHiNokj8o58TNYEsjBRnIxis3LT04Amfq+UUAKfqy3mPNOFRGLN8nk9B8qnB4JpXUYDw71gEBAj91MWhkIHHt7WWHIHaP9DvbpqyFy5e6Oo7Oq/s5wPVOVH2GcLxJs5NXHk6+f0405fBoualoSjmPCXqgaxJ6V9gL6GC8+SJjqAl0w8m90ZIHNf+KfxFg9J+0iXXrtA1gj3YsWYiuu19nIJfGN50iDK6b0/klZsWyLIQMThX2JhMbTrqP6y4JVBWzlpM63JCUJJIJSmgYPgPdKk8uFJR1OsepI+dyi3r84WmRwCTFgHBnCLEof/Xv4M+PsUZt+R1FKTR5GBF6ZlCH7G8wPwb/Wvkk1uCJy4V7LoPitL8ii8iezpQMzyMtCroEpWgXeWkO4oPPBRS2ImZEK7qraEaKiHAAfyPRt8ML9PMJNkulWgRkwSKBXUvq6fK9h+ugwa1+38iH6NgDMJMsB9U1CFU2hkqFh5gamHL5XKJ4swl5gs2+bnpOWd+uxbM5kQ0QLpUrfAuiD9Q0u7WLbZlr/UDfxWWHktvOlptgj0CiTH0n9+/csRhURiy3fQ2ZfzvDnLCCisF+bi2JGvJwMxTxVz1oJkQRDFAX7iibLAIecBTcx1F39kTDUqDpCHKqYchpV61naPwgED1532NqBScupNhihDD8A1SH0UoiGu50ASSCWAVardse2Oml9YvHUzvEqjgELVwfJjnza0LbQWfQgog4cHXcMHnPuczZ/WF1Ia801g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(82960400001)(5660300002)(53546011)(8676002)(6666004)(316002)(36756003)(31686004)(2616005)(38100700002)(2906002)(26005)(186003)(6636002)(8936002)(956004)(44832011)(966005)(31696002)(4326008)(86362001)(66476007)(66556008)(16576012)(83380400001)(6486002)(66946007)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2ZFK21yNFZuRVZNejcvM05SVnEwckpMZFl2cXpWSDdNVmY5ZUhnK2ZsWmxG?= =?utf-8?B?ZVZDREpURm1VNElmM3dFdCsydVkzRURaZXE2Y09MUHhQZC9ZbTViQWMvK3NF?= =?utf-8?B?VHR5MUpZU0dMRkZIcy94cG5IVFZQWjJIakxUSmxobHNmTktENzYxRGFZemV0?= =?utf-8?B?Nk13WlZKajd3aGpLWldIM3lNYmhWQWl4T29OSEpmSEVLeVYvNlN0c25OMytJ?= =?utf-8?B?SzVjSXdDZXdLKzExWHhveDZTd0kxT1NaV0NxUHdxSlBIajhSRXo2V2hXcUNS?= =?utf-8?B?aXVUeiszUklrbXZyejRPMFMzVUpvaWdCeHlDaWlRK1RVM08vYXpBWTJqWGNQ?= =?utf-8?B?VlVxYUZURzNhVWVnUVUrTVpSUDRjVGQwNEhGZmYyTnYzNFVJS0FKNFFXV2dk?= =?utf-8?B?b0lmeUZ4U1dEN3NYRloxUGxVQ0V5alVETHJFYkk0bU9GaHBqajFqWVR2WDkz?= =?utf-8?B?aUl4TmpSRmNqU2dXV2VqOUl1QVRPYjhDRkF5WjArVDZyQUZNNnFPaWF3Z2M4?= =?utf-8?B?MW9oQ1Q0MitnQkRyVDRiTDdOSzdtTVlQTEl3TlZWcW94QVp4VlBtSU1SUi92?= =?utf-8?B?ZlhxS2puU1lYNU1ua2tYZ2d0SGUvZHJkdHRiVnorb0hUS21jLzN5ZnFRa1ZT?= =?utf-8?B?R3BQdU1LTkovc0JOU2gybGVrUEtwRm0zN1NhV1BUaWx0WmVDcXE4anAza21M?= =?utf-8?B?dy9VTjZSV1pWbWNTTitQRTFGVG1pVUVJSDg1akFWdS9Xd1BxbE5kRHZiUGdG?= =?utf-8?B?dXRXcjFWeDlsaUZIaFB3MTJINEVWNitYTXprREFaQmNBcVZYZlV3OHhUUVBH?= =?utf-8?B?RzJVbVhKS3FpYzB5aTQ5UDhLMk1GOEFSK2NwbTkvL2dVWXdXL2NkRVpHTEV6?= =?utf-8?B?ZUtLSW9ZVW16QUZla2p4aFVUalh1ekt6WmVaRmJSbHV0bFdxWjJlYSszdmF3?= =?utf-8?B?eGVLMFdDam5odUJCMUx6cTcrMU9lWHcweWdmQ3F3ZEkvdlRlelRxUVp2TlFi?= =?utf-8?B?M3V3aFlrZk5PYkZuekpQVys4QzF6Z2lBZGdsVnREaUdiV1o2YVd1a3kxbW52?= =?utf-8?B?QmIxdHdDUURSOWg2VzRzbnVhVWNrdGNPTVBjMEFnMFR0SUpNQUN1RTBCRWJk?= =?utf-8?B?d0VJN0x1cmZXZVl6Q0JmcTg4RythcGVFVDJWcEFhaG9ISjlVZVI3NEx3bG41?= =?utf-8?B?cFQ1ZCtQMm5VOHozUUl2QTVWMm9oR3hseG01K2NtV0ZRd2ZDZlo5VDhidlR3?= =?utf-8?B?NlRwZmRJZjNzcTUzM0FWQ0llcUdZaTdaZFNRWEsvU1ozNERYZkhVN004K1Fx?= =?utf-8?B?di9pZ2N6RjZRYmpoakVQbkZEcWoxYnFCYlhhVUJ4K2FzVFRzU0RtQWV6dHcy?= =?utf-8?B?d2c2cmVFSGFOck0xRXZhc3lXYkFUT0JaWjJzZ3FqUEl3aFIxa2NaZjdHU0o0?= =?utf-8?B?T3ZxRlVLTkVaU2dWU2d1aXFDOHIyMFRjWFMxdjRtWlRpTHBhN3U2NVNCVEI3?= =?utf-8?B?RkJCWU1SRGl3TGNQZGkrYmJrditjQVpNR3phL21DNVdNZ05WbXVUUzR4WXln?= =?utf-8?B?TWNtVlh1YXdHK3lsSExVTmxSM1hQYzVuMm5ZaXBNa2xhSkJ6czF0N0tJTDh0?= =?utf-8?B?aDlhRE1ra0x5VXNqbFNMazNDMHFGNnhCYXhGWjlMMFJXMzQ1b2VxeFRKMCtL?= =?utf-8?B?ZnZSZDF5QURkV1JyZTNqUWlVSVRwamJEenY5NGVDOVhsMGhqZWNRcVFvOVBJ?= =?utf-8?B?N0FoQ3hqMzAxOENlR3piSDE3UHA2K1B2MTVYOGtPNHYxZ1NIZmVtS2trbzNH?= =?utf-8?B?VzA1TjJQdVQyeU4rejZDcm0xUWNib3V4Z1E5WVZyZ0NqNEZiMU1GbUszT0pn?= =?utf-8?B?b1duME1EK0d4ZEtuTWxPUWE1cGZFWWpNN3E2d3VmTUtzYUphRm92ajUvUVFq?= =?utf-8?Q?Yi7QkMWgLCMJ+lihH/c6QPXeGCdu+Ho/?= X-MS-Exchange-CrossTenant-Network-Message-Id: af8989d8-740f-4d5b-87cb-08d994a82460 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 15:33:33.7947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5016 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/20/2021 7:13 PM, Tudor Cornea wrote: > On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't > seem to initialize anymore, while running testpmd. > > Configuring Port 0 (socket 0) > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > Fail to start port 0: Invalid argument > Configuring Port 1 (socket 0) > ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. > ixgbevf_dev_start(): Unable to initialize RX hardware (-22) > Fail to start port 1: Invalid argument > Please stop the ports first > > If the call to ixgbevf_rlpml_set_vf fails and we return prematurely, > we will not be able to initialize the ports correctly. > > The behavior seems to have changed since the following commit: > > commit c77866a16904 ("net/ixgbe: detect failed VF MTU set") > Hi Tudor, We document this with explicit 'Fixes' tag, this also helps up to manage backporting patches to LTS releases, so updating as: Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF") Cc: stable@dpdk.org Also we use 'fix' verb in the patch title almost as keyword, again to help deciding which patch to backport, also to clarify impact of the patch, so will update patch title as: net/ixgbe: fix port initialization if MTU config fails For more details please check contribution guide: https://doc.dpdk.org/guides/contributing/patches.html Thanks, ferruh > We can make this particular use case work correctly if we don't > return an error, which seems to be consistent with the overall > kernel ixgbevf implementation. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c#n2015 > The code that this link references can change by time as code changes, I will update it as following to bind it a specific version (v5.14): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c?h=v5.14#n2015 > Signed-off-by: Tudor Cornea > > --- > v2: > * Change title > * Remove max_rx_pkt_len fix in ixgbe_ethdev.c > It's already fixed as part of Ferruh's changes in next-net branch, > so this part should be redundant, now > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c > index b263dfe..a51450f 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -5673,11 +5673,9 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev) > * ixgbevf_rlpml_set_vf even if jumbo frames are not used. This way, > * VF packets received can work in all cases. > */ > - if (ixgbevf_rlpml_set_vf(hw, frame_size) != 0) { > + if (ixgbevf_rlpml_set_vf(hw, frame_size) != 0) > PMD_INIT_LOG(ERR, "Set max packet length to %d failed.", > frame_size); > - return -EINVAL; > - } > > /* > * Assume no header split and no VLAN strip support >