[dpdk-dev] [PATCH] kni: bug fix in module_init and module_exit

[dpdk-dev] [PATCH] kni: bug fix in module_init and module_exit

[郭鹏飞]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=GBK, Size: 1796 bytes --]

From 932e33f33cf2a19ac5fa4295535b6b0e20c61890 Mon Sep 17 00:00:00 2001
From: Vincent Guo <guopengfei160@163.com>
Date: Thu, 25 Aug 2016 17:50:10 +0800
Subject: [PATCH] kni: bug fix in module_init and module_exit
 unregister_XXX should be called when module exits or error occurs
 during module init, but register_XXX is called in case that
 HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.


---
 lib/librte_eal/linuxapp/kni/kni_misc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
index 67e9b7d..d7850be 100644
--- a/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -194,7 +194,7 @@ out:
 #ifdef HAVE_SIMPLIFIED_PERNET_OPERATIONS
 unregister_pernet_subsys(&kni_net_ops);
 #else
-register_pernet_gen_subsys(&kni_net_id, &kni_net_ops);
+unregister_pernet_gen_subsys(kni_net_id, &kni_net_ops);
 #endif
 return rc;
 }
@@ -206,7 +206,7 @@ kni_exit(void)
 #ifdef HAVE_SIMPLIFIED_PERNET_OPERATIONS
 unregister_pernet_subsys(&kni_net_ops);
 #else
-register_pernet_gen_subsys(&kni_net_id, &kni_net_ops);
+unregister_pernet_gen_subsys(kni_net_id, &kni_net_ops);
 #endif
 KNI_PRINT("####### DPDK kni module unloaded  #######\n");
 }
-- 
1.7.1\x16º&¦f­ŠV¢­çaj×(™8n\x02è6ç]ùãM6Ó^‘zÛ«œö­†™š¶)ZŠ·…«\¢d^qè¯y×ë¢i±Ö·…«\¢i±Ö·…«\¢m´÷]ö×Íöñ¼¥Ù(®\x03è²×âÇ\b­„DŒLø\b\x1e\x05מ|õú+uëÝ¥Ù(®\x04á»n@º\r´×­wç4ûM´Ð!\x12M\x17œz+Þuúèš)í›\x1d=Š{fj)i®‡bžÚaÇjÞv\x16­r‰¢žÙ±Óا¶f¢–šèv)í¦\x1cv­çaj×(›]9×]¶ºÈ§2Ò¿]°ŠØ\Š˜^¬@ƒ\x1cDR\0\x01\x12Ûž†\bć\x03\x7f8Ûž¿Ûž›ŠÛ\r¡Ébz{\z»b~'\x1aµêު笵ç[Êlu­çaj×(˜ú,µø±Â+a\x11#\x13=(ß€6ã]ÃÓ´á»n@º\r´×­uç4ûM4ÑDÂEç\x1eŠ÷~º&²Šn–)(¶)ZŠÉ"j)ÞžŠà¾™õï_yjk6­çaj×(›]7ë½}å¼¢žÙ±Óا¶f¢–šèv)í¦\x1cv­çaj×(›Íxãÿ5ãŒ"¶\x11\x1213âvîÏ\x06¼\x1c¿Mv×~\x13†í¹\x02è6Ó^´ïù÷N4Ñ:\x05zºî…ˆ Š×Þ®»¡Ê("¶)ízW(˜§«zqèr\x19šžG«zxhr\x19šžX †×2mêÜ¢g^½Ú]’ŠàEçÞ­éÜzÀ€&­ÒC“Ã8rIžÃ

Re: [dpdk-dev] [PATCH] kni: bug fix in module_init and module_exit

[Ferruh Yigit]

Hi Vincent,

On 8/25/2016 12:45 PM, 郭鹏飞 wrote:
> From 932e33f33cf2a19ac5fa4295535b6b0e20c61890 Mon Sep 17 00:00:00 2001
> From: Vincent Guo <guopengfei160@163.com>
> Date: Thu, 25 Aug 2016 17:50:10 +0800
> Subject: [PATCH] kni: bug fix in module_init and module_exit
>  unregister_XXX should be called when module exits or error occurs
>  during module init, but register_XXX is called in case that
>  HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
> 

Patch content is good, thanks for the fix, but patch doesn't apply
cleanly (leading spaces are missing)
Also in commit log, Signed-off-by and Fixes tags are missing.

And commit log can be simpler, something like:
"Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set."

Would you mind sending a new version of the patch?

Thanks,
ferruh