From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 51CFB5686
 for <dev@dpdk.org>; Thu, 25 Aug 2016 18:19:22 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga105.jf.intel.com with ESMTP; 25 Aug 2016 09:19:21 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,576,1464678000"; d="scan'208";a="1020281932"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.30])
 ([10.237.221.30])
 by orsmga001.jf.intel.com with ESMTP; 25 Aug 2016 09:19:20 -0700
To: =?UTF-8?B?6YOt6bmP6aOe?= <guopengfei160@163.com>, dev@dpdk.org
References: <69010abb.168e5.156c18501db.Coremail.guopengfei160@163.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <57BF1A87.6030007@intel.com>
Date: Thu, 25 Aug 2016 17:19:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <69010abb.168e5.156c18501db.Coremail.guopengfei160@163.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] kni: bug fix in module_init and module_exit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Aug 2016 16:19:22 -0000

Hi Vincent,

On 8/25/2016 12:45 PM, 郭鹏飞 wrote:
> From 932e33f33cf2a19ac5fa4295535b6b0e20c61890 Mon Sep 17 00:00:00 2001
> From: Vincent Guo <guopengfei160@163.com>
> Date: Thu, 25 Aug 2016 17:50:10 +0800
> Subject: [PATCH] kni: bug fix in module_init and module_exit
>  unregister_XXX should be called when module exits or error occurs
>  during module init, but register_XXX is called in case that
>  HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
> 

Patch content is good, thanks for the fix, but patch doesn't apply
cleanly (leading spaces are missing)
Also in commit log, Signed-off-by and Fixes tags are missing.

And commit log can be simpler, something like:
"Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set."

Would you mind sending a new version of the patch?

Thanks,
ferruh