From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1A3DA0547; Thu, 25 Aug 2022 16:18:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84E7D410F2; Thu, 25 Aug 2022 16:18:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0D32240A7B for ; Thu, 25 Aug 2022 16:18:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661437123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I6Z9MxlwmKyZBrTq1DkRjHhKoP6u3thw0qhqziWI5/U=; b=LpV8HtSC5hUq3yKgVKW81STxfpzxmdP7A9ELX2n7Ocg1abpG+/7u0Nyqmn7Xz5bWXj8d5Y WNJk7A1JpLRI64VdVOdJ8DiFBZ5NVSWaRZROsktSXzQHBdAb1mDZ/+zXfE3gEwEwaI1Gwb wMAUvs9Ua/SIUEVSLp40w4XabGU9pZM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-3-4zyfEC96PKqloU3Rl6LjgQ-1; Thu, 25 Aug 2022 10:18:38 -0400 X-MC-Unique: 4zyfEC96PKqloU3Rl6LjgQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E7E43958320; Thu, 25 Aug 2022 14:18:37 +0000 (UTC) Received: from [10.39.208.44] (unknown [10.39.208.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF268945DF; Thu, 25 Aug 2022 14:18:35 +0000 (UTC) Message-ID: <57ad0b38-4d48-e174-5b4a-a42425098901@redhat.com> Date: Thu, 25 Aug 2022 16:18:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Nicolas Chautru , dev@dpdk.org, thomas@monjalon.net, gakhil@marvell.com, hemant.agrawal@nxp.com Cc: trix@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com, david.marchand@redhat.com, stephen@networkplumber.org References: <1655491040-183649-6-git-send-email-nicolas.chautru@intel.com> <1657150110-69957-1-git-send-email-nicolas.chautru@intel.com> <1657150110-69957-3-git-send-email-nicolas.chautru@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v5 2/7] bbdev: add device status info In-Reply-To: <1657150110-69957-3-git-send-email-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/7/22 01:28, Nicolas Chautru wrote: > Added device status information, so that the PMD can > expose information related to the underlying accelerator device status. > Minor order change in structure to fit into padding hole. > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 1 + > drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 1 + > drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 1 + > drivers/baseband/la12xx/bbdev_la12xx.c | 1 + > drivers/baseband/null/bbdev_null.c | 1 + > drivers/baseband/turbo_sw/bbdev_turbo_software.c | 1 + > lib/bbdev/rte_bbdev.c | 22 ++++++++++++++ > lib/bbdev/rte_bbdev.h | 35 ++++++++++++++++++++-- > lib/bbdev/version.map | 6 ++++ > 9 files changed, 67 insertions(+), 2 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index de7e4bc..17ba798 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -1060,6 +1060,7 @@ > > /* Read and save the populated config from ACC100 registers */ > fetch_acc100_config(dev); > + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > /* This isn't ideal because it reports the maximum number of queues but > * does not provide info on how many can be uplink/downlink or different > diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > index 82ae6ba..57b12af 100644 > --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > @@ -369,6 +369,7 @@ > dev_info->capabilities = bbdev_capabilities; > dev_info->cpu_flag_reqs = NULL; > dev_info->data_endianness = RTE_LITTLE_ENDIAN; > + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > /* Calculates number of queues assigned to device */ > dev_info->max_num_queues = 0; > diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c > index 21d3529..2a330c4 100644 > --- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c > +++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c > @@ -645,6 +645,7 @@ struct __rte_cache_aligned fpga_queue { > dev_info->capabilities = bbdev_capabilities; > dev_info->cpu_flag_reqs = NULL; > dev_info->data_endianness = RTE_LITTLE_ENDIAN; > + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > /* Calculates number of queues assigned to device */ > dev_info->max_num_queues = 0; > diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c > index 4d1bd16..c1f88c6 100644 > --- a/drivers/baseband/la12xx/bbdev_la12xx.c > +++ b/drivers/baseband/la12xx/bbdev_la12xx.c > @@ -100,6 +100,7 @@ struct bbdev_la12xx_params { > dev_info->capabilities = bbdev_capabilities; > dev_info->cpu_flag_reqs = NULL; > dev_info->min_alignment = 64; > + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > rte_bbdev_log_debug("got device info from %u", dev->data->dev_id); > } > diff --git a/drivers/baseband/null/bbdev_null.c b/drivers/baseband/null/bbdev_null.c > index 248e129..94a1976 100644 > --- a/drivers/baseband/null/bbdev_null.c > +++ b/drivers/baseband/null/bbdev_null.c > @@ -82,6 +82,7 @@ struct bbdev_queue { > * here for code completeness. > */ > dev_info->data_endianness = RTE_LITTLE_ENDIAN; > + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > rte_bbdev_log_debug("got device info from %u", dev->data->dev_id); > } > diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > index af7bc41..dbc5524 100644 > --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c > +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > @@ -254,6 +254,7 @@ struct turbo_sw_queue { > dev_info->min_alignment = 64; > dev_info->harq_buffer_size = 0; > dev_info->data_endianness = RTE_LITTLE_ENDIAN; > + dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > rte_bbdev_log_debug("got device info from %u\n", dev->data->dev_id); > } > diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c > index 4da8047..38630a2 100644 > --- a/lib/bbdev/rte_bbdev.c > +++ b/lib/bbdev/rte_bbdev.c > @@ -1133,3 +1133,25 @@ struct rte_mempool * > rte_bbdev_log(ERR, "Invalid operation type"); > return NULL; > } > + > +const char * > +rte_bbdev_device_status_str(enum rte_bbdev_device_status status) > +{ > + static const char * const dev_sta_string[] = { > + "RTE_BBDEV_DEV_NOSTATUS", > + "RTE_BBDEV_DEV_NOT_SUPPORTED", > + "RTE_BBDEV_DEV_RESET", > + "RTE_BBDEV_DEV_CONFIGURED", > + "RTE_BBDEV_DEV_ACTIVE", > + "RTE_BBDEV_DEV_FATAL_ERR", > + "RTE_BBDEV_DEV_RESTART_REQ", > + "RTE_BBDEV_DEV_RECONFIG_REQ", > + "RTE_BBDEV_DEV_CORRECT_ERR", > + }; > + > + if (status < sizeof(dev_sta_string) / sizeof(char *)) > + return dev_sta_string[status]; > + > + rte_bbdev_log(ERR, "Invalid device status"); > + return NULL; > +} > diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h > index b88c881..9b1ffa4 100644 > --- a/lib/bbdev/rte_bbdev.h > +++ b/lib/bbdev/rte_bbdev.h > @@ -223,6 +223,21 @@ struct rte_bbdev_queue_conf { > int > rte_bbdev_queue_stop(uint16_t dev_id, uint16_t queue_id); > > +/** > + * Flags indicate the status of the device > + */ > +enum rte_bbdev_device_status { > + RTE_BBDEV_DEV_NOSTATUS, /**< Nothing being reported */ > + RTE_BBDEV_DEV_NOT_SUPPORTED, /**< Device status is not supported on the PMD */ > + RTE_BBDEV_DEV_RESET, /**< Device in reset and un-configured state */ > + RTE_BBDEV_DEV_CONFIGURED, /**< Device is configured and ready to use */ > + RTE_BBDEV_DEV_ACTIVE, /**< Device is configured and VF is being used */ > + RTE_BBDEV_DEV_FATAL_ERR, /**< Device has hit a fatal uncorrectable error */ > + RTE_BBDEV_DEV_RESTART_REQ, /**< Device requires application to restart */ > + RTE_BBDEV_DEV_RECONFIG_REQ, /**< Device requires application to reconfigure queues */ > + RTE_BBDEV_DEV_CORRECT_ERR, /**< Warning of a correctable error event happened */ > +}; I don't have a strong opinion on this, but I think NOT_SUPPORTED should be a special value. If you want to keep 0 value for NOSTATUS, maybe you could do: enum rte_bbdev_device_status { RTE_BBDEV_DEV_NOT_SUPPORTED = -1, /**< Device status is not supported on the PMD */ RTE_BBDEV_DEV_NOSTATUS = 0, /**< Nothing being reported */ RTE_BBDEV_DEV_RESET, /**< Device in reset and un-configured state */ ... > + > /** Device statistics. */ > struct rte_bbdev_stats { > uint64_t enqueued_count; /**< Count of all operations enqueued */ > @@ -285,12 +300,14 @@ struct rte_bbdev_driver_info { > /** Set if device supports per-queue interrupts */ > bool queue_intr_supported; > /** Minimum alignment of buffers, in bytes */ > - uint16_t min_alignment; > - /** HARQ memory available in kB */ > + /** Device Status */ > + enum rte_bbdev_device_status device_status; > uint32_t harq_buffer_size; > /** Byte endianness (RTE_BIG_ENDIAN/RTE_LITTLE_ENDIAN) supported > * for input/output data > */ > + uint16_t min_alignment; > + /** HARQ memory available in kB */ > uint8_t data_endianness; > /** Default queue configuration used if none is supplied */ > struct rte_bbdev_queue_conf default_queue_conf; > @@ -827,6 +844,20 @@ typedef void (*rte_bbdev_cb_fn)(uint16_t dev_id, > rte_bbdev_queue_intr_ctl(uint16_t dev_id, uint16_t queue_id, int epfd, int op, > void *data); > > +/** > + * Converts device status from enum to string > + * > + * @param status > + * Device status as enum > + * > + * @returns > + * Operation type as string or NULL if op_type is invalid > + * > + */ > +__rte_experimental > +const char* > +rte_bbdev_device_status_str(enum rte_bbdev_device_status status); > + > #ifdef __cplusplus > } > #endif > diff --git a/lib/bbdev/version.map b/lib/bbdev/version.map > index cce3f3c..9ac3643 100644 > --- a/lib/bbdev/version.map > +++ b/lib/bbdev/version.map > @@ -39,3 +39,9 @@ DPDK_22 { > > local: *; > }; > + > +EXPERIMENTAL { > + global: > + We now add the version the new API was introduced in as a comment: # added in 22.11 > + rte_bbdev_device_status_str; > +};