From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E965EA0032; Fri, 15 Jul 2022 15:17:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A32C440A87; Fri, 15 Jul 2022 15:17:02 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 0D8F540696 for ; Fri, 15 Jul 2022 15:17:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657891021; x=1689427021; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=H/vdudHGntaCYxVL+tVMwjnTDQknUkOW4mWWabQdXDc=; b=LYXxruDGJLFaJX5wP74U6WFlhU0Uzdl55Xqop3YEGz7SMGVP9mBdn1uw JDqZ1CDK/OILY9RHUvuZz1lhbvInWGFG7RKnust3xsk/7Tyizo5zuwXtN YuuI1wl0VFhF7psG+JOnfsPzdUbAPqc3pBdz1ad9QmlKsUuh2BOSVZ56j vMKW8By7Y77wnL2/DIQBfHlHhRL2RvmNXQcMXsyytgqym1yJLyhhaB8in cul3zjtirLTet/5eHIWPWXTvgig39rIUCmG9oruvqpsGohuOEvSGXkppE pP9/Of5ai+MhvGa0CcJM6p+OUkeEo0grj8LwRmQoiC68m6SGvJMsF7d4t g==; X-IronPort-AV: E=McAfee;i="6400,9594,10408"; a="347467917" X-IronPort-AV: E=Sophos;i="5.92,274,1650956400"; d="scan'208";a="347467917" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2022 06:16:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,274,1650956400"; d="scan'208";a="664185645" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 15 Jul 2022 06:16:59 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 15 Jul 2022 06:16:59 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 15 Jul 2022 06:16:59 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 15 Jul 2022 06:16:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UiMpZFaynBD0JuZbsIWgSrjmFq7G+S7YgIQlhHVIxvF5/bf+SJjpBKjaZgn+LnAD9V5TnT1KcchOQXryBoV4As8vNjSPhxwzFIakmv4RzNb+MRWjjlScNDDhdMGTWHAdAUGL/iQgqS/hggoWSAky4vw5Fnv8T6uKT5K/bp+OX1XAvjGjjrcTdsvhvK0bGg7MLjYzKezkhvQXMrPxG9RF02M0Mec3dLTBaKJmrbIVHgMVw5dVT6MmCKPpzS1ncUW8je4Yl6QVZOH1dpDtAcaej1F0ZdbtgjvBQ49xIbg00a4b/MiMaS4Mu2yoP2s1SY5n+QTv2BnEw/QbdTqU0l/F+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bbRe4mtJVdvLpTlWWkpaVRH1qrGv1zbXihTUZR8lfvU=; b=VGQttFDo+Hw+B8bH/mOEKXbzzT45w7haBcaS34e5BJBM5JH3vOHi9i688xs5v6yp51M4e3xOGCxla9p4X9EgJSw1ETRbRm7TE4K9x6zkWIsUp2C/PIVuOnJqEm+c4ogfvhaC7xd2g2cXDnwZK2i+ynYFTxfzt7iYRLD/jGaGce1S76H255lSYnOCfY5J3ESmucoHgFve6ffLRJcwrKWe8V0j0IIEiGkN6i+pXc9nzUVX6bran7g4ZEOeCsUaxqx73p2nehplnKquWgu9P47wbO/i++wYiNOfs3WWSJThF6ih9kG4KH40EZgE7PpjW8GU/e0xRIheh0IsEQMovbuMiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BN6PR11MB1251.namprd11.prod.outlook.com (2603:10b6:404:48::10) by DM8PR11MB5669.namprd11.prod.outlook.com (2603:10b6:8:36::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 15 Jul 2022 13:16:57 +0000 Received: from BN6PR11MB1251.namprd11.prod.outlook.com ([fe80::128:8fb:9d0:1a9f]) by BN6PR11MB1251.namprd11.prod.outlook.com ([fe80::128:8fb:9d0:1a9f%8]) with mapi id 15.20.5417.029; Fri, 15 Jul 2022 13:16:57 +0000 Message-ID: <57cacb40-2b60-b387-5236-8a433ea7adc4@intel.com> Date: Fri, 15 Jul 2022 14:16:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [20.11 PATCH v1 1/2] eal: add lcore busyness telemetry Content-Language: en-US From: "Burakov, Anatoly" To: , Bruce Richardson , "Nicolas Chautru" , Fiona Trahe , Ashish Gupta , Declan Doherty , David Hunt , Ray Kinsella , Neil Horman , Thomas Monjalon , Ferruh Yigit , "Andrew Rybchenko" , Jerin Jacob , Nipun Gupta , Hemant Agrawal , Ori Kam , Honnappa Nagarahalli , Konstantin Ananyev CC: Kevin Laatz , Conor Walsh References: In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0360.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::23) To BN6PR11MB1251.namprd11.prod.outlook.com (2603:10b6:404:48::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 77d7c1dc-0693-4d47-077b-08da66644b32 X-MS-TrafficTypeDiagnostic: DM8PR11MB5669:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4lL+7qSDez9cu8s2ApL4/yifIymDBRpacska81xLRucWnASf3cHl1PIHy+NtwWmYsvXFTqPZMK96Mvy4pkJguR7fMLIYJoLvoUjeRL2woYgvo4uDsp593gswNpZ7wJEmBvOvtLw7svUO8oYgLzoKA5x0VGV3JSjPY9Do/NVl1+ttPqIS5Izhg4v/n9DB5B6laWIXcYcbMiS4MrzuGE1EiJJidz7gocXaPouK4xnsdn6fB0eia9jkLrasTv1WFodYqPjvuIClmqse+1k3zPjjhtVz3ZBFlTx4fwxiLkfiqGEYEmTmC2ksONt2kV5snyqZBq7m3ivZTL5eaNObsV8rFreXyaRZOfvMQrSYszS5cJl0/NjfBpTcMm71ig4kgkwU/o38T8GVEblmTsmymJX/ZD9N8/WGTvN7italGGPHN9DXKbgQ3kNwjZEucyVfPqLCKPl2RVGDJjML8RthTnfhY0RO/XusMHX5870oH0uYbDamVnNnpj9yi2e7ZHkW4lJWPTM5U/fTIyoFLmW0yufdZqW/OhuDHQoyuCgkqEm8pw5kb582kAq5yWEBtIoBzBfNaLfhNmagN6JjPTMqE7neFdmZtPvb6jCHNZskoB62DTIhyt2PlxJmksxa4yJUjWJR3vcSw59Zk8jxLpaHAOkhakGFOeh32bJkfoiD7iD/4VOyLKQrT/0KBVGcog3kzSIfHNq9pVti0oy9uYbINM+x1G7YhdHZqeUZ47MSyplWPQ8Bn8BFkahiun1Fc2pjcUwK4O1lbkMhXaFbyhx+mGlcYf22KHW+PD49TllMQIg8KwERkQYd2CQo1ZzgpDSdiN7Q0q2mvP3WMgBvPt+4of0TS8YxAMHPaJm5wvRpwORDGZ2tBwXyuUBYsRr5nmkh2Op7 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1251.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(39860400002)(346002)(376002)(136003)(366004)(6506007)(921005)(478600001)(82960400001)(6486002)(2906002)(83380400001)(316002)(36756003)(54906003)(8676002)(186003)(110136005)(7416002)(8936002)(4326008)(6512007)(5660300002)(86362001)(66556008)(31686004)(66946007)(107886003)(2616005)(6666004)(41300700001)(66476007)(38100700002)(31696002)(26005)(6636002)(53546011)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXA1MTBxQjRxMGhEcHgrMm1Ua0NLdEdERC9McFAxZUhzd0IrZHJTbUoyYXEw?= =?utf-8?B?aHAwOEROdUtOS2M0SDIzY21WQXVOVkhmQWVZK0JxU3JXb1l0ZXY2OE1EbzMy?= =?utf-8?B?ZHhrUkRCK0pJNzlsK0Rud0xGeWlocXkwSmFSMWdyZ3pYYzJucWJBQXFqTkZ6?= =?utf-8?B?QXZ2YjRJSGdmYTBFdEtyVlZaa3Q0bklLOTJWalUxWE1BRkhLY1hJaGloTzRa?= =?utf-8?B?WEVZbktQOHZCanp4R001TUpjYWl1K1NseXcrN0U5eVc5NitOZHg3R05aUEdJ?= =?utf-8?B?ZUdIOFo5TnBqcXVFVnZyUTJ1UytLcGtKZVQ1citWVkZJWnorTjBhaVJWOWZ3?= =?utf-8?B?QlljWkNlaFNoM1RvUkdrZFppVHRma2N5TjZodCtKaXBWN0V6OUt5bTFSaDFX?= =?utf-8?B?Q25DVXJMOEpPczZYU1Y1T0cyQ0FwZmVzemVHQ250ZTNnb1Z2Z3pVVC80cDRl?= =?utf-8?B?V21iY2lOVHBmMm1JaHZMMHA2RWJZQVJUN3g3Zk9yMExIR1dXL2E0a0tjUTFS?= =?utf-8?B?ZlVBQjNjeERNanJ3SldWVnkwZ2NJOSthSnNlaWF6K0pNS0pnYzF6M1FickJS?= =?utf-8?B?ZGZQM2FMUFdNQVYvVlcxbTNIZEZOdmFiM2VPV2J4ZFRqMmRKZlpKR1k1WGd5?= =?utf-8?B?aVIzd3ovV2lKNCt5Q0pOTEk1ZmhxSllhOGtmcFlJakFCNzhjL1pZOE1wNmJF?= =?utf-8?B?eStLQlJsbklNQU53MmFMUDZMbEZuaDJUQ0Z2YjBFWGlTTDk4NTMxVFAzamNX?= =?utf-8?B?VlVwQXBiZTcwblhHSnR0TnplaVFSZ2pOWlVTSlQyVWlCazJJY2xTU1EwYkZy?= =?utf-8?B?UzRuNytMVm1rZlZyQy9RM2wzNnpOaysvdDVGWVQ0VnFBeXBWSFc2VEE5SGJu?= =?utf-8?B?ZkpkU3ZGa3pqKy9FeldOVEwza1hhWFhkRkwrN1QvWUtQVngra3JudzJEbFM5?= =?utf-8?B?Y2hQTDlXeXZMZEVNY3JPTWtud2ZKSEMzSFFhbzZna0NGQnB1NXlOVEc1YmNP?= =?utf-8?B?Vnc5Rk5CM2h5RXVSUlFoZW9XU1JWRVpOYkt2ZDdBRzVFVHRtUVJDZmNad1Vn?= =?utf-8?B?TzR1cUpFRzB0MGVSZCtrdFRHTVdwWG1KNXRGMHdST0RvOUFnLzZldDJLZ3FR?= =?utf-8?B?eEZ0QlNnbHRzcW01MTN0b2RKMERVVjNkRklwMHl1TmJBTkVvMXcwQTloN2Nx?= =?utf-8?B?NWlzb0dGd09kdUtHK2F4NXBWWGE3UGhGYStBbTFRSU5uWEY1bXpqdnltVWZl?= =?utf-8?B?bGlsZVlUcTg1eU1tOWh4WWw3a284K1A2OGFKbDVJSHkyVjBPTlFab3Z3WVV6?= =?utf-8?B?a2JoS1BDVlduVkY4L0JXb2dpSWN2RkxLMkhkMGFrSmpWck1oMm40SVcvV2t6?= =?utf-8?B?TkxBM0kxLzRnQ2l5c2tJalcwK2ljeHkxelFaRTRhS2tSeVY1OWNiY3V3MXUw?= =?utf-8?B?NDNLSWtuZUhRVWMzOG5wS2xQWGpFMlV1eGE5TzhNSFJabXpEOXlNTnZuRWRH?= =?utf-8?B?bjhhOTZQRkVrRGFpSk8yTmkzbXRiQ2J1TWNwbmZhRnB0dFJrYnhNbU9DZFl1?= =?utf-8?B?a2wvcGlzaUJpcS81bWlNQXFsSVAvY08va0tvWjRCUVJ6MGI5ekJqN1gzc3Jj?= =?utf-8?B?SUh4SGRiMEcxQWdpT1F2cWV4QTQ4dVNRYkNFcDN2Y2NQV0xsd3lGN2dpM0Ez?= =?utf-8?B?dHNZWHBRZHoyUnpPbHBwa0pnSG5vU29rNjVjUlRyNVdaaWR0SDJBQnlHOStS?= =?utf-8?B?K0hFcXhsUm9BUm10TFFuOXYvTXlmdzFrVEFZVjBpYkNrcVRVNS96ZjlHaDBr?= =?utf-8?B?SUkxSVp3UFFxOGcwbE5OKzJoT3RmQ1UrcytQZk9pNSt2NS9oeWt4bWtwbmta?= =?utf-8?B?RmZzSExtQm9CbkJ6NjlEMkJmekxLQkJnUHU5WU8vRUwyd2NGVVh2OXdXMlpq?= =?utf-8?B?NFdSTWU1ZUtpYUFnQlY1RlRlelJla21uZ0EydkF6VlFvZXFWN0RQVkx2b1JP?= =?utf-8?B?WnJkbmZDVkVDcGp6TElJK0s3YlEyejBTSXJYSUtiYnpuQmlmdnNNaHNiR1B5?= =?utf-8?B?QXZlT1NRbWF4OTNEM3lhTmJhVDllbWw4N2NrQkMzT3lhUURzVW9PdER3bEVT?= =?utf-8?B?YjByVW1WR2hVQkpIL0dJMVhFRjFNN0VKYU0xQloxQUptTU12YnUrNGZqQUU1?= =?utf-8?B?OUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 77d7c1dc-0693-4d47-077b-08da66644b32 X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1251.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 13:16:57.3335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rwUaBJZmUwcXLiw+C8iKkMCYCVqqRsepNNidBekEysnywqmmt1qeMPwl2sd/o7Dkm/MDM96Qdpz8wQWO3V0AIGZ04g3CIqoMtVOgYuT7P8M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5669 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 15-Jul-22 2:12 PM, Anatoly Burakov wrote: > Currently, there is no way to measure lcore busyness in a passive way, > without any modifications to the application. This patch adds a new EAL > API that will be able to passively track core busyness. > > The busyness is calculated by relying on the fact that most DPDK API's > will poll for packets. Empty polls can be counted as "idle", while > non-empty polls can be counted as busy. To measure lcore busyness, we > simply call the telemetry timestamping function with the number of polls > a particular code section has processed, and count the number of cycles > we've spent processing empty bursts. The more empty bursts we encounter, > the less cycles we spend in "busy" state, and the less core busyness > will be reported. > > In order for all of the above to work without modifications to the > application, the library code needs to be instrumented with calls to > the lcore telemetry busyness timestamping function. The following parts > of DPDK are instrumented with lcore telemetry calls: > > - All major driver API's: > - ethdev > - cryptodev > - compressdev > - regexdev > - bbdev > - rawdev > - eventdev > - Some additional libraries: > - ring > - distributor > > To avoid performance impact from having lcore telemetry support, a > global variable is exported by EAL, and a call to timestamping function > is wrapped into a macro, so that whenever telemetry is disabled, it only > takes one additional branch and no function calls are performed. It is > also possible to disable it at compile time by commenting out > RTE_LCORE_BUSYNESS from build config. > > This patch also adds a telemetry endpoint to report lcore busyness, as > well as telemetry endpoints to enable/disable lcore telemetry. > > Signed-off-by: Kevin Laatz > Signed-off-by: Conor Walsh > Signed-off-by: David Hunt > Signed-off-by: Anatoly Burakov > --- These patches are to be applied on top of 20.11, so please ignore this patchset. I've already marked it as "Not Applicable" in patchwork. -- Thanks, Anatoly