From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D7ED91B7C8 for ; Fri, 13 Apr 2018 11:16:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2018 02:16:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,444,1517904000"; d="scan'208";a="33381380" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by orsmga008.jf.intel.com with ESMTP; 13 Apr 2018 02:16:19 -0700 To: Arnon Warshavsky , thomas@monjalon.net, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org References: <1522879294-8803-1-git-send-email-arnon@qwilt.com> From: "Burakov, Anatoly" Message-ID: <57cadbf8-26b4-d449-6c06-5ff2fe92c12f@intel.com> Date: Fri, 13 Apr 2018 10:16:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1522879294-8803-1-git-send-email-arnon@qwilt.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 00/13] eal: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 09:16:24 -0000 On 04-Apr-18 11:01 PM, Arnon Warshavsky wrote: > > The purpose of this patch series is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation of the event. > > This patch modifies the majority of rte_panic calls > under lib and drivers, and replaces them with a log message > and an error return code according to context, > that can be propagated up the call stack. > > - Focus was given to the dpdk initialization path > - Some of the panic calls within drivers were left in place where > the call is from within an interrupt or calls that are > on the data path,where there is no simple applicative > route to propagate the error to temination. > These should be handled by the driver maintainers. > - In order to avoid breaking ABI where panic was called from public > void functions, a panic state variable was introduced so that > it can be queried after calling these void functions. > This tool place for a single function call. > - local void functions with no api were changed to retrun a value > where needed > - No change took place in example and test files > - No change took place for debug assertions calling panic > - A new function was added to devtools/checkpatches.sh > in order to prevent new additions of calls to rte_panic > under lib and drivers. > > Keep calm and don't panic > > --- > > v2: > - reformat error messages so that literal string are in the same line > - fix typo in commit message > - add new return code to doxigen of rte_memzone_free() Hi Arnon, When sending new versions, the entire patchset must be sent. It makes it easier for maintainers to apply patches this way. -- Thanks, Anatoly