DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	dev@dpdk.org, phil.yang@arm.com, thomas@monjalon.net,
	arybchenko@solarflare.com,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Cc: abhinandan.gujjar@intel.com, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH 1/2] lib/ethdev: replace full barrier with relaxed barrier
Date: Tue, 13 Oct 2020 11:30:14 +0100
Message-ID: <57cf008a-3e99-3fc7-1cc6-23455c2851e8@intel.com> (raw)
In-Reply-To: <20201002000711.41511-1-honnappa.nagarahalli@arm.com>

On 10/2/2020 1:07 AM, Honnappa Nagarahalli wrote:
> From: Phil Yang <phil.yang@arm.com>
> 
> While registering the call back functions full write barrier
> can be replaced with one-way write barrier.
> 
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

+Konstantin & Jerin,

Can you please help reviewing this patch?

> ---
>   lib/librte_ethdev/rte_ethdev.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 7858ad5f1..59a41c07f 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -26,7 +26,6 @@
>   #include <rte_eal.h>
>   #include <rte_per_lcore.h>
>   #include <rte_lcore.h>
> -#include <rte_atomic.h>
>   #include <rte_branch_prediction.h>
>   #include <rte_common.h>
>   #include <rte_mempool.h>
> @@ -4527,8 +4526,12 @@ rte_eth_add_first_rx_callback(uint16_t port_id, uint16_t queue_id,
>   	rte_spinlock_lock(&rte_eth_rx_cb_lock);
>   	/* Add the callbacks at first position */
>   	cb->next = rte_eth_devices[port_id].post_rx_burst_cbs[queue_id];
> -	rte_smp_wmb();
> -	rte_eth_devices[port_id].post_rx_burst_cbs[queue_id] = cb;
> +	/* Stores to cb->fn, cb->param and cb->next should complete before
> +	 * cb is visible to data plane threads.
> +	 */
> +	__atomic_store_n(
> +		&rte_eth_devices[port_id].post_rx_burst_cbs[queue_id],
> +		cb, __ATOMIC_RELEASE);
>   	rte_spinlock_unlock(&rte_eth_rx_cb_lock);
>   
>   	return cb;
> 


  parent reply	other threads:[~2020-10-13 10:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02  0:07 Honnappa Nagarahalli
2020-10-02  0:07 ` [dpdk-dev] [PATCH 2/2] lib/ethdev: fix memory ordering for call back functions Honnappa Nagarahalli
2020-10-09  2:34   ` Phil Yang
2020-10-13 10:32   ` Ferruh Yigit
2020-10-13 15:25     ` Honnappa Nagarahalli
2020-10-13 14:25   ` Ananyev, Konstantin
2020-10-13 10:30 ` Ferruh Yigit [this message]
2020-10-13 14:24 ` [dpdk-dev] [PATCH 1/2] lib/ethdev: replace full barrier with relaxed barrier Ananyev, Konstantin
2020-10-13 16:25 ` [dpdk-dev] [PATCH v2 " Honnappa Nagarahalli
2020-10-13 16:25   ` [dpdk-dev] [PATCH v2 2/2] lib/ethdev: fix memory ordering for call back functions Honnappa Nagarahalli
2020-10-14 16:36   ` [dpdk-dev] [PATCH v2 1/2] lib/ethdev: replace full barrier with relaxed barrier Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57cf008a-3e99-3fc7-1cc6-23455c2851e8@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=abhinandan.gujjar@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jerinj@marvell.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=phil.yang@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git