From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DC0FA0A0C; Thu, 1 Jul 2021 10:34:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D26740141; Thu, 1 Jul 2021 10:34:08 +0200 (CEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 4781740040 for ; Thu, 1 Jul 2021 10:34:06 +0200 (CEST) Received: by mail-wr1-f50.google.com with SMTP id u8so7054806wrq.8 for ; Thu, 01 Jul 2021 01:34:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=4bd0pv0h3VOciN7mktizEHZGIvbh9Ch5lih+hBV2ILA=; b=G5s+wpb5xeFiEv6JZHkFkf97c+20IOTlHfWB+TywbdL4ZfEHO21yx7OAjgxDMxcTXV rS7VH33lbLv++Yc0iXiJBYQKmrEjYceEHS0a1bnG1g8gEP6Fg9goowFnaLDWKqqoDrTW a8WGLFSwL5mMX+mVXAEoafXsonMWK/SGqrYwOB6Ne7AYMVq5mf3TLEWdOyjF3yl3jItY k2nwltEhPYAffmAiT0qTNevXvdBTwlUCFnqDWeOxyy++oygNjIzWzvCJpkcBpndTB8Rx w3XQ+vW1alj9Xg8k23Yjyg+R2eSWR6lXEgIPJDLyeVWCf2uIKsoRtal66FQVpKIyChq8 a/kw== X-Gm-Message-State: AOAM531ZFQFL+XssD0Pj9MV23oOhAy79M3e/9+QO2OwMKiJxPiNMc5DP GuymeglN28j944oarb8hcKE= X-Google-Smtp-Source: ABdhPJz71x09XJxY9Iczv1NcGzjKfnkwoWuALKP4irRsF/S/65HE2NUKFbPfA49Hn3R0jtxsXEr3pw== X-Received: by 2002:a05:6000:120e:: with SMTP id e14mr24671939wrx.139.1625128446066; Thu, 01 Jul 2021 01:34:06 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id j4sm9641523wra.1.2021.07.01.01.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 01:34:05 -0700 (PDT) Message-ID: <57d6b6a0808b899e6b23cd204a1018d519326fd0.camel@debian.org> From: Luca Boccassi To: Dmitry Kozlyuk , dev@dpdk.org Cc: Bruce Richardson , Rob Scheepens Date: Thu, 01 Jul 2021 09:34:04 +0100 In-Reply-To: <20210630162235.267285-1-dmitry.kozliuk@gmail.com> References: <20210630162235.267285-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: fix build on Windows with meson 0.58 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote: > The `doc` target used `echo` as its command. > On Windows, `echo` is always a shell built-in, there is no binary. > Starting from meson 0.58, `run_target()` always searches for command > executable and no longer accepts `echo` as such on Windows. > Replace plain `echo` with a Python one-liner. >=20 > Fixes: d02a2dab2dfb ("doc: support building HTML guides with meson") > Cc: Bruce Richardson > Cc: Luca Boccassi > Cc: stable@dpdk.org >=20 > Reported-by: Rob Scheepens > Signed-off-by: Dmitry Kozlyuk > --- > Sorry for the noise, sent to stable@ instead of dev@ first. >=20 > doc/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/meson.build b/doc/meson.build > index 959606b965..abd7d70421 100644 > --- a/doc/meson.build > +++ b/doc/meson.build > @@ -11,5 +11,6 @@ if doc_targets.length() =3D=3D 0 > else > message =3D 'Building docs:' > endif > -run_target('doc', command: ['echo', message, doc_target_names], > +echo =3D [py3, '-c', 'import sys; print(*sys.argv[1:])'] > +run_target('doc', command: [echo, message, doc_target_names], > depends: doc_targets) Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi