From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08D30A0A0E; Wed, 28 Apr 2021 13:32:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5F9541299; Wed, 28 Apr 2021 13:32:29 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 2348F41299 for ; Wed, 28 Apr 2021 13:32:27 +0200 (CEST) IronPort-SDR: vlIySLJuCMJCVfDqND//JgT5VdZn3/rCUlbobzGLhXgm/LoSxDWyv0oMNdC6fugRraDbTsxXGT 1ulae+xkNAsg== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="176831927" X-IronPort-AV: E=Sophos;i="5.82,258,1613462400"; d="scan'208";a="176831927" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 04:32:27 -0700 IronPort-SDR: zgvr1PO9/j4nX8KP0LjAvNasAXfQbZAWHbFxkK8jvqusMZZFrSRfItA28HRgPJsgovTHA0yQm3 1X/rkQgEpiWw== X-IronPort-AV: E=Sophos;i="5.82,258,1613462400"; d="scan'208";a="423494127" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.177]) ([10.213.241.177]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 04:32:26 -0700 To: "Zhang, Qi Z" , "Lu, Wenzhuo" , "dev@dpdk.org" References: <1619414983-131070-1-git-send-email-wenzhuo.lu@intel.com> <0e87d690425949c3839a1ac48dc0406b@intel.com> <0cff5b06a6294e5e9cad58e71553d11d@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <57dfdc8f-6c2d-746d-9404-76c87e429e69@intel.com> Date: Wed, 28 Apr 2021 12:32:25 +0100 MIME-Version: 1.0 In-Reply-To: <0cff5b06a6294e5e9cad58e71553d11d@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/2021 3:57 AM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Lu, Wenzhuo >> Sent: 2021年4月27日 9:51 >> To: Zhang, Qi Z ; dev@dpdk.org >> Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix performance drop >> >>>> +use_sse = true; >>>> +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 || >>>> + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) && >>>> + rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256) >>>> +use_avx2 = true; >>> >>> >>> Not sure if the right path will be selected when avx512 is not true, >>> (CC_AVX512_SUPPORT is disable) while check_ret is >>> IAVF_VECTOR_OFFLOAD_PATH? >>> >>> Currently we have >>> >>> if (!use_sse && !use_avx2 && !use_avx512) goto normal; >>> >>> Should we also add below check? >>> >>> if (!use_avx512 && check_ret == IAVF_VECTOR_OFFLOAD_PATH) >>> goto normal; >> Not necessary. As explained in the commit log, AVX2 and SSE support the >> offload features. The purpose of this patch is to let AVX2 be chosen when >> offload needed and AVX512 disable. > > OK, now I understand it, I will suggest to change the commit log. > > From > AVX2 and SSE don't have the offload path. > > To > AVX2 and SSE Tx path already support offloads but can't selected. > Isn't this related to the _Rx_ path? > If you agree, will apply above during change during patch merge. >