From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DA42A09EF; Wed, 16 Dec 2020 14:52:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A82FEC9A0; Wed, 16 Dec 2020 14:52:47 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 48F8DC99E for ; Wed, 16 Dec 2020 14:52:46 +0100 (CET) IronPort-SDR: aTQNWU2LQfrIreUuQR2JxUM/9VijkmFMJDNJ7iZVHyzcfgFio42P0TH6UPcv2XIk9u4PaTH/Ra t8x5nRRxrBhg== X-IronPort-AV: E=McAfee;i="6000,8403,9836"; a="236645176" X-IronPort-AV: E=Sophos;i="5.78,424,1599548400"; d="scan'208";a="236645176" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 05:52:44 -0800 IronPort-SDR: 57O3r7ecn+/nPuQVVURpg+Fs+d2DrRpGLRzyET6phbCSjgrs6FvwrDQGpOWPD85LFH7hU1nsqe WgK/VZnTXTSA== X-IronPort-AV: E=Sophos;i="5.78,424,1599548400"; d="scan'208";a="369081699" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.233.132]) ([10.213.233.132]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 05:52:42 -0800 To: Liron Himi Cc: "dev@dpdk.org" , Luca Boccassi , Kevin Traynor , Akhil Goyal References: <20201202130529.7332-2-lironh@marvell.com> <20201215222319.13816-1-lironh@marvell.com> From: Ferruh Yigit Message-ID: <57e2bee8-d74a-6c88-f535-24bc1d18b25e@intel.com> Date: Wed, 16 Dec 2020 13:52:40 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] meson: update meson build for armada drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/16/2020 1:41 PM, Liron Himi wrote: > > -----Original Message----- > From: Ferruh Yigit > Sent: Wednesday, 16 December 2020 15:37 > To: Liron Himi > Cc: dev@dpdk.org; Luca Boccassi ; Kevin Traynor ; Akhil Goyal > Subject: [EXT] Re: [PATCH v2] meson: update meson build for armada drivers > > External Email > > ---------------------------------------------------------------------- > On 12/15/2020 10:23 PM, lironh@marvell.com wrote: >> From: Liron Himi >> >> With pkg-config support available within musdk library (from >> musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' >> can be removed. >> PKG_CONFIG_PATH environment variable should be set appropriately to >> use the musdk library. > > Hi Liron, > > It is good change to get rid of an custom meson option, can we or should we backport this to the v20.11? > [L.H.] yes, it can be backported. > Kevin, Luca, What do you think about backporting this patch to 19.11 & 20.11, it removes 'lib_musdk_dir' custom meson config option and uses pkg-config to find the musdk libraries. It looks good change but not sure if it is a regression to remove a build option. Thanks, ferruh