From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4D6E43F5F; Wed, 1 May 2024 13:13:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AB45402A7; Wed, 1 May 2024 13:13:56 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by mails.dpdk.org (Postfix) with ESMTP id 907CB4021E for ; Wed, 1 May 2024 13:13:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F/hfXw85EMF+uExz9d4HuAUkpQw8fDdUp0LeDDuKiFLrZmcbcO+Hmg44ec1faCvORYribvOlDmniCFyCtW3obCvCnt0G21Q44zRAuOCemDA+7/3hqVNZV+dYJ4eI5kqy5kaw6BHWsRV4MlCauZ5OoGAlJ7jYqXgaIPjzpYx+EEhO41+XomgZxs6Yj/buQzYIlrekq2RjVCHLluNvJa+M4UWqUZBjETejHOIMnraORySri6N/2a0UqLLot1Epyg6iDR/Er6Z71W3+a+yHyPq1ITIlXQ+ss6SPOKTaVhK19Vq+CuScak36jSBl/t3cV41It179YIy+qBA53m+SVXroiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OI9IVPBgkm7/2Mvih6OVQrF5yTqqNek0HBKVkc31s3I=; b=DLZGl/iPGVZ9QpkdXioisZyFoY/C2D0Hh9+yPCG0tHnfSl/kOMKiSLA0AlGjohjSGA11c2iYnjBlU1/wJX4Atd9QcAla+p45PzYk+RLBegDVMcJmUbQIfOnfvLwugcpoultMLQHtpo6SEcc5nDXYX0I2tra7kEl2HQNEt1FKOaakOkxzfEt6B+GdBENKAqIKL6arriju/3tLcrLXHnD0bnqZIUaW6WmGmlDbJIp1SiL/63UtstoB3+uwebJENTP7dd4NwFk0x7ObSgwy1VQJGxtPCrHnWPRkRs4FaYElNkZVubWKbU0E9VMXOObFr8Pqto0uyy9qAyd+rtMDyb2sAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OI9IVPBgkm7/2Mvih6OVQrF5yTqqNek0HBKVkc31s3I=; b=leQ7Ys3xupSv+vJ1IHmeqCoWTZddiu+c3DxUySKJH9xOi9PRZmxMHKNPm0QPSWqFHUcPJOLO3ZT/tp/jk5YhIA0r0W1JCYAIVJmsvISlmHwBqZHCFNxvIFoet4eY07IykdxRV48Z2HicE7dm7nfCuD0VGx/W+RyUfSK2JXvJPa8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH0PR12MB7886.namprd12.prod.outlook.com (2603:10b6:510:26e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Wed, 1 May 2024 11:13:49 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7519.035; Wed, 1 May 2024 11:13:48 +0000 Message-ID: <57fcc4d9-211b-4615-b380-2bf4f83926af@amd.com> Date: Wed, 1 May 2024 12:13:45 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/9] net/tap: do not duplicate fd's To: Stephen Hemminger , dev@dpdk.org References: <20240130034925.44869-1-stephen@networkplumber.org> <20240426155125.125910-1-stephen@networkplumber.org> <20240426155125.125910-2-stephen@networkplumber.org> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240426155125.125910-2-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZP191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH0PR12MB7886:EE_ X-MS-Office365-Filtering-Correlation-Id: 3adb8ba5-245c-430e-252a-08dc69cfc654 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eUZuaHpQSTJPRWJ4NXVLdU5RSGtTb0hidDhZK2ZRWTcvMnpGUGFjWTdYNzgv?= =?utf-8?B?Q0R0WGhxM041eENEY0JDMVNNb1hLRkw3SjU4S3VQSHUvQ2tzY0JBMXV2UDJT?= =?utf-8?B?N0lvY3lland4TjU4S2JES1Qya3I2ckx4M0dMb2NmRzI4MEp6NUpFbWlTYU9C?= =?utf-8?B?NWhDTlkzUEJ1UlBpQzlCdFZ4RGMwOFhOeXlrY0dTNTV0VEcxQlZWWVpZZUpW?= =?utf-8?B?bzhydmtoc3dQdzcyd0dNb0tEQURIZ0pmaHZJRGlEcUhqOWp5K0ZjMXVvSGVP?= =?utf-8?B?ZDdiQlV1M2JRcFhPUmdxeUVvU2NCbnh0c0RZNHhiRTh5aTRkQ01JOG1QekQ5?= =?utf-8?B?YXhlY2NvYmNzem1adnE3dk54WncvT1dTYWJQYXpGZ1JXN2h6bUszQk5TZ0ZF?= =?utf-8?B?a3IvZjh0allSYlhNYjBYdU9SYXJLd0k5aUZuRjhQL1M1UEdqeEdHOEpXWUlj?= =?utf-8?B?M0phYTF5SjI3REhmaysvYW1Oa2o1bVFYRnJpZ2wvbVdYeTd1VXl6Z0hmUWN4?= =?utf-8?B?bzkwa1hnN05taXdycnhUV1MwbzNMZlZXZC9CbnByeTZ2Ukc4U1JxMHBnOFFh?= =?utf-8?B?NEVZcFlrQ1hvODVJbDRLWHI4RmpzbWZMdUI1d01HQlJJOUgvTmlQUVl6ZS96?= =?utf-8?B?b1R3NjNGUVlLSXNJWmEzeW1YaWx0RXlzN21TK09nKzBDclJzcXB3WnNkalZt?= =?utf-8?B?dFVSM1F0VldUSytQY1FYMytlREN6YXpxSjNZa1V4SktiZUNQR0VUdVFWaU1U?= =?utf-8?B?dUdxYnJzdkRXVHE2Zjk0UTNOQnhzaldMVk5WU3pOeFZXOGZ2YlczV3BGbC96?= =?utf-8?B?OWdsZU5PNG12U0lscXlKMHRyNzRBYk5Wa0RvUFNYSlNBOHUrSUkrYUlIcy9W?= =?utf-8?B?QUh1UXo0d0M1V3dpUGhHaEl1T0pmYVV5bUg3WUUzRk5oWkh4YmdXL1FkNFNT?= =?utf-8?B?Zm9NUDlyazFGc3BDSGdJditJbGFyV1VKalVFdzJybTRhcGgzeWgrWmg0S0RC?= =?utf-8?B?V1BEcGZuY3E5REFhd1JINlEzSS9qUnRnNjBwbDVwY2RPcFV2SGxwSlZHdk5T?= =?utf-8?B?VWcxQ0dFbDZETDIxZ2VUVUZYWXIwTmNHSmdsMFk0ekNVRVpvS2ZOMVVYRUUw?= =?utf-8?B?NTBlcHVJb3pHYmltQTNWV0lpNWlSSTVyL3JkaUVSczdab2dnTDRiRnRhVWVO?= =?utf-8?B?UUNSNjIyR2M0R1hiVHgvMnRtZEl1Q2g1eDRHN0xwM2ZCWENEODQxZkhRdWFW?= =?utf-8?B?UUJjRXlYT1AzOGpEV0Q4eDRBSHdjMDRkR0M0V1hKMnVaVVdrUjFrVHR5VnFQ?= =?utf-8?B?anlMOEpXdVZuV1R6QmhqSFRydVJsalFmSEFPWThvSnQ5TUVoWjFtVTZLZDdG?= =?utf-8?B?eHR3WVZDOXJOVjc1L2xocDlzOUtUMk9SWjhlTS9mSldFUUJ3WG5uazFlUXdM?= =?utf-8?B?TldYU291L0xxL3ZVK3RnbGpTUlFqMk9QUFBpOXRqektaVDM3UzJNVlllWlM1?= =?utf-8?B?anozTm1zUUlOeEE0a2JKU2xwRDhWUmQ0cVRPNW1pMnBpazBreGdiN3NZYW0r?= =?utf-8?B?T3VIV0JDN0VDQkVpNGdyRXFhczl5MGJTTlNyRDVYMVdicXFZN2ZWYW53TlJa?= =?utf-8?B?cE1OK25ZOEl3cExGK1RwK253cmt5N3B0VnVLQlRnV3lNMTNPQVR0NDVvR0c3?= =?utf-8?B?aTJ5ZTVuVjZRWUQxaDNjQXdvcnBkcUQ2Skc4Z2V1Ym9HUHM0eitZY0RRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDJSTXdmN0p4cFNKZHFRU0ZEQUtaYU1ObTJESkcvNllHdGRxUXBoVDJkc3VZ?= =?utf-8?B?dktIV3lueUdnMG8zb2EvTXQ2NG0rdGc2OTVsZklDUmgxTUpsN0hJNWpXa2FS?= =?utf-8?B?VGhZZExLTnRjNlRUbENnN1htazVtQi8xMktYVFBHOXA5RzlSd1JGc0NlRUx1?= =?utf-8?B?RTgrK0RRdzBRc0RnVm9JL1M3TFNEdFF6RlJ1cHdDaEdXS3RTWXZYTnpDV0kr?= =?utf-8?B?Qzh0VkhKSENxd1JkWmRyZ2pjS1grV1ZocmNxaFVUby9jWjNLcElEbDhWV0hX?= =?utf-8?B?MVlFZTRpbFpBLzQ2MzdrdGh2bDdoUWVVVG83czFySktkM21ZdjR5OHhXdnF2?= =?utf-8?B?SzVwNGpkRzdLb3dpUUp4cFRoOGgza0U1dGZhOGxiL1Z5RXROTEFrV0Z0bnRN?= =?utf-8?B?d3pCNEJtOHVMdFNZWkpodkJpbDh1Mmo2VGN5eStmaDRQbXlNNlBYN3JjMHda?= =?utf-8?B?NHB0UlY3Qnhrd21ZemFleC8rZEM2Q0ZwVjZIMkVLdFZDSWM4U3NPdkNpTkRO?= =?utf-8?B?VjdNQlZiUVlEVVlpR1BGK0lNczZaUE5MVHhiYkdka3RuU2x4dGNCckFBeGFr?= =?utf-8?B?RmlhTCs4NzV2MXFWcGVLRVZZaDYzYlFXTUtxK3djR0F5VXVrMWl1YWJPVXNR?= =?utf-8?B?aXJNWEFLMVFQUDhpOEFNOFYrWE50anlwL1YydG1aL0drc3N5YW9hV1VJaDRE?= =?utf-8?B?UlQ2MllRQ20wZTJUeEM1ZnFVLzdDbS9Vb282emMwczlId0FpNGY5N2J1Nmdw?= =?utf-8?B?YXh6MEtXQUZiUThKbVpQRDNqaWtVcDMzcGY1RTFodFlnSGltSGtYTk5nbWNt?= =?utf-8?B?b3NNSktXVnhKdCtXYlY0SXJnZDUzeloxVXQ2Y2Q3dVFjajgydWU5VGY1WFgr?= =?utf-8?B?WitkbmFCZUY4OENsUWxnZk12WDAxYzczMm5ZTTRMQjRSNmNNaTVZVnJnV3Fr?= =?utf-8?B?WkwxTnlDQ3N2V0VINkRRc2tYNDNKRDFSUjJXbTBWcytjZTc3NFpvUzJsaWcr?= =?utf-8?B?S1pzRi80TXNtRG9QQXZNU09YYnl1L25halJ0bWx3TEF0ayt0VVF0UENTNEQr?= =?utf-8?B?MExwM1NibTFvOHBEQndzOVExOHh6Ynp2Y2xQUk5FMFNsQTEzN1Y0RVVDZFBL?= =?utf-8?B?OXd5dW9OeUpMb05Zc1FJY2pCR1Y4SlkxVHVOT1hINWJUSUZ0RG41bm52VlBX?= =?utf-8?B?emg5ZkJncXRNUGJ2OVgvd3p2OVczVEJiVEVHOHdnZGcrWlFSQWd2Nkc1MkQ2?= =?utf-8?B?VWpObmtqOHVuOGF1MmhNSVgyR2V3MTVoWU0rdCtFMHc2dCt2dWwyUzVwQ2lm?= =?utf-8?B?VDdLVDlTWW5jWTZ5c3VZNUhFMW5HSU1menBMZlNQKzZBekk4ODlMRlNYRWta?= =?utf-8?B?M015eUJwdzhzQzJqUWQ5b0I1UnQ2VkxETzluM1lTdmFjaDVCVUlIaTZieC9P?= =?utf-8?B?MWpDSmRiaFgwblRUaGZqeWdsU1RaZ2pBOVgrOStWeVk5aXRRU01vNVlHK3FJ?= =?utf-8?B?RGdGckV1dXEyc0pSMWNGeXEzRnlSWXM5UGxZUTduUEp3SFVOdUd6c2FVbW9z?= =?utf-8?B?dTBEYnBZYTFCNkdkQVdiWHM0cFlnQ2c4cXd6TVJuZ0ZXMFk3ZnNzeHVaNG9D?= =?utf-8?B?L0JDVEZGT1BMbDUxTExGRlJrSDBVVGlCWmF5b05MTTRIZ3pmbWRCb01heUJ1?= =?utf-8?B?S2ZzQzFjamZITzRUQW5leG56YkNXS1pOMW1ieEdxMUdDT1NaK25LcVhiOWhU?= =?utf-8?B?ZFhueEh6dU5qZndkK1BSeGZXNjU1N1RDNFllWWZnU0RlNlRtYVo3cjNmZXZa?= =?utf-8?B?R3I2ZEl4NGo1azBtNUc2UWFZYWRrV0FzYmgyeEt5NVMvcFFwVTBrZ1dsNUY5?= =?utf-8?B?UXJubWkvVWpTZWNlcG5yMkRhcVRDMnMyZ3l1UitTS3EzSk5BdHh4ZTdBckZN?= =?utf-8?B?VU16WSt6QmpWQ3FFOXkrZnRyRm9XSXlMY3Bxa1FMKzl1NUhJR0w1SUZhRS93?= =?utf-8?B?THhiMitSQVFPUlgvZk1JYjhxTVlPVFFub2xYZjcrTnFRTiszL2w1WnJmaENI?= =?utf-8?B?blZFWmsvejR3UWVnb0R6anhXSVQrUmxncEhqQmpUYmhxcmpyeWtJNStHalpV?= =?utf-8?Q?eCqAUR2nDQg9k35TulTpIonZZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3adb8ba5-245c-430e-252a-08dc69cfc654 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 11:13:48.7644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yQqV4f9aftmBlSW77JuVE4nWzASLFDQ1BxhG3KMRJuqc37BB0OX1vo+R4NeB5CH7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7886 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/26/2024 4:48 PM, Stephen Hemminger wrote: > The TAP device can use same file descriptopr for both rx and tx queues. > s/descriptopr/descriptor/ > This allows up to 8 queues (versus 4) to be used with secondary process. > > Signed-off-by: Stephen Hemminger <...> > @@ -1141,19 +1132,18 @@ tap_dev_close(struct rte_eth_dev *dev) > } > > for (i = 0; i < RTE_PMD_TAP_MAX_QUEUES; i++) { > - if (process_private->rxq_fds[i] != -1) { > - rxq = &internals->rxq[i]; > - close(process_private->rxq_fds[i]); > - process_private->rxq_fds[i] = -1; > - tap_rxq_pool_free(rxq->pool); > - rte_free(rxq->iovecs); > - rxq->pool = NULL; > - rxq->iovecs = NULL; > - } > - if (process_private->txq_fds[i] != -1) { > - close(process_private->txq_fds[i]); > - process_private->txq_fds[i] = -1; > - } > + struct rx_queue *rxq = &internals->rxq[i]; > + > + if (process_private->fds[i] == -1) > + continue; > + > + close(process_private->fds[i]); > + process_private->fds[i] = -1; > can 'tap_queue_close()' be used here? (probably with slight change) <...> > @@ -1482,52 +1480,34 @@ tap_setup_queue(struct rte_eth_dev *dev, > uint16_t qid, > int is_rx) > { > - int ret; > - int *fd; > - int *other_fd; > - const char *dir; > + int fd, ret; > struct pmd_internals *pmd = dev->data->dev_private; > struct pmd_process_private *process_private = dev->process_private; > struct rx_queue *rx = &internals->rxq[qid]; > struct tx_queue *tx = &internals->txq[qid]; > - struct rte_gso_ctx *gso_ctx; > + struct rte_gso_ctx *gso_ctx = NULL; > + const char *dir = is_rx ? "rx" : "tx"; > > - if (is_rx) { > - fd = &process_private->rxq_fds[qid]; > - other_fd = &process_private->txq_fds[qid]; > - dir = "rx"; > - gso_ctx = NULL; > - } else { > - fd = &process_private->txq_fds[qid]; > - other_fd = &process_private->rxq_fds[qid]; > - dir = "tx"; > + if (is_rx) > gso_ctx = &tx->gso_ctx; > As commented on other version of this patch, shouldn't this be: `if (!is_rx)` <...> > diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c > index fa50fe45d7..a78fd50cd4 100644 > --- a/drivers/net/tap/tap_flow.c > +++ b/drivers/net/tap/tap_flow.c > @@ -1595,8 +1595,9 @@ tap_flow_isolate(struct rte_eth_dev *dev, > * If netdevice is there, setup appropriate flow rules immediately. > * Otherwise it will be set when bringing up the netdevice (tun_alloc). > */ > - if (!process_private->rxq_fds[0]) > + if (process_private->fds[0] == -1) > change in the condition looks reasonable but not directly related with the change, does it require its own patch?