From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71DF3A0487 for <public@inbox.dpdk.org>; Thu, 4 Jul 2019 17:22:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 460675680; Thu, 4 Jul 2019 17:22:47 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 3802F2C60 for <dev@dpdk.org>; Thu, 4 Jul 2019 17:22:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AB3802179E; Thu, 4 Jul 2019 11:22:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 04 Jul 2019 11:22:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=DNWQ3wNRN5AtGDi+yDLJERz2kfmQ8ft3hR9U4XDiGgI=; b=RWZrqlAiM5nz cksc04WXQctlfy7/0F35+MCo8GUjMkNo/j3imHZHypECSPT+RMZcgXrsDGgI8v2w 0sAYpsxeLDzM/VverE949FzTRrUwEfEYhzcWjH9q2F4EpnHmjMtyEAbXgsOWgiFY ki8Ex1s3t6g0N6BkQ92O5zJRL8kIUDc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=DNWQ3wNRN5AtGDi+yDLJERz2kfmQ8ft3hR9U4XDiG gI=; b=waSh0WhRCKEH2vmB0wF+/+s5yr0NuG4t7P/5DQTx7yJc1QVIFA2KjEPMe WDXJKSWjE98e27p93ZCzQ0xO+aI98+3e/oMxfYfAEBwQkc3DkgFcDJN2MuInYvvJ umECPq4LKYY5wNZ9HsmInKul3WodnJq5BhYaa/QiTOzIlpJQyrt3YpAtwxx1mDrD N607laYtUXgvQv7MsBS/IWT0n5JbJ2lrnOAU1srRZeYZHVpbMYYkt9btTLYfkwNq rmMRKqzx52b1ViZzlDa8PaKHCIfSLn/i0zZSXZlQXXA7PWwhYs9jIBRg3AWFUSOl OLMOQpZBrH2sYMD40PJWZf9BpCdsQ== X-ME-Sender: <xms:wxkeXUrV3uDE_Ted5XUsUby4rChoFNsKDuWu9GWes92FV5RSu-kzhA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfedvgdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:wxkeXfMXu9Y9xzBfM_KT-W0bvQqeIOm27o2jM60TyINOygNmWOzqOg> <xmx:wxkeXeoH4nLz_Ff4YEYwDjJUKgFkQDfPmdUERdC66PkGJ9V-t2hs6g> <xmx:wxkeXegCAJhINNjTW8GV1n38YOq8qN8Qj12MNPi6_A5jD99Nkr3dUw> <xmx:xBkeXeHC-n4xUCdgFWj0FsQwymRhOKR2WNR8zZklCY960pALVsGmQQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0981C80062; Thu, 4 Jul 2019 11:22:42 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Li Qiang <liq3ea@163.com> Cc: dev@dpdk.org, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, liq3ea@gmail.com, akhil.goyal@nxp.com Date: Thu, 04 Jul 2019 17:22:42 +0200 Message-ID: <5809108.olxRzOrvUf@xps> In-Reply-To: <20190409145621.3099-1-liq3ea@163.com> References: <20190409145621.3099-1-liq3ea@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] drivers: dpaa: fix 'bman_pool' leak in dpaa_mbuf_create_pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 09/04/2019 16:56, Li Qiang: > When 'rte_zmalloc' failed dpaa_mbuf_create_pool() forgets freeing > 'bp' thus leading resource leak. This patch avoids this. > > Spotted by Coverity: CID 337679 > > Signed-off-by: Li Qiang <liq3ea@163.com> Applied, thanks Sorry for the delay, I missed the ack from Hemant which was not threaded and not in patchwork.