From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [58.251.152.64]) by dpdk.org (Postfix) with ESMTP id 33CF72BF9 for ; Tue, 1 Nov 2016 13:32:43 +0100 (CET) Received: from 172.24.1.60 (EHLO SZXEML423-HUB.china.huawei.com) ([172.24.1.60]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DUK39586; Tue, 01 Nov 2016 20:32:41 +0800 (CST) Received: from [127.0.0.1] (10.177.20.223) by SZXEML423-HUB.china.huawei.com (10.82.67.154) with Microsoft SMTP Server id 14.3.235.1; Tue, 1 Nov 2016 20:32:39 +0800 To: Ferruh Yigit , , References: <1477885947-35804-1-git-send-email-haifeng.lin@huawei.com> <227a3391-019d-3a4c-e76f-d1775466261b@intel.com> From: linhaifeng Message-ID: <58188B66.2050108@huawei.com> Date: Tue, 1 Nov 2016 20:32:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <227a3391-019d-3a4c-e76f-d1775466261b@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.20.223] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] net/bonding: not handle vlan slow packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2016 12:32:45 -0000 在 2016/11/1 18:46, Ferruh Yigit 写道: > Hi Haifeng, > > On 10/31/2016 3:52 AM, linhaifeng wrote: >> From: Haifeng Lin >> >> if rx vlan offload is enable we should not handle vlan slow >> packets too. >> >> Signed-off-by: Haifeng Lin >> --- >> drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c >> index 09ce7bf..ca17898 100644 >> --- a/drivers/net/bonding/rte_eth_bond_pmd.c >> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >> @@ -169,7 +169,8 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, >> /* Remove packet from array if it is slow packet or slave is not >> * in collecting state or bondign interface is not in promiscus >> * mode and packet address does not match. */ >> - if (unlikely(hdr->ether_type == ether_type_slow_be || >> + if (unlikely((hdr->ether_type == ether_type_slow_be && >> + !bufs[j]->vlan_tci) || >> !collecting || (!promisc && >> !is_multicast_ether_addr(&hdr->d_addr) && >> !is_same_ether_addr(&bond_mac, &hdr->d_addr)))) { >> > > There are a few version of this patch, I guess this one is the correct > one, can you please confirm? > Also this one supersede following one, right? > http://dpdk.org/dev/patchwork/patch/16840/ yes，this is > > It helps a lot if you use versioning in the patches [PATCH -vN] and add > a description of changes in commit log (after "---") between patch versions. > ok，i think should not send patch so worry：） I have a question to ask： Is there any other packets' type also is 0x8809 except with lacp packets? I saw some guests try to use this type to check link status between VM but droped by lacp bond recv function. > Thanks, > ferruh > > . >