From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [119.145.14.66]) by dpdk.org (Postfix) with ESMTP id A1FD81DB1 for ; Fri, 4 Nov 2016 04:16:38 +0100 (CET) Received: from 172.24.1.136 (EHLO SZXEML424-HUB.china.huawei.com) ([172.24.1.136]) by szxrg03-dlp.huawei.com (MOS 4.4.3-GA FastPath queued) with ESMTP id CKU45509; Fri, 04 Nov 2016 11:16:27 +0800 (CST) Received: from [127.0.0.1] (10.177.20.223) by SZXEML424-HUB.china.huawei.com (10.82.67.153) with Microsoft SMTP Server id 14.3.235.1; Fri, 4 Nov 2016 11:16:24 +0800 To: Ferruh Yigit , , References: <1477885947-35804-1-git-send-email-haifeng.lin@huawei.com> <227a3391-019d-3a4c-e76f-d1775466261b@intel.com> <58188B66.2050108@huawei.com> From: linhaifeng Message-ID: <581BFD81.30702@huawei.com> Date: Fri, 4 Nov 2016 11:16:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <58188B66.2050108@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.20.223] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] net/bonding: not handle vlan slow packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2016 03:16:40 -0000 Hi,all please ignore the patch which title is "net/bonding: not handle vlan slow packet", I will send another one. 在 2016/11/1 20:32, linhaifeng 写道: > 在 2016/11/1 18:46, Ferruh Yigit 写道: >> Hi Haifeng, >> >> On 10/31/2016 3:52 AM, linhaifeng wrote: >>> From: Haifeng Lin >>> >>> if rx vlan offload is enable we should not handle vlan slow >>> packets too. >>> >>> Signed-off-by: Haifeng Lin >>> --- >>> drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c >>> index 09ce7bf..ca17898 100644 >>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c >>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >>> @@ -169,7 +169,8 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, >>> /* Remove packet from array if it is slow packet or slave is not >>> * in collecting state or bondign interface is not in promiscus >>> * mode and packet address does not match. */ >>> - if (unlikely(hdr->ether_type == ether_type_slow_be || >>> + if (unlikely((hdr->ether_type == ether_type_slow_be && >>> + !bufs[j]->vlan_tci) || >>> !collecting || (!promisc && >>> !is_multicast_ether_addr(&hdr->d_addr) && >>> !is_same_ether_addr(&bond_mac, &hdr->d_addr)))) { >>> >> >> There are a few version of this patch, I guess this one is the correct >> one, can you please confirm? >> Also this one supersede following one, right? >> http://dpdk.org/dev/patchwork/patch/16840/ > > yes，this is > >> >> It helps a lot if you use versioning in the patches [PATCH -vN] and add >> a description of changes in commit log (after "---") between patch versions. >> > > ok，i think should not send patch so worry：） > > I have a question to ask： > Is there any other packets' type also is 0x8809 except with lacp packets? > I saw some guests try to use this type to check link status between VM > but droped by lacp bond recv function. > > >> Thanks, >> ferruh >> >> . >> >