DPDK patches and discussions
 help / color / mirror / Atom feed
* [RFC PATCH 0/4] Split driver specific commands out of testpmd
@ 2022-05-13  7:57 David Marchand
  2022-05-13  7:57 ` [RFC PATCH 1/4] app/testpmd: register driver specific commands David Marchand
                   ` (6 more replies)
  0 siblings, 7 replies; 65+ messages in thread
From: David Marchand @ 2022-05-13  7:57 UTC (permalink / raw)
  To: dev; +Cc: thomas

Hello,

Following TB decision and recent discussions on the driver specific
commands in testpmd, here is a proposal on how the split could be done.

For now, this series simply moves the testpmd code in the driver
directory. The driver specific testpmd code is still compiled as part of
testpmd compilation via a global meson testpmd_driver_sources list.

TODO:
- ixgbe bypass commands in testpmd are "dead" code since switch to meson,
  as the RTE_LIBRTE_IXGBE_BYPASS define is not set while compiling testpmd.
  I am tempted to simply drop those, since no one complained about issue
  for the last two years. For now, this series reinstates them.

- this series keeps the command names as is. We could consolidate with a
  clear prefix so that users directly know they are exerting a special
  feature that makes no sense on other hw.
  For this, I had in mind introducing a "driver" top level prefix,
  where drivers would hook their specific stuff. For example:
  testpmd> driver ixgbe set vf split drop (port_id) (vf_id) (on|off)

- the documentation of those commands is left untouched, we should
  probably move any existing doc into the driver documentation itself.
  testpmd documentation could then have a generic
  "Driver specific commands" section pointing at all other driver docs.

Opinions on this first draft?


-- 
David Marchand

David Marchand (4):
  app/testpmd: register driver specific commands
  net/bonding: move testpmd commands
  net/i40e: move testpmd commands
  net/ixgbe: move testpmd commands

 app/test-pmd/cmdline.c                     | 9284 +++++++-------------
 app/test-pmd/meson.build                   |    8 +-
 app/test-pmd/testpmd.c                     |   18 +-
 app/test-pmd/testpmd.h                     |   21 +-
 drivers/meson.build                        |    5 +
 drivers/net/bonding/meson.build            |    1 +
 drivers/net/bonding/rte_eth_bond_testpmd.c | 1037 +++
 drivers/net/i40e/i40e_testpmd.c            |  655 ++
 drivers/net/i40e/meson.build               |    2 +
 drivers/net/ixgbe/ixgbe_testpmd.c          | 1147 +++
 drivers/net/ixgbe/meson.build              |    2 +
 meson.build                                |    2 +
 12 files changed, 6216 insertions(+), 5966 deletions(-)
 create mode 100644 drivers/net/bonding/rte_eth_bond_testpmd.c
 create mode 100644 drivers/net/i40e/i40e_testpmd.c
 create mode 100644 drivers/net/ixgbe/ixgbe_testpmd.c

-- 
2.23.0


^ permalink raw reply	[flat|nested] 65+ messages in thread

end of thread, other threads:[~2022-08-25 11:44 UTC | newest]

Thread overview: 65+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-13  7:57 [RFC PATCH 0/4] Split driver specific commands out of testpmd David Marchand
2022-05-13  7:57 ` [RFC PATCH 1/4] app/testpmd: register driver specific commands David Marchand
2022-05-13 10:30   ` David Marchand
2022-05-13  7:57 ` [RFC PATCH 2/4] net/bonding: move testpmd commands David Marchand
2022-05-13 10:09   ` Min Hu (Connor)
2022-05-18 17:24     ` David Marchand
2022-05-18 23:25       ` Konstantin Ananyev
2022-05-19  7:40         ` David Marchand
2022-05-19 11:26           ` Thomas Monjalon
2022-05-20  6:59             ` Andrew Rybchenko
2022-05-24  9:40               ` Konstantin Ananyev
2022-05-24 10:15                 ` Thomas Monjalon
2022-05-24 22:41                   ` Konstantin Ananyev
2022-05-13  7:57 ` [RFC PATCH 3/4] net/i40e: " David Marchand
2022-05-13  7:57 ` [RFC PATCH 4/4] net/ixgbe: " David Marchand
2022-05-18 19:46 ` [RFC PATCH v2 0/5] Split driver specific commands out of testpmd David Marchand
2022-05-18 19:46   ` [RFC PATCH v2 1/5] app/testpmd: mark cmdline symbols as static David Marchand
2022-05-20  6:28     ` Andrew Rybchenko
2022-05-18 19:46   ` [RFC PATCH v2 2/5] app/testpmd: register driver specific commands David Marchand
2022-05-20  6:55     ` Andrew Rybchenko
2022-05-18 19:46   ` [RFC PATCH v2 3/5] net/bonding: move testpmd commands David Marchand
2022-05-20  6:55     ` Andrew Rybchenko
2022-05-18 19:46   ` [RFC PATCH v2 4/5] net/i40e: " David Marchand
2022-05-18 19:46   ` [RFC PATCH v2 5/5] net/ixgbe: " David Marchand
2022-05-20  7:04   ` [RFC PATCH v2 0/5] Split driver specific commands out of testpmd Andrew Rybchenko
2022-05-23  7:10 ` [PATCH 0/6] " David Marchand
2022-05-23  7:10   ` [PATCH 1/6] app/testpmd: mark most cmdline symbols as static David Marchand
2022-05-23 10:19     ` Dumitrescu, Cristian
2022-05-23 18:09       ` Ferruh Yigit
2022-05-23  7:10   ` [PATCH 2/6] app/testpmd: register driver specific commands David Marchand
2022-05-23 18:10     ` Ferruh Yigit
2022-05-24 10:53       ` David Marchand
2022-05-24 11:43         ` Ferruh Yigit
2022-05-24 17:21     ` Thomas Monjalon
2022-05-24 17:44       ` David Marchand
2022-05-24 17:51         ` Thomas Monjalon
2022-05-23  7:10   ` [PATCH 3/6] net/bonding: move testpmd commands David Marchand
2022-05-23 18:10     ` Ferruh Yigit
2022-06-17  5:06     ` [PATCH v2] " David Marchand
2022-06-20 17:53       ` Ferruh Yigit
2022-05-23  7:10   ` [PATCH 4/6] net/i40e: " David Marchand
2022-06-17  5:07     ` [PATCH v2] " David Marchand
2022-06-20 17:53       ` Ferruh Yigit
2022-05-23  7:10   ` [PATCH 5/6] app/testpmd: drop ixgbe bypass commands David Marchand
2022-05-23 18:10     ` Ferruh Yigit
2022-06-17  5:07     ` [PATCH v2 1/3] app/testpmd: restore " David Marchand
2022-06-17  5:07       ` [PATCH v2 2/3] net/ixgbe: move testpmd commands David Marchand
2022-06-17  5:07       ` [PATCH v2 3/3] net/ixgbe: move bypass init in a testpmd command David Marchand
2022-06-20 19:04         ` Ferruh Yigit
2022-06-23 12:35           ` Zhang, Qi Z
2022-07-21  8:05     ` [PATCH v3 1/3] app/testpmd: restore ixgbe bypass commands David Marchand
2022-07-21  8:05       ` [PATCH v3 2/3] net/ixgbe: move testpmd commands David Marchand
2022-07-21  8:05       ` [PATCH v3 3/3] net/ixgbe: move bypass init in a testpmd command David Marchand
2022-08-25 10:37         ` Ferruh Yigit
2022-08-25 11:44       ` [PATCH v3 1/3] app/testpmd: restore ixgbe bypass commands Ferruh Yigit
2022-05-23  7:10   ` [PATCH 6/6] net/ixgbe: move testpmd commands David Marchand
2022-05-23 18:09   ` [PATCH 0/6] Split driver specific commands out of testpmd Ferruh Yigit
2022-05-24 20:06 ` [PATCH v2 0/2] " David Marchand
2022-05-24 20:06   ` [PATCH v2 1/2] app/testpmd: mark most cmdline symbols as static David Marchand
2022-05-31 15:15     ` Andrew Rybchenko
2022-05-24 20:06   ` [PATCH v2 2/2] app/testpmd: register driver specific commands David Marchand
2022-05-24 20:28     ` Thomas Monjalon
2022-05-31 15:14       ` Andrew Rybchenko
2022-05-31 15:18         ` David Marchand
2022-05-31 15:18   ` [PATCH v2 0/2] Split driver specific commands out of testpmd Andrew Rybchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).