Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/29/2017 3:42 PM, Tomasz Kulasek wrote:
> Some devices needs more time to initialize and bring interface up. When
> link is down the link properties are not valid, e.g. link_speed is
> reported as 0 and this is not a valid speed for slave as well as for whole
> bonding.
> 
> During NIC (and bonding) initialization there's concurrency between
> updating link status and adding slave to the bonding.
> 
> This patch:
> 
>  - adds delay before configuring bonding (if link is down) to be sure that
>    link status of new slave is valid,
>  - propagates information about link status from first slave with link up
>    instead of first slave at all, to be sure that link speed is valid.
> 
> Fixes: 6abd94d72ab5 ("net/bonding: fix check slaves link properties")
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
> v2 changes:
>  - Checkpatch warnings,
>  - Improved code style
Hi Declan,

Any comment on this patch?

Thanks,
ferruh