From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 9C0331B1EE for ; Tue, 26 Mar 2019 23:16:10 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 7D30B4739; Tue, 26 Mar 2019 18:16:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 18:16:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ObTtlAq3TwX7REDcII2wJX7JeVrHt3zg6hCoPu67EVA=; b=ME3InP0r6dXe 4HLZgTdXmM22RpZG4JliKi69YwYRmBxladfiH8pZN0g5G3n05LkG1E62sjlkKYK/ xDDuNqmPWPoDEP18XOWHLVhe7kdvSIJnTpJxWs8eEldpS9DwN5xk/gTMVoFQFXfA hEpVExYzPJDLHp2AEMcb/fPe3XpjJPo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ObTtlAq3TwX7REDcII2wJX7JeVrHt3zg6hCoPu67E VA=; b=BckM63C5csbbGBjhbKveFL74oYAymJvKaLiV4tMCx+eFS291YbQwwEsFr JvFGzlfEzI+H0ixHv7PlE/+5pZ42djZr+pHki4KVrkkVIIfrSsIvLSmiLLbofIXo khjTzanQhd7xydrOV88xHb0EjuL4Jx3tVdqaXOKRebBh84tTh0UNNTuXeRZqUITf Pkzp+ZxiyTBeO6I4V5QiS1zwEIwTFe9FWpdKitznU4mYrUpZV6giT/3JbcHi+NSG 68iXLtYIyYgIXBKmqh0ZW+Ct6G9NxcMulmqRqu17qensUk2MQdEYUgD6cRuHBUGG +lfUg3TC4gq5py0e+xx1lG/ygbpgg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedtgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 24AF2E415C; Tue, 26 Mar 2019 18:16:08 -0400 (EDT) From: Thomas Monjalon To: Andrius Sirvys Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Tue, 26 Mar 2019 23:16:06 +0100 Message-ID: <5822818.RL7zm77vO6@xps> In-Reply-To: <20190325103459.3228-1-andrius.sirvys@intel.com> References: <1551958101-104223-1-git-send-email-andrius.sirvys@intel.com> <20190325103459.3228-1-andrius.sirvys@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] build: move variable definition to top level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2019 22:16:10 -0000 25/03/2019 11:34, Andrius Sirvys: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Defining driver_classes in dpdk/meson.build file > will make it easier for compiling separate directories. > > In the process, we rename driver_classes to dpdk_driver_classes for > consistency with the other variables. > > Signed-off-by: Andrius Sirvys > Acked-by: Bruce Richardson Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1E1F8A05D3 for ; Tue, 26 Mar 2019 23:16:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2CF681B2AC; Tue, 26 Mar 2019 23:16:12 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 9C0331B1EE for ; Tue, 26 Mar 2019 23:16:10 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 7D30B4739; Tue, 26 Mar 2019 18:16:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 18:16:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ObTtlAq3TwX7REDcII2wJX7JeVrHt3zg6hCoPu67EVA=; b=ME3InP0r6dXe 4HLZgTdXmM22RpZG4JliKi69YwYRmBxladfiH8pZN0g5G3n05LkG1E62sjlkKYK/ xDDuNqmPWPoDEP18XOWHLVhe7kdvSIJnTpJxWs8eEldpS9DwN5xk/gTMVoFQFXfA hEpVExYzPJDLHp2AEMcb/fPe3XpjJPo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ObTtlAq3TwX7REDcII2wJX7JeVrHt3zg6hCoPu67E VA=; b=BckM63C5csbbGBjhbKveFL74oYAymJvKaLiV4tMCx+eFS291YbQwwEsFr JvFGzlfEzI+H0ixHv7PlE/+5pZ42djZr+pHki4KVrkkVIIfrSsIvLSmiLLbofIXo khjTzanQhd7xydrOV88xHb0EjuL4Jx3tVdqaXOKRebBh84tTh0UNNTuXeRZqUITf Pkzp+ZxiyTBeO6I4V5QiS1zwEIwTFe9FWpdKitznU4mYrUpZV6giT/3JbcHi+NSG 68iXLtYIyYgIXBKmqh0ZW+Ct6G9NxcMulmqRqu17qensUk2MQdEYUgD6cRuHBUGG +lfUg3TC4gq5py0e+xx1lG/ygbpgg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedtgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 24AF2E415C; Tue, 26 Mar 2019 18:16:08 -0400 (EDT) From: Thomas Monjalon To: Andrius Sirvys Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Tue, 26 Mar 2019 23:16:06 +0100 Message-ID: <5822818.RL7zm77vO6@xps> In-Reply-To: <20190325103459.3228-1-andrius.sirvys@intel.com> References: <1551958101-104223-1-git-send-email-andrius.sirvys@intel.com> <20190325103459.3228-1-andrius.sirvys@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5] build: move variable definition to top level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326221606.uXmeQ3i7djd5sA2_GtueEiDiokTbJJVNB623IhhM-TU@z> 25/03/2019 11:34, Andrius Sirvys: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Defining driver_classes in dpdk/meson.build file > will make it easier for compiling separate directories. > > In the process, we rename driver_classes to dpdk_driver_classes for > consistency with the other variables. > > Signed-off-by: Andrius Sirvys > Acked-by: Bruce Richardson Applied, thanks