From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5637AA0527; Mon, 9 Nov 2020 20:26:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3364B697C; Mon, 9 Nov 2020 20:26:19 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id E3100697B for ; Mon, 9 Nov 2020 20:26:16 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id C58FCBE8; Mon, 9 Nov 2020 14:26:13 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 09 Nov 2020 14:26:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= O8iLIZST4DFbumhJ5QXdOJj2/y8tzel6/OmqEONOL9o=; b=d5yQv0JajiIuUmp4 d1WMbLrIK5pzWyYCImCf7w8keW5/qOunFSdQ1AFBkbQJbi1Uu4RMoFRoTOZY9IO0 3XSfObpomxMkmmzblo7kDZ/bI29vBUBAzJJ/vBIwSst4fJ9cJ9NulCiOdlueaGSU Fp9vZjwkJuWT5oQIjMXxIWNZaZTVchKdO4egJbmKnyqvON3L6iOvI0IZUcA1TARg wPweoozQcLUJAI0HgwGfcdYckprb5DeLrEB/WC4w6GZK3VlozJL6LOuMCd3YIYit //tA3fnewqtxyQ3WPk7A6nAFaFlc/yHFv91HKCt8sHTbrjON5IumFBVgy5g7jewT tYPhhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=O8iLIZST4DFbumhJ5QXdOJj2/y8tzel6/OmqEONOL 9o=; b=W27KDAiS9nuE0cNmlG1JcU2s91DJq+JCk4l+Q7Coq6x+SIbPvAScNAJCf vJSdOL9y+NFn62gNsdAOwI3ytCRf/z0XNoCBwpQFCvAsR4YxzkM/kRjUcRN7ycqf ExNf/SRJ0tG8oGUT+YXjQUr6X2Kv5llozXFeBc6vgIwNKFsDcZqnRCtjc9U22lHC c2dv4aaTDDdF5T5rh0KLOyc5S94YnRAG1rSPe7nIGXkn3ayxUJN8+RPjs2uccXhV aOE2pb4Aipb5lBc/nhQdd0VhE8GPyKQ9/VbHUpRoAraPJdSRV9fWNRLRIMxkTWuL Mo8ybOsB9H8wP7fM51Q/Zyv2WqNzQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduhedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F4C8306307C; Mon, 9 Nov 2020 14:26:12 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Date: Mon, 09 Nov 2020 20:26:10 +0100 Message-ID: <5825181.Lnf5Olbaf0@thomas> In-Reply-To: <20201109180216.GM831@bricha3-MOBL.ger.corp.intel.com> References: <20201027173836.891184-1-bruce.richardson@intel.com> <3123472.p7xLvF2YS7@thomas> <20201109180216.GM831@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2020 19:02, Bruce Richardson: > On Mon, Nov 09, 2020 at 06:09:51PM +0100, Thomas Monjalon wrote: > > 27/10/2020 18:38, Bruce Richardson: > > > To test the installation process of DPDK using "ninja install" > > > test-meson-builds.sh builds a subset of the examples using "make". To allow > > > more flexibility for people testing, allow the set of examples chosen for > > > this make test to be overridden using variable "DPDK_BUILD_TEST_EXAMPLES" > > > in the environment. > > > > > > Since a number of example apps link against drivers directly even for > > > shared builds, we need to ensure that LD_LIBRARY_PATH points to the main > > > DPDK lib folder so any dependencies of those drivers can be found e.g. that > > > the PCI/vdev bus driver .so is found. [All drivers are symlinked from > > > drivers dir back to lib dir on install, so only one dir rather than two is > > > needed in the path.] > > [...] > > > +libdir=$(dirname $(find $DESTDIR -name librte_eal.so)) > > > +export LD_LIBRARY_PATH=$libdir:$LD_LIBRARY_PATH > > > > I don't get why libdir is required for some examples, > > and not for others? The pkg-config file is not enough? > > > > It's only needed for examples that link against drivers directly. > > I believe it's needed in those cases, because app linker flags (including > e.g. -lrte_pmd_bond) occur before the pkg-config flags, which means that > the linker at that point does not have the path to find the dependencies of > the driver. [In a normal build, this wouldn't be necessary because the > library directory would be a standard path] If it's just a matter of ordering, it would be a better example to fix the ordering in the Makefile, isn't it?