From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
Shweta Choudaha <shweta.choudaha@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "shweta.choudaha@att.com" <shweta.choudaha@att.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit
Date: Wed, 4 Apr 2018 11:14:35 +0100 [thread overview]
Message-ID: <58259bea-6f5b-3bb9-0a82-f3e2b9dd428f@intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B76070A@shsmsx102.ccr.corp.intel.com>
On 4/4/2018 3:25 AM, Lu, Wenzhuo wrote:
> Hi Shweta,
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shweta Choudaha
>> Sent: Friday, February 23, 2018 7:59 PM
>> To: dev@dpdk.org
>> Cc: shweta.choudaha@att.com
>> Subject: [dpdk-dev] [PATCH 1/1] net/ixgbe: Add API to update SBP bit
>>
>> From: Shweta Choudaha <shweta.choudaha@att.com>
>>
>> Add ixgbe API to enable SBP bit in FCTRL register to allow receiving packets
>> that may otherwise be considered length errors by ixgbe and dropped
>>
>> Signed-off-by: Shweta Choudaha <shweta.choudaha@att.com>
>> Reviewed-by: Chas Williams <chas3@att.com>
>> Reviewed-by: Luca Boccassi <bluca@debian.org>
>> ---
>
>
>> --- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
>> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map
>> @@ -52,3 +52,9 @@ DPDK_17.08 {
>> rte_pmd_ixgbe_bypass_wd_timeout_show;
>> rte_pmd_ixgbe_bypass_wd_timeout_store;
>> } DPDK_17.05;
>> +
>> +EXPERIMENTAL {
>> + global:
>> +
>> + rte_pmd_ixgbe_upd_fctrl_sbp;
>> +} DPDK_17.08;
> The patch is fine except we should use 18.05 here.
We have a rule to have an API as experimental for one release.
Not sure about this rule covering the PMD specific APIs but by default it is, we
can discuss to have an exception for PMD APIs or not.
After one release developer should send patch to remove experimental from API
>
>> --
>> 2.11.0
>
next prev parent reply other threads:[~2018-04-04 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 11:59 [dpdk-dev] [PATCH 0/1] " Shweta Choudaha
2018-02-23 11:59 ` [dpdk-dev] [PATCH 1/1] " Shweta Choudaha
2018-04-04 2:25 ` Lu, Wenzhuo
2018-04-04 10:14 ` Ferruh Yigit [this message]
2018-04-04 10:40 ` Bruce Richardson
2018-04-10 15:58 ` Shweta Choudaha
2018-04-26 10:20 ` Shweta Choudaha
2018-04-26 10:56 ` Ferruh Yigit
2018-05-01 22:15 ` Shweta Choudaha
2018-04-10 15:42 ` [dpdk-dev] [PATCH v2] " Shweta Choudaha
2018-05-08 1:47 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58259bea-6f5b-3bb9-0a82-f3e2b9dd428f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=shweta.choudaha@att.com \
--cc=shweta.choudaha@gmail.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).